Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039092
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-08-03 15:012018-09-11 14:50
ReportermarvintmView Statuspublic 
Assigned Tomigueldejuana 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision39a43eb397a2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket3805
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039092: In some circumstances, cashup may be synchronized twice and the second one generates entry in "Errors while importing POS data"

DescriptionIn some circumstances, the cashup may be synchronized twice. The first time it will be processed correctly, but the second time detects that the cashup was already processed, and therefore generates an Error while importing POS Data.

Steps To Reproduce- Go to the cashup window.
- Go through all steps to complete the cashup.
- Before clicking on "Post, print and close" button, add a breakpoint in the client side, in the line:

"OB.RR.ServTypeFailover.implementation(service, request);"

- Click on the button. Flow will continue until the line with the breakpoint.
- Execute that line, but not the rest of the flow. The request will be done, and the cashup will be processed in the backend. This is correct.
- Then, press F5, or close the browser, and then access the WebPOS again.
- Once you have logged in, you will see that the cashup has already been sent again, and this time it has failed.

Real customers are reproducing this problem very rarely, with slow computers, and by closing the browser before the process to complete the cashup has been fully executed.
Proposed SolutionThe problem is that the generation of the message and the deletion of the cashup is still not fully transactional.

We need to make sure that both the message generation and the cashup deletion are executed in the same database transaction, but also before the request is triggered, because otherwise there is a risk that the deletion may not happen before the request is done, and even if the message is not generated, the cashup has already arrived to the backend, and should have already been removed from the client side.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0039264RR18Q3.1 closedmigueldejuana In some circumstances, cashup may be synchronized twice and the second one generates entry in "Errors while importing POS data" 
related to defect 0038969 closedranjith_qualiantech_com If a cashup with an approval is executed twice, an error is raised due to an ID duplication 

-  Notes
(0106421)
hgbot (developer)
2018-08-21 10:07

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 02b3aa0a2c01c6cb807c9b28b96f1b68fbea711c
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Aug 10 12:00:18 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/02b3aa0a2c01c6cb807c9b28b96f1b68fbea711c [^]

Fixed issue 0039092: In some circumstances, cashup may be synchronized twice and the second one generates entry in "Errors while importing POS data"

- Ensure that we do not send messages till we fully finished transaction (create message/remove model). Only for non persistent

---
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0106422)
hgbot (developer)
2018-08-21 10:07

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 91f14846d4cf7dc50acd987405ef7d266bf46b05
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Aug 14 10:12:58 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/91f14846d4cf7dc50acd987405ef7d266bf46b05 [^]

Fixed issue 0039092: In some circumstances, cashup may be synchronized twice and the second one generates entry in "Errors while importing POS data"

- Allow to execute removeSyncedElemsCallback for a model which defines this
- Do not forget to execute generic removeSyncedElemsCallback to continue with the rest of models

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0106423)
hgbot (developer)
2018-08-21 10:08

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6f58c90947b2d45b69a0ed1b24fa101c9abb52d9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Aug 20 12:36:14 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6f58c90947b2d45b69a0ed1b24fa101c9abb52d9 [^]

Fixed issue 0039092: In some circumstances, cashup may be synchronized twice and the second one generates entry in "Errors while importing POS data"

- Wait to sendMessages just for models coming from runSyncProcess

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0106424)
hgbot (developer)
2018-08-21 10:08

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 742d9d729e52c627394fc98138f1e350c87ba459
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Aug 20 17:24:00 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/742d9d729e52c627394fc98138f1e350c87ba459 [^]

Fixed issue 0039092: In some circumstances, cashup may be synchronized twice and the second one generates entry in "Errors while importing POS data"

- Execute callback(sendMessages) also for persistent models

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0106425)
hgbot (developer)
2018-08-21 10:08

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 39a43eb397a2761a529ba95c417bf1c5c14008a9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Aug 14 10:22:52 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/39a43eb397a2761a529ba95c417bf1c5c14008a9 [^]

Fixed issue 0039092: In some circumstances, cashup may be synchronized twice and the second one generates entry in "Errors while importing POS data"

- Define a removeSyncedElemsCallback to deleteCashups tables in cashup model.
- Make synchronous the deleteCashups function
- Allow to pass last cashup to initCashup createNewCashup function. Add a function createPaymentMethods which includes existing code

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---

- Issue History
Date Modified Username Field Change
2018-08-03 15:01 marvintm New Issue
2018-08-03 15:01 marvintm Assigned To => Retail
2018-08-03 15:01 marvintm OBNetwork customer => No
2018-08-03 15:01 marvintm Triggers an Emergency Pack => No
2018-08-03 15:01 marvintm OBNetwork customer No => Yes
2018-08-03 15:01 marvintm Resolution time => 1534716000
2018-08-06 09:15 ngarcia Support ticket => 3805
2018-08-06 09:15 ngarcia Issue Monitored: ngarcia
2018-08-16 08:27 marvintm Resolution time 1534716000 => 1535320800
2018-08-21 10:07 hgbot Checkin
2018-08-21 10:07 hgbot Note Added: 0106421
2018-08-21 10:07 hgbot Status new => resolved
2018-08-21 10:07 hgbot Resolution open => fixed
2018-08-21 10:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/02b3aa0a2c01c6cb807c9b28b96f1b68fbea711c [^]
2018-08-21 10:07 hgbot Checkin
2018-08-21 10:07 hgbot Note Added: 0106422
2018-08-21 10:07 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/02b3aa0a2c01c6cb807c9b28b96f1b68fbea711c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/91f14846d4cf7dc50acd987405ef7d266bf46b05 [^]
2018-08-21 10:08 hgbot Checkin
2018-08-21 10:08 hgbot Note Added: 0106423
2018-08-21 10:08 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/91f14846d4cf7dc50acd987405ef7d266bf46b05 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6f58c90947b2d45b69a0ed1b24fa101c9abb52d9 [^]
2018-08-21 10:08 hgbot Checkin
2018-08-21 10:08 hgbot Note Added: 0106424
2018-08-21 10:08 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6f58c90947b2d45b69a0ed1b24fa101c9abb52d9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/742d9d729e52c627394fc98138f1e350c87ba459 [^]
2018-08-21 10:08 hgbot Checkin
2018-08-21 10:08 hgbot Note Added: 0106425
2018-08-21 10:08 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/742d9d729e52c627394fc98138f1e350c87ba459 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/39a43eb397a2761a529ba95c417bf1c5c14008a9 [^]
2018-08-21 15:15 marvintm Assigned To Retail => migueldejuana
2018-08-23 12:16 marvintm Review Assigned To => marvintm
2018-08-23 12:16 marvintm Status resolved => closed
2018-08-23 12:16 marvintm Fixed in Version => RR18Q4
2018-08-27 14:52 ngarcia Relationship added related to 0038969
2018-09-11 14:50 migueldejuana Status closed => new
2018-09-11 14:50 migueldejuana Resolution fixed => open
2018-09-11 14:50 migueldejuana Fixed in Version RR18Q4 =>
2018-09-11 14:50 migueldejuana Status new => scheduled
2018-09-11 14:50 migueldejuana Status scheduled => resolved
2018-09-11 14:50 migueldejuana Resolution open => fixed
2018-09-11 14:50 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker