0039058: Add preference to hide entry menu for cancel and replace if has payments

diff --git a/src-db/database/sourcedata/AD_PREFERENCE.xml b/src-db/database/sourcedata/AD_PREFERENCE.xml
--- a/src-db/database/sourcedata/AD_PREFERENCE.xml
+++ b/src-db/database/sourcedata/AD_PREFERENCE.xml
@@ -1716,6 +1716,17 @@
 <!--FD1FC0F79350446CBD3A2193932F2BF6-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
 <!--FD1FC0F79350446CBD3A2193932F2BF6--></AD_PREFERENCE>
 
+<!--FD8A7562FB3F43C89D37A5048C45899B--><AD_PREFERENCE>
+<!--FD8A7562FB3F43C89D37A5048C45899B-->  <AD_PREFERENCE_ID><![CDATA[FD8A7562FB3F43C89D37A5048C45899B]]></AD_PREFERENCE_ID>
+<!--FD8A7562FB3F43C89D37A5048C45899B-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--FD8A7562FB3F43C89D37A5048C45899B-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--FD8A7562FB3F43C89D37A5048C45899B-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--FD8A7562FB3F43C89D37A5048C45899B-->  <VALUE><![CDATA[N]]></VALUE>
+<!--FD8A7562FB3F43C89D37A5048C45899B-->  <PROPERTY><![CDATA[OBPOS_payments.cancelAndReplace]]></PROPERTY>
+<!--FD8A7562FB3F43C89D37A5048C45899B-->  <ISPROPERTYLIST><![CDATA[Y]]></ISPROPERTYLIST>
+<!--FD8A7562FB3F43C89D37A5048C45899B-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
+<!--FD8A7562FB3F43C89D37A5048C45899B--></AD_PREFERENCE>
+
 <!--FDF887C070AE4083B596911D5314EBA9--><AD_PREFERENCE>
 <!--FDF887C070AE4083B596911D5314EBA9-->  <AD_PREFERENCE_ID><![CDATA[FDF887C070AE4083B596911D5314EBA9]]></AD_PREFERENCE_ID>
 <!--FDF887C070AE4083B596911D5314EBA9-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
diff --git a/src-db/database/sourcedata/AD_REF_LIST.xml b/src-db/database/sourcedata/AD_REF_LIST.xml
--- a/src-db/database/sourcedata/AD_REF_LIST.xml
+++ b/src-db/database/sourcedata/AD_REF_LIST.xml
@@ -1345,6 +1345,18 @@
 <!--88917BAF70ED44C4803EAD048ABA5412-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
 <!--88917BAF70ED44C4803EAD048ABA5412--></AD_REF_LIST>
 
+<!--89723B4B34E540ADA083D49339787F18--><AD_REF_LIST>
+<!--89723B4B34E540ADA083D49339787F18-->  <AD_REF_LIST_ID><![CDATA[89723B4B34E540ADA083D49339787F18]]></AD_REF_LIST_ID>
+<!--89723B4B34E540ADA083D49339787F18-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--89723B4B34E540ADA083D49339787F18-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--89723B4B34E540ADA083D49339787F18-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--89723B4B34E540ADA083D49339787F18-->  <VALUE><![CDATA[OBPOS_payments.hideCancelAndReplace]]></VALUE>
+<!--89723B4B34E540ADA083D49339787F18-->  <NAME><![CDATA[Hide entry menu for cancel and replace if not payments]]></NAME>
+<!--89723B4B34E540ADA083D49339787F18-->  <DESCRIPTION><![CDATA[Hide entry menu for cancel and replace if not payments]]></DESCRIPTION>
+<!--89723B4B34E540ADA083D49339787F18-->  <AD_REFERENCE_ID><![CDATA[A26BA480E2014707B47257024C3CBFF7]]></AD_REFERENCE_ID>
+<!--89723B4B34E540ADA083D49339787F18-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
+<!--89723B4B34E540ADA083D49339787F18--></AD_REF_LIST>
+
 <!--898DA3A00DD64A45A8478F78249EF521--><AD_REF_LIST>
 <!--898DA3A00DD64A45A8478F78249EF521-->  <AD_REF_LIST_ID><![CDATA[898DA3A00DD64A45A8478F78249EF521]]></AD_REF_LIST_ID>
 <!--898DA3A00DD64A45A8478F78249EF521-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
diff --git a/web/org.openbravo.retail.posterminal/js/components/menu.js b/web/org.openbravo.retail.posterminal/js/components/menu.js
--- a/web/org.openbravo.retail.posterminal/js/components/menu.js
+++ b/web/org.openbravo.retail.posterminal/js/components/menu.js
@@ -1346,6 +1346,8 @@
         this.hide();
       } else if (!OB.MobileApp.model.hasPermission('OBPOS_receipt.CancelAndReplaceOrdersWithDeliveries', true) && (deliveredresult === 'TD' || deliveredresult === 'DN')) {
         this.hide();
+      } else if (OB.MobileApp.model.hasPermission('OBPOS_payments.hideCancelAndReplace', true) && !haspayments) {
+        this.hide();
       } else {
         this.show();
       }

comparing with https://code.openbravo.com/tools/automation/pi-mobile/
searching for changes
changeset:   7545:3d9c27cf2523
tag:         tip
user:        Jonathan Bueno <jonathan.bueno@openbravo.com>
date:        Fri Jul 27 08:44:56 2018 +0200
summary:     Related to issue 39058:  Add preference to hide entry menu for cancel and replace if not payments

diff --git a/src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I39058_CancelAndRplcHideButtonIfNotPayments.java b/src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I39058_CancelAndRplcHideButtonIfNotPayments.java
new file mode 100644
--- /dev/null
+++ b/src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I39058_CancelAndRplcHideButtonIfNotPayments.java
@@ -0,0 +1,143 @@
+/*
+ *************************************************************************
+ * The contents of this file are subject to the Openbravo  Public  License
+ * Version  1.0  (the  "License"),  being   the  Mozilla   Public  License
+ * Version 1.1  with a permitted attribution clause; you may not  use this
+ * file except in compliance with the License. You  may  obtain  a copy of
+ * the License at http://www.openbravo.com/legal/license.html
+ * Software distributed under the License  is  distributed  on  an "AS IS"
+ * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
+ * License for the specific  language  governing  rights  and  limitations
+ * under the License.
+ * The Original Code is Openbravo ERP.
+ * The Initial Developer of the Original Code is Openbravo S.L.U.
+ * All portions are Copyright (C) 2016 Openbravo S.L.U.
+ * All Rights Reserved.
+ * Contributor(s):
+ ************************************************************************
+ *
+ *
+ */
+
+package org.openbravo.test.mobile.retail.pack.selenium.tests.cancelandreplace;
+
+import java.math.BigDecimal;
+
+import org.junit.Test;
+import org.openbravo.test.mobile.retail.mobilecore.annotations.TestClassAnnotations;
+import org.openbravo.test.mobile.retail.mobilecore.database.DatabaseHelperInsertUpdateOrDelete;
+import org.openbravo.test.mobile.retail.mobilecore.javascript.BackboneHelper;
+import org.openbravo.test.mobile.retail.pack.selenium.TestIdPack;
+import org.openbravo.test.mobile.retail.pack.selenium.terminals.WebPOSCancelAndReplaceTerminalHelper;
+
+@TestClassAnnotations(isHighVolumeCompatible = true)
+public class I39058_CancelAndRplcHideButtonIfNotPayments extends
+    WebPOSCancelAndReplaceTerminalHelper {
+
+  /**
+   * Basic Cancel and Replace of a lay away
+   */
+  @Test
+  public void test() {
+    try {
+      createPreference("Y");
+      reload();
+      tap(TestIdPack.BUTTON_SEARCH);
+      write(TestIdPack.FIELD_SEARCH_TEXT, "Avalanche transceiver");
+      tap(TestIdPack.BUTTON_SEARCH_EXECUTE);
+      tap(TestIdPack.BUTTON_SEARCHPRODUCT_AVALANCHETRANSCEIVER);
+      verify(TestIdPack.LABEL_TOTALTOPAY, "150.50");
+      tap(TestIdPack.BUTTON_EDIT);
+      tap(TestIdPack.BUTTON_KEYPAD_PLUS);
+      verify(TestIdPack.LABEL_TOTALTOPAY, "301.00");
+
+      final String receiptNo = BackboneHelper.getDocumentNo();
+
+      // Lay away the receipt
+      tap(TestIdPack.BUTTON_MENU);
+      tap(TestIdPack.BUTTON_MENU_LAYAWAYTHISRECEIPT);
+      verify(TestIdPack.LABEL_RECEIPT_TYPE, "To be laid away");
+
+      // Finish the lay away
+      tap(TestIdPack.BUTTON_PAY);
+      tap(TestIdPack.BUTTON_LAYAWAY);
+      verify(TestIdPack.LABEL_TOTALTOPAY, "0.00");
+
+      // Retrieve created lay away
+      tap(TestIdPack.BUTTON_MENU);
+      tap(TestIdPack.BUTTON_MENU_OPENRECEIPT);
+      write(TestIdPack.FIELD_OPEN_RECEIPT_FILTER_TXT, receiptNo);
+      tap(TestIdPack.BUTTON_OPEN_RECEIPT_SEARCH);
+      tap(TestIdPack.TABLE_OPEN_RECEIPT, receiptNo);
+      verify(TestIdPack.LABEL_TOTALTOPAY, "301.00");
+
+      tap(TestIdPack.BUTTON_MENU);
+      isVisible(TestIdPack.BUTTON_MENU_CANCELANDREPLACE, false);
+
+      deletePreference();
+      createPreference("N");
+      reload();
+
+      tap(TestIdPack.BUTTON_MENU);
+      tap(TestIdPack.BUTTON_MENU_CANCELANDREPLACE);
+
+      verify(TestIdPack.LABEL_RECEIPT_TYPE, "'Cancel and Replace' of  " + receiptNo);
+      verify(TestIdPack.LABEL_TOTALTOPAY, "301.00");
+      tap(TestIdPack.BUTTON_PAY);
+      verify(TestIdPack.LABEL_RECEIPT_PAY_REMAINING, "301.00€");
+      tap(TestIdPack.BUTTON_LAYAWAY);
+      verify(TestIdPack.LABEL_TOTALTOPAY, "0.00");
+
+      // Final checks
+      checkIsCanceled(receiptNo);
+      checkCanceledOrder(receiptNo, receiptNo + REVERSE_PREFIX);
+      checkReplacedOrder(receiptNo, receiptNo + REPLACED_ONE);
+
+      checkReceived(receiptNo, BigDecimal.valueOf(301.00));
+      checkReceived(receiptNo + REVERSE_PREFIX, BigDecimal.valueOf(-301.00));
+      checkReceived(receiptNo + REPLACED_ONE, BigDecimal.ZERO);
+
+      checkOutstanding(receiptNo, BigDecimal.ZERO);
+      checkOutstanding(receiptNo + REVERSE_PREFIX, BigDecimal.ZERO);
+      checkOutstanding(receiptNo + REPLACED_ONE, BigDecimal.valueOf(301.00));
+
+      checkNumberOfPayments(receiptNo, 1L);
+      checkNumberOfPayments(receiptNo + REVERSE_PREFIX, 1L);
+      checkNumberOfPayments(receiptNo + REPLACED_ONE, 0L);
+
+      checkPaymentDetail(receiptNo, BigDecimal.valueOf(301.00), CASH, BigDecimal.ZERO);
+      checkPaymentDetail(receiptNo + REVERSE_PREFIX, BigDecimal.valueOf(-301.00), CASH,
+          BigDecimal.ZERO);
+
+      checkLine(receiptNo, AVALANCHE_TRANSCEIVER, 2, 2);
+      checkLine(receiptNo + REVERSE_PREFIX, AVALANCHE_TRANSCEIVER, -2, -2);
+      checkLine(receiptNo + REPLACED_ONE, AVALANCHE_TRANSCEIVER, 2, 0);
+
+      checkLineShipment(receiptNo, AVALANCHE_TRANSCEIVER, 2, 2, false);
+      checkLineShipment(receiptNo + REVERSE_PREFIX, AVALANCHE_TRANSCEIVER, -2, -2, false);
+      checkLineShipment(receiptNo + REPLACED_ONE, AVALANCHE_TRANSCEIVER, 2, 0, false);
+
+    } finally {
+      deletePreference();
+      reload();
+    }
+  }
+
+  private void createPreference(String value) {
+    new DatabaseHelperInsertUpdateOrDelete(
+        "Insert Preference OBPOS_payments.hideCancelAndReplace for VallBlanca User")
+        .execute(
+            "INSERT INTO ad_preference( ad_preference_id, ad_client_id, ad_org_id, isactive, created, createdby, updated, updatedby, ad_window_id, ad_user_id, attribute, value, property, ispropertylist, visibleat_client_id, visibleat_org_id, visibleat_role_id, selected, ad_module_id, inherited_from) VALUES ( 'D2D82BCDA4BB4B69A54745C1AA0D9CD8', '39363B0921BB4293B48383844325E84C', '0', 'Y', TIMESTAMP '2018-07-26 17:58:21.391', '100', TIMESTAMP '2018-07-26 18:00:54.923', '100', NULL, '3073EDF96A3C42CC86C7069E379522D2', NULL, '"
+                + value
+                + "', 'OBPOS_payments.hideCancelAndReplace', 'Y', NULL, NULL, NULL, 'Y', NULL, NULL )",
+            1);
+
+  }
+
+  private void deletePreference() {
+    new DatabaseHelperInsertUpdateOrDelete(
+        "Remove existing OBPOS_payments.hideCancelAndReplace for VallBlanca User").execute(
+        "DELETE from AD_Preference WHERE ad_preference_id = 'D2D82BCDA4BB4B69A54745C1AA0D9CD8'", 1);
+
+  }
+}