0039055: Split lines process should be extensible

Description

The split lines feature can have an impact on extensions of the POS. To allow those extensions to deal with splitted lines this process should be extensible.

Steps To Reproduce

Check that there is no hook in the split process.

Proposed Solution

Add a hook at the end of the process, after splitting lines, with the following arguments:
- receipt
- original line (already changed)
- splitted lines

Attached is the proposed solution (this was created in an old version but the only difference is the use of the SynchronizationHelper)

Tags

No tags attached.

Attached Files

proposedSolution.diff [^] (1,027 bytes) 2018-07-26 12:05 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js b/web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
--- a/web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
+++ b/web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
@@ -455,9 +455,16 @@
           this.orderline.get('promotions').splice(index, 1, adjustedPromotion);
         }
       }, this);
-      OB.UTIL.SynchronizationHelper.finished(this.synchId, 'splitLines');
-      this.receipt.set('skipCalculateReceipt', false);
-      this.receipt.calculateReceipt();
+      var me = this;
+      OB.UTIL.HookManager.executeHooks('OBPOS_AfterSplitLine', {
+        receipt: this.receipt,
+        line: this.orderline,
+        splittedLines: this.splittedLines
+      }, function (args) {
+        OB.UTIL.SynchronizationHelper.finished(me.synchId, 'splitLines');
+        me.receipt.set('skipCalculateReceipt', false);
+        me.receipt.calculateReceipt();
+      });
     }
   },

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0108616) hgbot (developer) 2018-12-14 14:39	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: b75986abd5f93f776c861b82d7cc834f7278287c Author: Unai Martirena <unai.martirena <at> openbravo.com> Date: Mon Sep 03 15:58:01 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b75986abd5f93f776c861b82d7cc834f7278287c [^] Fixed issue 39055: Add new OBPOS_PostSplitLine hook in Split Line process --- M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js ---

Issue History
Date Modified	Username	Field	Change
2018-07-26 12:05	martinsdan	New Issue
2018-07-26 12:05	martinsdan	Assigned To	=> Retail
2018-07-26 12:05	martinsdan	File Added: proposedSolution.diff
2018-07-26 12:05	martinsdan	Triggers an Emergency Pack	=> No
2018-12-14 14:39	hgbot	Checkin
2018-12-14 14:39	hgbot	Note Added: 0108616
2018-12-14 14:39	hgbot	Status	new => resolved
2018-12-14 14:39	hgbot	Resolution	open => fixed
2018-12-14 14:39	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b75986abd5f93f776c861b82d7cc834f7278287c [^]
2018-12-17 10:21	marvintm	Review Assigned To	=> marvintm
2018-12-17 10:21	marvintm	Status	resolved => closed
2018-12-17 10:21	marvintm	Fixed in Version	=> RR19Q1