Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039052
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Remittanceminoralways2018-07-26 08:322018-09-04 17:34
ReporterguillermogilView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionce30899bc6fe
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Regression introduced in release
Summary

0039052: Cleanup bad logging in Remittance module: don't use printStackTrace or System.out.print* or System.err.print*

DescriptionThere are several printStackTrace in Remittance module:
grep -r printStackTrace .
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.java: ignore.printStackTrace();
./src/org/openbravo/module/remittance/erpReports/RptRemittance.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_actionbutton/SelectPayments.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_actionbutton/SelectPayments.java: e.printStackTrace();
./src/org/openbravo/module/remittance/process/REM_RemittanceSettleUndo.java: e.printStackTrace(System.err);
./src/org/openbravo/module/remittance/process/REM_RemittanceProtestUndo.java: e.printStackTrace(System.err);
./src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java: e.printStackTrace(System.err);
./src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java: e.printStackTrace();
Steps To ReproduceN/A
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0106602)
hgbot (developer)
2018-09-04 17:33

 Repository: erp/mods/org.openbravo.module.remittance
Changeset: ce30899bc6fed30cd70c4578067fbe5380d52d6a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Aug 07 00:56:53 2018 +0530
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/ce30899bc6fed30cd70c4578067fbe5380d52d6a [^]

Fixes Issue 39052:Cleanup bad logging in Remittance module: don't use
printStackTrace or System.out.print* or System.err.print*

** Log correctly the exceptions and do not use printStackTrace(),
   System.Out.print, System.err.print

---
M build/classes/org/openbravo/module/remittance/modulescript/PopulateBankInstructions.class
M build/classes/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.class
M build/classes/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRem.class
M build/classes/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.class
M build/classes/org/openbravo/module/remittance/modulescript/UpdateProcessRemittance.class
M build/classes/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.class
M src-util/modulescript/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructions_data.xsql
M src-util/modulescript/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRem_data.xsql
M src-util/modulescript/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittance_data.xsql
M src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java
M src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java
M src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.java
M src/org/openbravo/module/remittance/ad_actionbutton/SelectPayments.java
M src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java
M src/org/openbravo/module/remittance/erpReports/RptRemittance.java
M src/org/openbravo/module/remittance/process/REM_RemittanceProtestUndo.java
M src/org/openbravo/module/remittance/process/REM_RemittanceSettleUndo.java
---
(0106603)
hgbot (developer)
2018-09-04 17:33

 Repository: erp/mods/org.openbravo.module.remittance
Changeset: 651cf4bc7509b832ec3e3afa2969920e629bb465
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Sep 04 17:33:42 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/651cf4bc7509b832ec3e3afa2969920e629bb465 [^]

related to issue 39052 delete generated modulescript files

delete generated modulescript files that are not necessary
to push to the repository

---
R src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java
R src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java
R src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.java
---
(0106604)
Sandrahuguet (developer)
2018-09-04 17:34

 Code review + testing OK

- Issue History
Date Modified Username Field Change
2018-07-26 08:32 guillermogil New Issue
2018-07-26 08:32 guillermogil Assigned To => Triage Finance
2018-08-06 12:33 Sandrahuguet Assigned To Triage Finance => AtulOpenbravo
2018-08-06 17:47 AtulOpenbravo Status new => scheduled
2018-09-04 17:33 hgbot Checkin
2018-09-04 17:33 hgbot Note Added: 0106602
2018-09-04 17:33 hgbot Status scheduled => resolved
2018-09-04 17:33 hgbot Resolution open => fixed
2018-09-04 17:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/ce30899bc6fed30cd70c4578067fbe5380d52d6a [^]
2018-09-04 17:33 hgbot Checkin
2018-09-04 17:33 hgbot Note Added: 0106603
2018-09-04 17:34 Sandrahuguet Review Assigned To => Sandrahuguet
2018-09-04 17:34 Sandrahuguet Note Added: 0106604
2018-09-04 17:34 Sandrahuguet Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker