Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039052ModulesRemittancepublic2018-07-26 08:322018-09-04 17:34
Reporterguillermogil 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0039052: Cleanup bad logging in Remittance module: don't use printStackTrace or System.out.print* or System.err.print*
DescriptionThere are several printStackTrace in Remittance module:
grep -r printStackTrace .
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.java: ignore.printStackTrace();
./src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.java: ignore.printStackTrace();
./src/org/openbravo/module/remittance/erpReports/RptRemittance.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_actionbutton/SelectPayments.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_actionbutton/SelectPayments.java: e.printStackTrace();
./src/org/openbravo/module/remittance/process/REM_RemittanceSettleUndo.java: e.printStackTrace(System.err);
./src/org/openbravo/module/remittance/process/REM_RemittanceProtestUndo.java: e.printStackTrace(System.err);
./src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java: e.printStackTrace(System.err);
./src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java: e.printStackTrace();
./src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java: e.printStackTrace();
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-07-26 08:32guillermogilNew Issue
2018-07-26 08:32guillermogilAssigned To => Triage Finance
2018-08-06 12:33SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2018-08-06 17:47AtulOpenbravoStatusnew => scheduled
2018-09-04 17:33hgbotCheckin
2018-09-04 17:33hgbotNote Added: 0106602
2018-09-04 17:33hgbotStatusscheduled => resolved
2018-09-04 17:33hgbotResolutionopen => fixed
2018-09-04 17:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/ce30899bc6fed30cd70c4578067fbe5380d52d6a [^]
2018-09-04 17:33hgbotCheckin
2018-09-04 17:33hgbotNote Added: 0106603
2018-09-04 17:34SandrahuguetReview Assigned To => Sandrahuguet
2018-09-04 17:34SandrahuguetNote Added: 0106604
2018-09-04 17:34SandrahuguetStatusresolved => closed

Notes
(0106602)
hgbot   
2018-09-04 17:33   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: ce30899bc6fed30cd70c4578067fbe5380d52d6a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Aug 07 00:56:53 2018 +0530
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/ce30899bc6fed30cd70c4578067fbe5380d52d6a [^]

Fixes Issue 39052:Cleanup bad logging in Remittance module: don't use
printStackTrace or System.out.print* or System.err.print*

** Log correctly the exceptions and do not use printStackTrace(),
   System.Out.print, System.err.print

---
M build/classes/org/openbravo/module/remittance/modulescript/PopulateBankInstructions.class
M build/classes/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.class
M build/classes/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRem.class
M build/classes/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.class
M build/classes/org/openbravo/module/remittance/modulescript/UpdateProcessRemittance.class
M build/classes/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.class
M src-util/modulescript/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructions_data.xsql
M src-util/modulescript/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRem_data.xsql
M src-util/modulescript/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittance_data.xsql
M src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java
M src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java
M src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.java
M src/org/openbravo/module/remittance/ad_actionbutton/SelectPayments.java
M src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java
M src/org/openbravo/module/remittance/erpReports/RptRemittance.java
M src/org/openbravo/module/remittance/process/REM_RemittanceProtestUndo.java
M src/org/openbravo/module/remittance/process/REM_RemittanceSettleUndo.java
---
(0106603)
hgbot   
2018-09-04 17:33   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 651cf4bc7509b832ec3e3afa2969920e629bb465
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Sep 04 17:33:42 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/651cf4bc7509b832ec3e3afa2969920e629bb465 [^]

related to issue 39052 delete generated modulescript files

delete generated modulescript files that are not necessary
to push to the repository

---
R src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/PopulateBankInstructionsData.java
R src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateIsPaymentPaidRemData.java
R src-util/modulescript/src/src/org/openbravo/module/remittance/modulescript/UpdateProcessRemittanceData.java
---
(0106604)
Sandrahuguet   
2018-09-04 17:34   
Code review + testing OK