Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039013
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Credit Management - Dunningmajorhave not tried2018-07-23 14:482018-08-01 13:54
ReportershuehnerView Statuspublic 
Assigned Tomarkmm82 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiond9360a9a8c9c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Regression introduced in release
Summary

0039013: CustomerCalloutDK broken when used with ERP >=17Q1 or 17Q4

DescriptionDunning module contains the CustomerCalloutDK callout which is extending another callout from core named SE_Invoice_BPartner.

It does that by mocking an http-request and incoking the other callout.

However most callouts in core are no longer callable via http requests so that cannot work:
17Q1 change: https://code.openbravo.com/erp/devel/pi/rev/b468094df0d0ff1d168a03977ba314f64549b998 [^]
Makes callouts no longer be mapped via web.xml

17Q4 change: https://code.openbravo.com/erp/devel/pi/rev/2ab8016a23535c8182170c2dc4f991c2dc5786a9 [^]

Made the specific callouts not even being a servlet anymore.

The callout in this module should be refactored to extend the core callout the 'new way' http://wiki.openbravo.com/wiki/How_to_create_a_Callout#Extend_a_Callout [^]

When done the MockHttpServletResponse calls in the module should be removed as it will no longer be necessary.
As that class is not compatible with servet-api>30 (i.e. using tomcat8.5) that prepares the module to work with that tomcat version when that will be used in pi by default in short.
Steps To ReproduceFor the functional bug -> try to run the callout.

For the 'MockHttpServletResponse' not working with tomcat8.5
Setup eclipse with tomcat8.5 and notice this java file in the module no longer compiling.
Proposed Solution-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0105969)
markmm82 (developer)
2018-07-26 22:43

 Test Plan:
Set the environment following the document:
http://forge.openbravo.com/plugins/mwiki/index.php/Creditmgtdunning/User_Documentation [^]
As System Admin
  Go to Windows, Tabs and Fields and select Sales Invoice window.
  Go to Lines Tab -> Fields and select the Business Partner field.
  Navigates to the column definition and change the SE_Invoice_BPartner Callout by CustomerCalloutDK callout.
As F&B group admin
  Go to Business Partner window and set up a dunning configuration to Alimentos y Supermercados, S.A customer.
  Create a new Sales Invoice header, select Alimentos y Supermercados, S.A bp.
    Notice that several fields like pice list, address, payment metho, etc has been updated by the SE_Invoice_BPartner callout.
    Also notice that the Dunning Key has been updated with the dunning key previously set to the BP. This action performed by the CustomerCalloutDK callout.

After install the patch try, and using tomcat 8.5 try to recompile the system and it is success
(0106082)
hgbot (developer)
2018-08-01 12:56

 Repository: erp/pmods/org.openbravo.creditmanagement.dunning
Changeset: d9360a9a8c9c1811b0fd1140c93e142859925c75
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Jul 26 16:30:04 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.creditmanagement.dunning/rev/d9360a9a8c9c1811b0fd1140c93e142859925c75 [^]

Fixes issue 39013: CustomerCalloutDK broken when used with ERP >=17Q1 or 17Q4

The callout CustomerCalloutDK has been refactored to extend the core callout
SE_Invoice_BPartner instead of HttpSecureAppServlet as it is not used anymore.
Also it avoid the MockHttpServletResponse calls as it is not needed anymore and
it isn't compatible with servet-api>30.

---
M src/org/openbravo/creditmanagement/dunning/callouts/CustomerCalloutDK.java
---
(0106083)
hgbot (developer)
2018-08-01 12:56

 Repository: erp/pmods/org.openbravo.creditmanagement.dunning
Changeset: 506cc78fc932a2f5ab2cb94a2c3ded5c84467b21
Author: Mark <markmm82 <at> gmail.com>
Date: Fri Jul 27 15:24:26 2018 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.creditmanagement.dunning/rev/506cc78fc932a2f5ab2cb94a2c3ded5c84467b21 [^]

Related to issue 39013: Removed unused MockHttpServletResponse.java class

The MockHttpServletResponse.java is not used anymore so it can be removed from
the module.

---
R src/org/openbravo/creditmanagement/dunning/biz/MockHttpServletResponse.java
---
(0106086)
Sandrahuguet (developer)
2018-08-01 13:54

 Code review + testing OK

- Issue History
Date Modified Username Field Change
2018-07-23 14:48 shuehner New Issue
2018-07-23 14:48 shuehner Assigned To => Triage Finance
2018-07-26 18:05 markmm82 Assigned To Triage Finance => markmm82
2018-07-26 18:05 markmm82 Status new => scheduled
2018-07-26 22:43 markmm82 Note Added: 0105969
2018-08-01 12:56 hgbot Checkin
2018-08-01 12:56 hgbot Note Added: 0106082
2018-08-01 12:56 hgbot Status scheduled => resolved
2018-08-01 12:56 hgbot Resolution open => fixed
2018-08-01 12:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.creditmanagement.dunning/rev/d9360a9a8c9c1811b0fd1140c93e142859925c75 [^]
2018-08-01 12:56 hgbot Checkin
2018-08-01 12:56 hgbot Note Added: 0106083
2018-08-01 13:54 Sandrahuguet Review Assigned To => Sandrahuguet
2018-08-01 13:54 Sandrahuguet Note Added: 0106086
2018-08-01 13:54 Sandrahuguet Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker