Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038938
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSmajorN/A2018-07-12 10:512019-06-05 15:02
Reporterjorge-garciaView Statuspublic 
Assigned Tojorge-garcia 
PrioritynormalResolutionfixedFixed in VersionRR18Q4
StatusclosedFix in branchFixed in SCM revision3547d0875e6b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038938: Add the possibility to define the assortment of a terminal at POS Terminal Type level

DescriptionNow the assortment for a terminal could be only be defined at Organization level. Add Add the possibility to define the assortment of a terminal at POS Terminal Type level and, if not defined, use the one at Organization Level.
Steps To Reproduce-
Proposed Solution-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes design defect 0039108 closedjorge-garcia Assortment defined at POS Terminal Type level requires API change 

-  Notes
(0106307)
hgbot (developer)
2018-08-13 10:10

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3547d0875e6b85fe8a5679e785507b02648d870d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jul 12 11:12:49 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3547d0875e6b85fe8a5679e785507b02648d870d [^]

Fixed issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

This commit includes:
  * Added a new column in OBPOS_TERMINALTYPE to save the assortment id.
  * Added a new combo field in POS Terminal Type window called “Assortment”.
  * Change API in POSUtils to get the assortment. Now it’s necessary to send the
    posterminal id to get the assortment.
  * Declare two new method in POSUtils to get the terminal type and the
    organization of a terminal.
  * Change all declaration of the old API in retail pack to use the new API.
  * Change PcharacteristicHQLCriteria and ProductCharacteristicHQLCriteria to use
    the new remote search parameter posterminal id. Removed some useless
    overloaded function that cannot be used anymore.
  * Added in remote search the posterminal id as an additional parameter.

---
M src-db/database/model/tables/OBPOS_TERMINALTYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/posterminal/InitialValidations.java
M src/org/openbravo/retail/posterminal/PCharacteristicHQLCriteria.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/ProductCharacteristicHQLCriteria.java
M src/org/openbravo/retail/posterminal/master/Brand.java
M src/org/openbravo/retail/posterminal/master/Category.java
M src/org/openbravo/retail/posterminal/master/CategoryTree.java
M src/org/openbravo/retail/posterminal/master/Characteristic.java
M src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/Discount.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterProduct.java
M src/org/openbravo/retail/posterminal/master/Product.java
M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
M src/org/openbravo/retail/posterminal/process/HasServices.java
M web/org.openbravo.retail.posterminal/js/components/modalproductcharacteristic.js
---
(0106308)
hgbot (developer)
2018-08-13 10:10

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6fa66353ecde0d33e15cd44c08acf57bbcb50a45
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jul 13 10:50:54 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6fa66353ecde0d33e15cd44c08acf57bbcb50a45 [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

Fix problem getting product services after changing the API to get
the assortment.

---
M src/org/openbravo/retail/posterminal/process/HasServices.java
---
(0106309)
hgbot (developer)
2018-08-13 10:10

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b2521ca9d57aca4972eebc0205338dad5bcfa719
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Aug 03 14:59:23 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b2521ca9d57aca4972eebc0205338dad5bcfa719 [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

This commit includes:
  * Change some public methods to protected methods to improve new API.
  * Remove some useless methods to get the terminal type id and organization
    id for a POS terminal.

---
M src/org/openbravo/retail/posterminal/PCharacteristicHQLCriteria.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/ProductCharacteristicHQLCriteria.java
---
(0106310)
hgbot (developer)
2018-08-13 10:10

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f62101bbe8bf2adf84a37ea3eb83c73631e56610
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Aug 08 08:29:09 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f62101bbe8bf2adf84a37ea3eb83c73631e56610 [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

Fixed eclipse warning in Discount.java

---
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0106311)
hgbot (developer)
2018-08-13 10:10

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1ec7d15357daff70f8773e05016d499e19c4f95f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jul 12 10:56:10 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1ec7d15357daff70f8773e05016d499e19c4f95f [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

It’s necessary to pass as a parameter the posterminal id remote search of
products to get the assortment.

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0106312)
hgbot (developer)
2018-08-13 10:11

 Repository: erp/pmods/org.openbravo.retail.config
Changeset: 9ede54310aae3f367192f344aaba21e40e56c1ec
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jul 12 10:58:30 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.config/rev/9ede54310aae3f367192f344aaba21e40e56c1ec [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

As now, the assortment could be defined at POS Terminal Type level, it’s
necessary to change the ad_element to show a proper name in the backend.

---
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0106313)
hgbot (developer)
2018-08-13 10:11

 Repository: erp/pmods/org.openbravo.retail.bestsellers
Changeset: c0d6eb294db323a25a1e64ef5f3f2b1ea7d6dba3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jul 13 13:54:12 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/c0d6eb294db323a25a1e64ef5f3f2b1ea7d6dba3 [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

Change bestsellers module to use the new API to get the assortment through
params in remote search.

---
M src/org/openbravo/retail/bestsellers/PCharacteristicBestSellerHQLCriteria.java
M src/org/openbravo/retail/bestsellers/PCharacteristicValueBestSellerHQLCriteria.java
---
(0106314)
hgbot (developer)
2018-08-13 10:11

 Repository: erp/pmods/org.openbravo.retail.bestsellers
Changeset: 07b51072e553214dfbc256b618a249a94b40de5b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Aug 06 08:45:53 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/07b51072e553214dfbc256b618a249a94b40de5b [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

Change some public methods to protected methods to improve new API.

---
M src/org/openbravo/retail/bestsellers/PCharacteristicBestSellerHQLCriteria.java
M src/org/openbravo/retail/bestsellers/PCharacteristicValueBestSellerHQLCriteria.java
---
(0106315)
hgbot (developer)
2018-08-13 10:11

 Repository: erp/pmods/org.openbravo.retail.multiupc
Changeset: a3fad6e1e87aa19841915adb7e94ba7f69620b69
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jul 13 13:55:18 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.multiupc/rev/a3fad6e1e87aa19841915adb7e94ba7f69620b69 [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

Change multiupc to use the new API to get the assortment.

---
M src/org/openbravo/retail/multiupc/MultiUPC.java
---
(0106316)
hgbot (developer)
2018-08-13 10:12

 Repository: erp/pmods/org.openbravo.retail.complementary
Changeset: 70117629ab104b07425fb5ccf5ca20d57b490330
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jul 13 13:57:25 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.complementary/rev/70117629ab104b07425fb5ccf5ca20d57b490330 [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

Change complementary module to use the new APi to get the assortment.

---
M src/org/openbravo/retail/complementary/master/ComplementaryProducts.java
---
(0106317)
hgbot (developer)
2018-08-13 10:12

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 307ce86dd46502633ca562c7cbbf711f7552cd03
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jul 16 13:24:01 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/307ce86dd46502633ca562c7cbbf711f7552cd03 [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

It's necessary to send the posterminal id in the initial validation to
get the assortment.

---
M src/org/openbravo/retail/discounts/combo/master/DiscountComboValidation.java
---
(0106318)
hgbot (developer)
2018-08-13 10:13

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 19a5e428364b04e26b6f47f27e32112a96cd1333
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Mon Aug 06 12:14:22 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/19a5e428364b04e26b6f47f27e32112a96cd1333 [^]

Related to issue 38938: Add the possibility to define the assortment of a terminal at POS Terminal Type level

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APPLICATIONS.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_TERMINALTYPE.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PRODUCTCATEGORY.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PRODUCTLIST.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
---
(0106319)
hgbot (developer)
2018-08-13 10:13

 Repository: erp/pmods/org.openbravo.retail.levelpricing
Changeset: b6e838df0fa003b98b16a2d6c2897d8646165016
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jul 13 13:58:31 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.levelpricing/rev/b6e838df0fa003b98b16a2d6c2897d8646165016 [^]

Related to issue 38938: Add the possibility to define the assortment of a
terminal at POS Terminal Type level

Change levelpricing module to use the new API to get the assortment.

---
M src/org/openbravo/retail/levelpricing/master/LevelProductPrices.java
---
(0106320)
hgbot (developer)
2018-08-13 10:13

 Repository: tools/automation/pi-mobile
Changeset: 31c68eb258666833b372b0f902efdedb548b0ce6
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Tue Aug 07 11:26:02 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/31c68eb258666833b372b0f902efdedb548b0ce6 [^]

Related to issue 38938: Add the possibility to define the assortment of a terminal at POS Terminal Type level

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/terminals/WebPOSAssortmentsTerminalHelper.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/UseTerminalTypeAssortmentInstedOfOrganitationAssortment.java
---
(0106460)
hgbot (developer)
2018-08-23 10:41

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: aff88a32b8352ca3ed0fdec11bd952814f046219
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Thu Aug 23 10:41:21 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/aff88a32b8352ca3ed0fdec11bd952814f046219 [^]

Related to issue 38938: Add the possibility to define the assortment of a terminal at POS Terminal Type level

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_TERMINALTYPE.xml
---
(0112421)
hgbot (developer)
2019-06-05 15:02

 Repository: erp/pmods/org.openbravo.retail.autobom
Changeset: 2b13f45f0463f0a2984c7ed6e5c245d84826f414
Author: Roberto Carlos Toledano Gómez <rctg82 <at> gmail.com>
Date: Thu Sep 13 11:37:25 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.autobom/rev/2b13f45f0463f0a2984c7ed6e5c245d84826f414 [^]

Related to issue 38938: Change API call to POSUtils to get the assortment. Now it’s necessary to send the posterminal id to get the assortment.

---
M src/org/openbravo/retail/autobom/master/BillofMaterialsProduct.java
M src/org/openbravo/retail/autobom/master/ProductBOMVersion.java
---

- Issue History
Date Modified Username Field Change
2018-07-12 10:51 jorge-garcia New Issue
2018-07-12 10:51 jorge-garcia Assigned To => jorge-garcia
2018-07-12 10:51 jorge-garcia Triggers an Emergency Pack => No
2018-08-09 09:36 jorge-garcia Status new => scheduled
2018-08-09 09:45 jorge-garcia Relationship added causes 0039108
2018-08-13 10:10 hgbot Checkin
2018-08-13 10:10 hgbot Note Added: 0106307
2018-08-13 10:10 hgbot Status scheduled => resolved
2018-08-13 10:10 hgbot Resolution open => fixed
2018-08-13 10:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3547d0875e6b85fe8a5679e785507b02648d870d [^]
2018-08-13 10:10 hgbot Checkin
2018-08-13 10:10 hgbot Note Added: 0106308
2018-08-13 10:10 hgbot Checkin
2018-08-13 10:10 hgbot Note Added: 0106309
2018-08-13 10:10 hgbot Checkin
2018-08-13 10:10 hgbot Note Added: 0106310
2018-08-13 10:10 hgbot Checkin
2018-08-13 10:10 hgbot Note Added: 0106311
2018-08-13 10:11 hgbot Checkin
2018-08-13 10:11 hgbot Note Added: 0106312
2018-08-13 10:11 hgbot Checkin
2018-08-13 10:11 hgbot Note Added: 0106313
2018-08-13 10:11 hgbot Checkin
2018-08-13 10:11 hgbot Note Added: 0106314
2018-08-13 10:11 hgbot Checkin
2018-08-13 10:11 hgbot Note Added: 0106315
2018-08-13 10:12 hgbot Checkin
2018-08-13 10:12 hgbot Note Added: 0106316
2018-08-13 10:12 hgbot Checkin
2018-08-13 10:12 hgbot Note Added: 0106317
2018-08-13 10:13 hgbot Checkin
2018-08-13 10:13 hgbot Note Added: 0106318
2018-08-13 10:13 hgbot Checkin
2018-08-13 10:13 hgbot Note Added: 0106319
2018-08-13 10:13 hgbot Checkin
2018-08-13 10:13 hgbot Note Added: 0106320
2018-08-17 17:50 marvintm Review Assigned To => marvintm
2018-08-17 17:50 marvintm Status resolved => closed
2018-08-17 17:50 marvintm Fixed in Version => RR18Q4
2018-08-23 10:41 hgbot Checkin
2018-08-23 10:41 hgbot Note Added: 0106460
2019-06-05 15:02 hgbot Checkin
2019-06-05 15:02 hgbot Note Added: 0112421

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker