Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038903
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServermajorhave not tried2018-07-05 10:492018-08-27 15:42
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR18Q3.1
StatusclosedFix in branchFixed in SCM revision797b52363239
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038903: Symmetric DS writer adapters should be careful with using DAL to read additional information

DescriptionSymmetric DS uses its own connection to write the data to the database. In our writer filter adapters we sometimes use the DAL to read additional information. the DAL uses its own connection. So the DAL does not yet see the data Symmetric DS is inserting/updating at the same time. So the DAL can only be used on data which is surely already there from before (for example currency codes).

An example which can go wrong is here [1] as the BP might be imported into the store together with the invoice.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/CustomerCreditWriterFilterAdapter.java#l88 [^]
Steps To ReproduceUse Symmetric DS api to read data from the database.
Also check other writer filter adapters for this pattern.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0105633)
mtaal (manager)
2018-07-05 11:02

 https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/tip/src/org/openbravo/replication/symmetricds/extensions/AdProcessRunWriterFilterAdapter.java#l75 [^]
--> DAL is being used but process request is created beforehand and process run is not critical to miss

CustomerCreditWriterFilterAdapter --> see link in issue, needs to be changed

https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/file/tip/src/org/openbravo/retail/giftcards/synchronization/GiftCardCurrentAmountWriterFilterAdapter.java#l81 [^]
--> yes uses DAL, is suspect, needs to change, but needs to be done at next snapshot

No DAL usage:
BPartnerStoreWriterFilterAdapter
ClearExternalReferencesWriter
DocumentSequenceWriterFilterAdapter
FinancialAccountBalanceWriterFilterAdapter
GiftCardCurrentAmountInitializer
ImportEntryWriterFilterAdapter
InventoryWriterFilterAdapter
ModuleVersionRecomputedWriterFilterAdapter
OfflineIncomingSynchronizationPreventer
OrderDocumentNoWriterFilterAdapter
PartialExclusionWriterFilterAdapter
PreferenceWriterFilterAdapter
PreventInsertingArchivedImportEntries
PreventProductCharacteristicDuplicates
StoreServerIncomingSynchronizationPreventer
VersionCacheResetWriterFilterAdapter
(0105636)
hgbot (developer)
2018-07-05 12:50

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: dc143b8a3bee6fc48ae2f650e8ea1fa5da3b71ad
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jul 05 12:50:49 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/dc143b8a3bee6fc48ae2f650e8ea1fa5da3b71ad [^]

Related to issue 38903: Symmetric DS writer adapters should be careful with using DAL to read additional information
Use Symmetric DS connection for reading volatile information

---
M src/org/openbravo/retail/storeserver/synchronization/CustomerCreditWriterFilterAdapter.java
---
(0105638)
hgbot (developer)
2018-07-05 13:17

 Repository: erp/pmods/org.openbravo.retail.giftcards.synchronization
Changeset: 9e4127cb94d374e6d961009c44248023ac29c889
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jul 05 13:17:24 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/9e4127cb94d374e6d961009c44248023ac29c889 [^]

Fixes issue 38903: Symmetric DS writer adapters should be careful with using DAL to read additional information
Handle the case that the gift card instance is not yet there

---
M src/org/openbravo/retail/giftcards/synchronization/GiftCardCurrentAmountWriterFilterAdapter.java
---
(0105673)
hgbot (developer)
2018-07-09 12:02

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 0189bad374c39fa5e1b274d9732bfd5f71d0b853
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Jul 09 12:02:32 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/0189bad374c39fa5e1b274d9732bfd5f71d0b853 [^]

Related to issue 38903: Symmetric DS writer adapters should be careful with using DAL to read additional information
Solve build error because of warning

---
M src/org/openbravo/retail/storeserver/synchronization/CustomerCreditWriterFilterAdapter.java
---
(0106267)
hudsonbot (developer)
2018-08-09 17:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/eed070ea968c [^]
Maturity status: Test
(0106397)
AugustoMauch (manager)
2018-08-20 08:49

 Code reviewed and verified
(0106499)
hudsonbot (developer)
2018-08-27 15:42

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/437af0fa8970 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-07-05 10:49 mtaal New Issue
2018-07-05 10:49 mtaal Assigned To => mtaal
2018-07-05 10:49 mtaal Triggers an Emergency Pack => No
2018-07-05 11:02 mtaal Note Added: 0105633
2018-07-05 12:50 hgbot Checkin
2018-07-05 12:50 hgbot Note Added: 0105636
2018-07-05 13:17 hgbot Checkin
2018-07-05 13:17 hgbot Note Added: 0105638
2018-07-05 13:17 hgbot Status new => resolved
2018-07-05 13:17 hgbot Resolution open => fixed
2018-07-05 13:17 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/9e4127cb94d374e6d961009c44248023ac29c889 [^]
2018-07-05 13:18 mtaal Review Assigned To => AugustoMauch
2018-07-09 12:02 hgbot Checkin
2018-07-09 12:02 hgbot Note Added: 0105673
2018-08-08 11:06 hgbot Checkin
2018-08-08 11:06 hgbot Note Added: 0106184
2018-08-08 11:06 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/9e4127cb94d374e6d961009c44248023ac29c889 [^] => http://code.openbravo.com/erp/devel/pi/rev/e17a08d06f29cbe5ddc31982041be20e366ae596 [^]
2018-08-08 11:08 AugustoMauch Note Deleted: 0106184
2018-08-09 17:22 hudsonbot Checkin
2018-08-09 17:22 hudsonbot Note Added: 0106267
2018-08-20 08:49 AugustoMauch Note Added: 0106397
2018-08-20 08:49 AugustoMauch Status resolved => closed
2018-08-20 08:49 AugustoMauch Fixed in Version => RR18Q3.1
2018-08-27 11:37 hgbot Checkin
2018-08-27 11:37 hgbot Note Added: 0106491
2018-08-27 11:40 hgbot Checkin
2018-08-27 11:40 hgbot Note Added: 0106492
2018-08-27 11:40 hgbot Status closed => resolved
2018-08-27 11:40 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e17a08d06f29cbe5ddc31982041be20e366ae596 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/797b52363239c63f00e185dc46d8e815750e7ab8 [^]
2018-08-27 11:41 AugustoMauch Note Deleted: 0106492
2018-08-27 11:41 AugustoMauch Status resolved => closed
2018-08-27 14:21 AugustoMauch Note Deleted: 0106491
2018-08-27 15:42 hudsonbot Checkin
2018-08-27 15:42 hudsonbot Note Added: 0106499

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker