Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038899
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Distribution Ordersminoralways2018-07-05 09:502018-07-09 12:51
ReporterdmiguelezView Statuspublic 
Assigned Todmiguelez 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7ade2eca48bd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Regression introduced in release
Summary

0038899: Distribution Orders are not managing Attributes correctly

DescriptionDistribution Orders are not managing Attributes correctly.

When completing a Document, the referenced one is created, but the attribute value set there is wrong.

When generating Tasks with AWO it is not taking into account the attributes of the Distribution Order Lines
Steps To ReproduceWith AWO SampleData insalled

Log in as AWO QA Admin

Go to Goods Receipt Window and create a new record with:
  - Organization: US East Coast
  - Business Partner: Be Soft Drinker
  - Warehouse: US East Coast
Move to Lines and create a new record with:
  - Product: Apple
  - Attribute Set Value: 1_Red (click on the X to remove the default attribute and then on the magnifying glass to create a new one)
  - Operative Quantity: 10
  - Storage Bin: Food001
Complete the document

Go to Goods Receipt Window and create a new record with:
  - Organization: US West Coast
  - Business Partner: Be Soft Drinker
  - Warehouse: US West Coast
Move to Lines and create a new record with:
  - Product: Apple
  - Attribute Set Value: 2_Red (click on the X to remove the default attribute and then on the magnifying glass to create a new one)
  - Operative Quantity: 10
  - Storage Bin: Food001
Complete the document

Go to Warehouse Operations Window and filter by Apple Product.
Chec that there is stock in West and East Warehouses with different attribute value.

Go to Distribution Order Receipt Window and create a new record with:
  - Organization: US East Coast
  - Warehouse Receipt: US East Coast
  - Warehouse Issue: US West Coast
Move to lines and create a new record with:
  - Product: Apple (select the record with Attribute Set Value 1_Red
  - Attribute set value: 1_Red (automatically filled)
  - Operative Quantity: 10
Book the Document. It will create a Distribution Order Issue

Move to the related Distribution Order Issue and navigate to the lines.
Check that the attribute of the line is 1_Red. This is wrong since West Warehouse does not have stock for this attribute.
Confirm the Document.

Click on Pick and Done. Move to the Task created (under the lines Tab) and check that the Attribute is different from the one in the line. Confirm the Task
Click on Issue and Done. Move to the Task created (under the lines Tab) and check that the Attribute is different from the one in the line. Confirm the Task

Move to the original Distribution Order Receipt
Click on Receive and Done. Move to the Task created (under the lines Tab) and check that the Attribute is different from the one in the line. Confirm the Task

Tasks are not taking into account the attributes of the line of the Distribution Order.
Proposed SolutionAt this moment, it is better to remove the attribute reference from the Product selector and to hide the attribute field in the lines.

From a functional point of view, AWO should take care to decide which one is the most appropriate attribute to pick based on it's logic.

To fully support the manual insertion of attributes, Distribution Orders and the ITT's related in AWO must be adapted.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0038596 closedvmromanos Show available quantity in Product selector in Distribution order Issue Window 

-  Notes
(0105619)
dmiguelez (developer)
2018-07-05 10:18

 Test Plan

With AWO SampleData insalled

Log in as AWO QA Admin

Go to Goods Receipt Window and create a new record with:
  - Organization: US East Coast
  - Business Partner: Be Soft Drinker
  - Warehouse: US East Coast
Move to Lines and create a new record with:
  - Product: Apple
  - Attribute Set Value: 1_Red (click on the X to remove the default attribute and then on the magnifying glass to create a new one)
  - Operative Quantity: 10
  - Storage Bin: Food001
Complete the document

Go to Goods Receipt Window and create a new record with:
  - Organization: US West Coast
  - Business Partner: Be Soft Drinker
  - Warehouse: US West Coast
Move to Lines and create a new record with:
  - Product: Apple
  - Attribute Set Value: 2_Red (click on the X to remove the default attribute and then on the magnifying glass to create a new one)
  - Operative Quantity: 10
  - Storage Bin: Food001
Complete the document

Go to Warehouse Operations Window and filter by Apple Product.
Chec that there is stock in West and East Warehouses with different attribute value.

Go to Distribution Order Receipt Window and create a new record with:
  - Organization: US East Coast
  - Warehouse Receipt: US East Coast
  - Warehouse Issue: US West Coast
Move to lines and create a new record with:
  - Product: Apple (Check that no attributes values are shown)
  - Attribute set value (Check this field is not shown)
  - Operative Quantity: 10
Book the Document. It will create a Distribution Order Issue

Move to the related Distribution Order Issue and navigate to the lines.
Check that the attribute field is not shown
Confirm the Document.

Click on Pick and Done. Move to the Task created (under the lines Tab) and confirm the Task
Click on Issue and Done. Move to the Task created (under the lines Tab) and confirm the Task

Move to the original Distribution Order Receipt
Click on Receive and Done. Move to the Task created (under the lines Tab) and confirm the Task
(0105647)
hgbot (developer)
2018-07-05 18:10

 Repository: erp/mods/org.openbravo.distributionorder
Changeset: ca39cfbedacac19f65e651d0a8c8307882c8fd91
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 05 10:11:22 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/ca39cfbedacac19f65e651d0a8c8307882c8fd91 [^]

Fixes Issue 38899. Remove attributes from Distribution Order Lines

* Hide Attribute Value field in DO lines
* Changed callaout to not set the attribute value based on the product
  selected
* Changed HQL Query to not group values by attribute
* Remove attribute value fields from selector

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M src/org/openbravo/distributionorder/ad_callouts/SL_DistributionOrder_Product.java
---
(0105648)
hgbot (developer)
2018-07-05 18:10

 Repository: erp/mods/org.openbravo.distributionorder
Changeset: 903c6ecfda43c0a21e064fdd18dc68dd1c885ace
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 05 17:29:39 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/903c6ecfda43c0a21e064fdd18dc68dd1c885ace [^]

Related to issue 38899: code review improvements
Avoid duplicating lines in the selector for stocked and not stocked.
Added p.searchKey column to group by to avoid problems with Oracle

---
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0105649)
hgbot (developer)
2018-07-05 18:10

 Repository: retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder
Changeset: cb0ec16173098fb0a4ba277cad71d331e5eab323
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 05 10:11:22 2018 +0200
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder/rev/cb0ec16173098fb0a4ba277cad71d331e5eab323 [^]

Fixes Issue 38899. Remove attributes from Distribution Order Lines

* Hide Attribute Value field in DO lines
* Changed callaout to not set the attribute value based on the product
  selected
* Changed HQL Query to not group values by attribute
* Remove attribute value fields from selector

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M src/org/openbravo/distributionorder/ad_callouts/SL_DistributionOrder_Product.java
---
(0105650)
hgbot (developer)
2018-07-05 18:11

 Repository: retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder
Changeset: baebbc2ae28badc9edfc5b02545de5f7c6e3198f
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 05 17:29:39 2018 +0200
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder/rev/baebbc2ae28badc9edfc5b02545de5f7c6e3198f [^]

Related to issue 38899: code review improvements
Avoid duplicating lines in the selector for stocked and not stocked.
Added p.searchKey column to group by to avoid problems with Oracle

---
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0105651)
hgbot (developer)
2018-07-05 18:11

 Repository: retail/backports/AWO/3.0RR18Q1/org.openbravo.distributionorder
Changeset: 7ade2eca48bdcbb8ef5595d4364f51909441f90a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 05 10:11:22 2018 +0200
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q1/org.openbravo.distributionorder/rev/7ade2eca48bdcbb8ef5595d4364f51909441f90a [^]

Fixes Issue 38899. Remove attributes from Distribution Order Lines

* Hide Attribute Value field in DO lines
* Changed callaout to not set the attribute value based on the product
  selected
* Changed HQL Query to not group values by attribute
* Remove attribute value fields from selector

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M src/org/openbravo/distributionorder/ad_callouts/SL_DistributionOrder_Product.java
---
(0105652)
hgbot (developer)
2018-07-05 18:11

 Repository: retail/backports/AWO/3.0RR18Q1/org.openbravo.distributionorder
Changeset: 5b2f42f6556cebedb614a590410c1fe042dd127b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 05 17:29:39 2018 +0200
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q1/org.openbravo.distributionorder/rev/5b2f42f6556cebedb614a590410c1fe042dd127b [^]

Related to issue 38899: code review improvements
Avoid duplicating lines in the selector for stocked and not stocked.
Added p.searchKey column to group by to avoid problems with Oracle

---
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0105654)
vmromanos (manager)
2018-07-05 18:56

 Code review + testing OK
(0105675)
hgbot (developer)
2018-07-09 12:51

 Repository: erp/mods/org.openbravo.distributionorder
Changeset: e506f67f6413dc780fe065109e67295cc68bf1f8
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Jul 09 12:50:39 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/e506f67f6413dc780fe065109e67295cc68bf1f8 [^]

Related to issue 38899: fixed eclipse warnings

---
M src/org/openbravo/distributionorder/ad_callouts/SL_DistributionOrder_Product.java
---

- Issue History
Date Modified Username Field Change
2018-07-05 09:50 dmiguelez New Issue
2018-07-05 09:50 dmiguelez Assigned To => Triage Finance
2018-07-05 10:18 dmiguelez Note Added: 0105619
2018-07-05 17:00 vmromanos Status new => scheduled
2018-07-05 17:00 vmromanos Assigned To Triage Finance => dmiguelez
2018-07-05 17:01 vmromanos Relationship added caused by 0038596
2018-07-05 18:10 hgbot Checkin
2018-07-05 18:10 hgbot Note Added: 0105647
2018-07-05 18:10 hgbot Status scheduled => resolved
2018-07-05 18:10 hgbot Resolution open => fixed
2018-07-05 18:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/ca39cfbedacac19f65e651d0a8c8307882c8fd91 [^]
2018-07-05 18:10 hgbot Checkin
2018-07-05 18:10 hgbot Note Added: 0105648
2018-07-05 18:10 hgbot Checkin
2018-07-05 18:10 hgbot Note Added: 0105649
2018-07-05 18:10 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/ca39cfbedacac19f65e651d0a8c8307882c8fd91 [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder/rev/cb0ec16173098fb0a4ba277cad71d331e5eab323 [^]
2018-07-05 18:11 hgbot Checkin
2018-07-05 18:11 hgbot Note Added: 0105650
2018-07-05 18:11 hgbot Checkin
2018-07-05 18:11 hgbot Note Added: 0105651
2018-07-05 18:11 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder/rev/cb0ec16173098fb0a4ba277cad71d331e5eab323 [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR18Q1/org.openbravo.distributionorder/rev/7ade2eca48bdcbb8ef5595d4364f51909441f90a [^]
2018-07-05 18:11 hgbot Checkin
2018-07-05 18:11 hgbot Note Added: 0105652
2018-07-05 18:19 vmromanos Review Assigned To => vmromanos
2018-07-05 18:56 vmromanos Note Added: 0105654
2018-07-05 18:56 vmromanos Status resolved => closed
2018-07-09 12:51 hgbot Checkin
2018-07-09 12:51 hgbot Note Added: 0105675

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker