0038794: Receipt Lines Scroll should be moved to show the selected line

diff -r 3ddf85231370 web/org.openbravo.retail.posterminal/js/components/order.js
--- a/web/org.openbravo.retail.posterminal/js/components/order.js	Fri Dec 29 03:14:24 2017 +0000
+++ b/web/org.openbravo.retail.posterminal/js/components/order.js	Thu Jun 21 12:03:03 2018 +0200
@@ -1,6 +1,6 @@
 /*
  ************************************************************************************
- * Copyright (C) 2013-2017 Openbravo S.L.U.
+ * Copyright (C) 2013-2018 Openbravo S.L.U.
  * Licensed under the Openbravo Commercial License version 1.0
  * You may obtain a copy of the License at http://www.openbravo.com/legal/obcl.html
  * or in the legal folder of this module distribution.
@@ -388,6 +388,7 @@
     kind: 'OB.UI.ScrollableTable',
     name: 'listOrderLines',
     columns: ['product', 'quantity', 'price', 'gross'],
+    scrollWhenSelected: true,
     renderLine: 'OB.UI.RenderOrderLine',
     renderEmpty: 'OB.UI.RenderOrderLineEmpty',
     //defined on redenderorderline.js
@@ -445,13 +446,7 @@
       renderEmpty: 'OB.UI.RenderTaxLineEmpty',
       //defined on redenderorderline.js
       listStyle: 'nonselectablelist',
-      columns: ['tax', 'base', 'totaltax'],
-      executeAfterRender: function () {
-        if (this.owner.$.listOrderLines.scrollToBottom) {
-          this.owner.$.listOrderLines.getScrollArea().scrollToBottom();
-        }
-        this.owner.$.listOrderLines.scrollToBottom = false;
-      }
+      columns: ['tax', 'base', 'totaltax']
     }, {
       tag: 'li',
       components: [{
@@ -547,14 +542,6 @@
     this.$.totalReceiptLine.renderQty(this.order.getQty());
     this.$.totalTaxLine.renderTax(OB.DEC.sub(this.order.getTotal(), this.order.getNet()));
     this.$.listOrderLines.setCollection(this.order.get('lines'));
-    this.$.listOrderLines.collection.on('add change:qty change:promotions', function (model, list) {
-      me.$.listOrderLines.scrollToBottom = false;
-      if (me.$.listOrderLines.collection.models.length > 0 && me.$.listOrderLines.collection.models[me.$.listOrderLines.collection.models.length - 1]._changing) {
-        me.$.listOrderLines.scrollToBottom = true;
-      } else if (list && list.models && list.length > 0 && model.id === list.models[list.length - 1].id) {
-        me.$.listOrderLines.scrollToBottom = true;
-      }
-    });
     this.$.listPaymentLines.setCollection(this.order.get('payments'));
     this.setTaxes();
     this.order.on('change:cancelLayaway change:voidLayaway', function (model) {

diff -r 1c6290b5c737 web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
--- a/web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js	Fri Dec 29 03:15:49 2017 +0000
+++ b/web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js	Thu Jun 21 11:59:26 2018 +0200
@@ -547,6 +547,23 @@
           }
           this.selected = tr;
           this.selected.addRemoveClass(selectedCssClass, true);
+
+          if (this && this.getScrollArea && this.getScrollArea() && this.getScrollArea().scrollToControl && tr && this.scrollWhenSelected) {
+            var scroller = this.getScrollArea();
+            //When an item is selected, we will move the scroll to the selected item
+            //It will just happen when the selected item is not currently visible
+            setTimeout(function () {
+              if (scroller && scroller.$ && scroller.$.strategy && scroller.$.strategy.isInView && !scroller.$.strategy.isInView(tr.hasNode())) {
+                var inAlignWithTop = true;
+                //Depending on the action (going up or going down) we will adjust the scroll to the bottom (going down)
+                //or to the top (going up)
+                if (tr.hasNode().offsetTop > scroller.hasNode().scrollTop) {
+                  inAlignWithTop = false;
+                }
+                scroller.scrollToNode(tr.hasNode(), inAlignWithTop);
+              }
+            }, 0);
+          }
         } else {
           // Multiple selection
           this.selected = tr;