Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038793
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Distribution Ordersmajoralways2018-06-20 10:432019-01-24 14:44
ReporterVictorVillarView Statuspublic 
Assigned Todmiguelez 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision4f298c5df355
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Regression introduced in release
Summary

0038793: Not possible to close a Distribution Order Receipt because role permissions

DescriptionNot possible to close a Distribution Order Receipt because role permissions
Steps To ReproduceOrganization Legal: España
Child organization: España Región Norte

Warehouse: Distribution Warehouse defined for España legal Organization
Warehouse 2: Store warehouse defined for España Región Norte.

User1 assigned to a role with only access to España Región Norte.

Log in with User1.
Create a Distribution Order Receipt with the Warehouse Receipt: Store warehouse
Warehouse Issue: Distribution Warehouse
Complete the DO Receipt.

Log in with Openbravo user.
Go to DO Issue and confirm the document.

Log in with User1.
Confirm the DO Receipt.

Try to close it. The process never ends.

In the log you get the following error message (the ids that appear here have been taken from client's log)

1ae2faae 2018-06-20 12:42:11,662 [ajp-bio-127.0.0.1-8009-exec-1] ERROR org.openbravo.base.exception.OBSecurityException - Organization E1B3C6BCD75341C7BD474AFFEB442302 of object (OBDO_DistributionOrder(E99249A076AC4A44A41990274D2B67C4) (organization: E1B3C6BCD75341C7BD474AFFEB442302, documentNo: ADS D-ISSU101043, scheduledDeliveryDate: 2018-06-20 00:00:00.0)) is not present in OrganizationList [F3B23FC042CC4F29868786E3B7537C7B, 0, 7DAB23B2A5064CBFAB016596E843E038, F582CF8DBD3742368C199A65A237B8F4, 14ACCD687FA8480F9999ED50B2BD9E65]
org.openbravo.base.exception.OBSecurityException: Organization E1B3C6BCD75341C7BD474AFFEB442302 of object (OBDO_DistributionOrder(E99249A076AC4A44A41990274D2B67C4) (organization: E1B3C6BCD75341C7BD474AFFEB442302, documentNo: ADS D-ISSU101043, scheduledDeliveryDate: 2018-06-20 00:00:00.0)) is not present in OrganizationList [F3B23FC042CC4F29868786E3B7537C7B, 0, 7DAB23B2A5064CBFAB016596E843E038, F582CF8DBD3742368C199A65A237B8F4, 14ACCD687FA8480F9999ED50B2BD9E65]
    at org.openbravo.dal.security.SecurityChecker.checkWriteAccess(SecurityChecker.java:166)
    at org.openbravo.dal.security.SecurityChecker.checkWriteAccess(SecurityChecker.java:105)
    at org.openbravo.dal.core.OBInterceptor.doEvent(OBInterceptor.java:349)
    at org.openbravo.dal.core.OBInterceptor.onFlushDirty(OBInterceptor.java:186)
    at org.hibernate.event.def.DefaultFlushEntityEventListener.invokeInterceptor(DefaultFlushEntityEventListener.java:372)
    at org.hibernate.event.def.DefaultFlushEntityEventListener.handleInterception(DefaultFlushEntityEventListener.java:349)
    at org.hibernate.event.def.DefaultFlushEntityEventListener.scheduleUpdate(DefaultFlushEntityEventListener.java:287)
    at org.hibernate.event.def.DefaultFlushEntityEventListener.onFlushEntity(DefaultFlushEntityEventListener.java:155)
    at org.hibernate.event.def.AbstractFlushingEventListener.flushEntities(AbstractFlushingEventListener.java:219)
    at org.hibernate.event.def.AbstractFlushingEventListener.flushEverythingToExecutions(AbstractFlushingEventListener.java:99)
    at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:50)
    at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1216)
    at org.openbravo.dal.service.OBDal.flush(OBDal.java:260)
    at org.openbravo.dal.core.SessionHandler.flushRemainingChanges(SessionHandler.java:680)
    at org.openbravo.dal.core.SessionHandler.commitAndClose(SessionHandler.java:592)
    at org.openbravo.dal.core.SessionHandler.commitAndClose(SessionHandler.java:574)
    at org.openbravo.dal.core.DalThreadHandler.closeDefaultPoolSession(DalThreadHandler.java:68)
    at org.openbravo.dal.core.DalThreadHandler.doFinal(DalThreadHandler.java:43)
    at org.openbravo.dal.core.DalRequestFilter$1.doFinal(DalRequestFilter.java:95)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:65)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:501)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
    at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:193)
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:607)
    at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:313)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
    at java.lang.Thread.run(Thread.java:748)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0040020 closedAtulOpenbravo HTTP code: 500 for URL when issuing a distribution order if the role does not have access to receipt's warehouse's organization 

-  Notes
(0105273)
dmiguelez (developer)
2018-06-20 11:32

 Test Plan:

With AWO SampleData installed.

Log in as AWO QA Admin.

Go to Role Window and select the record with name 'FE_Strict_West_Users'
Change User Level to 'Client+Organization' in case it has a different value
Move to Window Access Tab and create a new record with:
  - Window: Distribution Order Receipt
  - Editable Field: Yes

Log out and Log in as AWO_US_W_STRICT/openbravo
Go to Distribution Order Receipt Window and create a new record with:
  - Organization: US West Coast
  - Warehouse Receipt: US West Coast
  - Warehouse Issue: US East Coast
Move to lines and create a new record with:
  - Product: Ale Beer
  - Operative Quantity: 10
Book the Distribution Order Receipt
Close the document and check that the process has been completed successfully.
(0105276)
hgbot (developer)
2018-06-20 11:42

 Repository: erp/mods/org.openbravo.distributionorder
Changeset: e38bebec9326f147d66b6184e92a61504f38bc9e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 20 11:40:35 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/e38bebec9326f147d66b6184e92a61504f38bc9e [^]

Fixes Issue 38793. Fix problem with Organization access when
closing a DO.

When a DO is closed, the related DO is closed too. This other
document can belong to a different Organization for which the user
does not have access too. This situation should be controlled in
the code.

* Logic of closing a DO should happen inside a setAdminMode(false)
* [Refactor] Moved logic of update Confirmed quantity of lines
  to it's own method
* [Refactor] Before closing a Scrollable Results check if it
  is null to avoid a possible n.p.e.
* [Refactor] Removed empty @return annotation to avoid a warining
  in the JavaDoc
* [Refactor] Avoid to intialize msg variable as it is not needed.

---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
---
(0105277)
hgbot (developer)
2018-06-20 11:43

 Repository: retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder
Changeset: ecd99c498d15e51400d84d544515ec8fa5e32137
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 20 11:40:35 2018 +0200
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder/rev/ecd99c498d15e51400d84d544515ec8fa5e32137 [^]

Fixes Issue 38793. Fix problem with Organization access when
closing a DO.

When a DO is closed, the related DO is closed too. This other
document can belong to a different Organization for which the user
does not have access too. This situation should be controlled in
the code.

* Logic of closing a DO should happen inside a setAdminMode(false)
* [Refactor] Moved logic of update Confirmed quantity of lines
  to it's own method
* [Refactor] Before closing a Scrollable Results check if it
  is null to avoid a possible n.p.e.
* [Refactor] Removed empty @return annotation to avoid a warining
  in the JavaDoc
* [Refactor] Avoid to intialize msg variable as it is not needed.

---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
---
(0105278)
hgbot (developer)
2018-06-20 11:43

 Repository: retail/backports/AWO/3.0RR18Q1/org.openbravo.distributionorder
Changeset: 4f298c5df35500bed4451d39298bf054cbe54bd3
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 20 11:40:35 2018 +0200
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q1/org.openbravo.distributionorder/rev/4f298c5df35500bed4451d39298bf054cbe54bd3 [^]

Fixes Issue 38793. Fix problem with Organization access when
closing a DO.

When a DO is closed, the related DO is closed too. This other
document can belong to a different Organization for which the user
does not have access too. This situation should be controlled in
the code.

* Logic of closing a DO should happen inside a setAdminMode(false)
* [Refactor] Moved logic of update Confirmed quantity of lines
  to it's own method
* [Refactor] Before closing a Scrollable Results check if it
  is null to avoid a possible n.p.e.
* [Refactor] Removed empty @return annotation to avoid a warining
  in the JavaDoc
* [Refactor] Avoid to intialize msg variable as it is not needed.

---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
---
(0105279)
hgbot (developer)
2018-06-20 11:44

 Repository: erp/mods/org.openbravo.distributionorder
Changeset: 6aceda0f4d0ef90a82d9b7bd48289f55348d2b62
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 20 11:44:35 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/6aceda0f4d0ef90a82d9b7bd48289f55348d2b62 [^]

Related to Issue 38793. Updated Module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0105282)
Sandrahuguet (developer)
2018-06-20 13:59

 Code review + testing OK
(0109182)
ngarcia (developer)
2019-01-24 14:11

 In some case, the error shown in the application was

Transport error - HTTP code: 500 for URL: /retail_modules_pgsql_pi/org.openbravo.client.kernel

- Issue History
Date Modified Username Field Change
2018-06-20 10:43 VictorVillar New Issue
2018-06-20 10:43 VictorVillar Assigned To => Triage Finance
2018-06-20 11:32 dmiguelez Note Added: 0105273
2018-06-20 11:35 dmiguelez Resolution time => 1531260000
2018-06-20 11:42 hgbot Checkin
2018-06-20 11:42 hgbot Note Added: 0105276
2018-06-20 11:42 hgbot Status new => resolved
2018-06-20 11:42 hgbot Resolution open => fixed
2018-06-20 11:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/e38bebec9326f147d66b6184e92a61504f38bc9e [^]
2018-06-20 11:43 hgbot Checkin
2018-06-20 11:43 hgbot Note Added: 0105277
2018-06-20 11:43 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/e38bebec9326f147d66b6184e92a61504f38bc9e [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder/rev/ecd99c498d15e51400d84d544515ec8fa5e32137 [^]
2018-06-20 11:43 hgbot Checkin
2018-06-20 11:43 hgbot Note Added: 0105278
2018-06-20 11:43 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/AWO/3.0RR17Q4/org.openbravo.distributionorder/rev/ecd99c498d15e51400d84d544515ec8fa5e32137 [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR18Q1/org.openbravo.distributionorder/rev/4f298c5df35500bed4451d39298bf054cbe54bd3 [^]
2018-06-20 11:44 martinsdan Issue Monitored: martinsdan
2018-06-20 11:44 hgbot Checkin
2018-06-20 11:44 hgbot Note Added: 0105279
2018-06-20 12:05 Sandrahuguet Review Assigned To => Sandrahuguet
2018-06-20 12:05 Sandrahuguet Assigned To Triage Finance => dmiguelez
2018-06-20 13:59 Sandrahuguet Note Added: 0105282
2018-06-20 13:59 Sandrahuguet Status resolved => closed
2019-01-24 14:11 ngarcia Note Added: 0109182
2019-01-24 14:44 ngarcia Relationship added related to 0040020

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker