Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0038790 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2018-06-19 14:18 | 2018-06-22 14:47 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR18Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 148bdaa50dd9 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0038790: Redundant index in C_Order table | |||||||
| Description | C_Order table seems to have redundant indexes that could make it slower insert/update/delete actions. Core adds the index: <index name="C_ORDER_DATEORDERED_ID" unique="false"> <index-column name="DATEORDERED"/> <index-column name="C_ORDER_ID"/> </index> org.openbravo.retail.posterminal adds the index: <index name="EM_OBPOS_ORDERDATE" unique="false"> <index-column name="DATEORDERED"/> </index> Both indexes actually are declared over the same DATEORDERED column. Core's one is a multi-column index that adds C_ORDER_ID column. Regardless that difference, if a query filters by dateordered it will use any of the indexes. | |||||||
| Steps To Reproduce | NA | |||||||
| Proposed Solution | First of all, for me it's clear that we can safely remove the EM_OBPOS_ORDERDATE index. IMHO it's strange to index by the C_Order_ID column in C_ORDER_DATEORDERED_ID. It was introduced here: https://code.openbravo.com/erp/devel/pi/rev/b26f38d145ac [^] I would propose to review this decision and remove the C_Order_ID column from the index to make it faster. Anyway, the decision over the C_ORDER_DATEORDERED_ID index shouldn't affect the removal of EM_OBPOS_ORDERDATE index. | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0105260) vmromanos (viewer) 2018-06-19 16:09 |
About C_ORDER_DATEORDERED_ID: it has the C_Order_ID as part of the index because in Openbravo UI tabs, when we order by a column, we always append the record id to the order criteria to ensure we always get the same order. Having this multi-index improves the performance, so we must keep it as it is. |
|
(0105328) hgbot (developer) 2018-06-22 10:09 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 148bdaa50dd982c3f7378d2c192ade8163d79db0 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Jun 22 13:39:46 2018 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/148bdaa50dd982c3f7378d2c192ade8163d79db0 [^] Fixed issue 38790 : Removed index EM_OBPOS_ORDERDATE from c_order table duw to performance issues --- M src-db/database/model/modifiedTables/C_ORDER.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-06-19 14:18 | vmromanos | New Issue | |
| 2018-06-19 14:18 | vmromanos | Assigned To | => Retail |
| 2018-06-19 14:18 | vmromanos | OBNetwork customer | => No |
| 2018-06-19 14:18 | vmromanos | Triggers an Emergency Pack | => No |
| 2018-06-19 14:22 | vmromanos | Tag Attached: Performance | |
| 2018-06-19 14:22 | vmromanos | Proposed Solution updated | |
| 2018-06-19 16:09 | vmromanos | Note Added: 0105260 | |
| 2018-06-21 14:12 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2018-06-21 14:12 | ranjith_qualiantech_com | Status | new => scheduled |
| 2018-06-22 10:09 | hgbot | Checkin | |
| 2018-06-22 10:09 | hgbot | Note Added: 0105328 | |
| 2018-06-22 10:09 | hgbot | Status | scheduled => resolved |
| 2018-06-22 10:09 | hgbot | Resolution | open => fixed |
| 2018-06-22 10:09 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/148bdaa50dd982c3f7378d2c192ade8163d79db0 [^] |
| 2018-06-22 14:47 | marvintm | Review Assigned To | => marvintm |
| 2018-06-22 14:47 | marvintm | Status | resolved => closed |
| 2018-06-22 14:47 | marvintm | Fixed in Version | => RR18Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |