0038770: Ticket completion should be executed fully inside the same database transaction, and currently that's not the case

Description

The ticket completion process, which involves:
- updating the order record in the local database
- updating the cashup report information
- updating the document sequence in the local database

should be fully executed in the same database transaction. However, currently the process is broken into two different transactions, and this means that if the user closes the browser, or refreshes the page while the process is being executed, some part of it may be committed, while some other part is yet pending to be completed.

Steps To Reproduce

- Place a breakpoint in the following js line:

receipt.set('json', JSON.stringify(receipt.serializeToJSON()));

which is part of the mainReceiptCloseFunction.
- Complete a ticket in the WebPOS.
- After the flow stops in the breakpoint, refresh the WebPOS (F5)
- Notice that the data is not correct anymore.

Proposed Solution

- The second transaction(trx) should be removed.
- All code should use the initial transaction (tx).
- The OBPOS_PreSyncReceipt should receive this transaction.
- Current French certification modules should be changed to use this transaction which they will now receive in the hook.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0038676

closed

ranjith_qualiantech_com

Ticket completion should be executed fully inside the same database transaction, and currently that's not the case

Notes
(0105352) hgbot (developer) 2018-06-25 08:43	Repository: retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal Changeset: 84c554056865557ae175d071b72674ad6be257ef Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Jun 25 12:13:03 2018 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/84c554056865557ae175d071b72674ad6be257ef [^] Fixed issue 38770 : Removed Additional Transaction before syncing receipt to backoffice * Previously for PreSyncReceipt hook, Additional Transaction has been added before syncing receipt to backoffice. Now Additional Transaction is removed and transaction is passed as param in PreSyncReceipt hook --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js ---

Issue History
Date Modified	Username	Field	Change
2018-06-15 14:44	marvintm	Type	defect => backport
2018-06-15 14:44	marvintm	Target Version	=> RR18Q2.1
2018-06-25 08:43	hgbot	Checkin
2018-06-25 08:43	hgbot	Note Added: 0105352
2018-06-25 08:43	hgbot	Status	scheduled => resolved
2018-06-25 08:43	hgbot	Resolution	open => fixed
2018-06-25 08:43	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/47ec4987197c0f3172353016e42ddc7406e260f4 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/84c554056865557ae175d071b72674ad6be257ef [^]
2018-06-25 09:01	marvintm	Review Assigned To	=> marvintm
2018-06-25 09:01	marvintm	Status	resolved => closed
2018-06-25 09:01	marvintm	Fixed in Version	=> RR18Q3
2018-06-25 09:01	marvintm	Fixed in Version	RR18Q3 => RR18Q2.1