Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038770Retail ModulesWeb POSpublic2018-05-31 19:092018-06-25 09:01
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q2.1Fixed in VersionRR18Q2.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038770: Ticket completion should be executed fully inside the same database transaction, and currently that's not the case
DescriptionThe ticket completion process, which involves:
- updating the order record in the local database
- updating the cashup report information
- updating the document sequence in the local database

should be fully executed in the same database transaction. However, currently the process is broken into two different transactions, and this means that if the user closes the browser, or refreshes the page while the process is being executed, some part of it may be committed, while some other part is yet pending to be completed.
Steps To Reproduce- Place a breakpoint in the following js line:

receipt.set('json', JSON.stringify(receipt.serializeToJSON()));

which is part of the mainReceiptCloseFunction.
- Complete a ticket in the WebPOS.
- After the flow stops in the breakpoint, refresh the WebPOS (F5)
- Notice that the data is not correct anymore.
Proposed Solution- The second transaction(trx) should be removed.
- All code should use the initial transaction (tx).
- The OBPOS_PreSyncReceipt should receive this transaction.
- Current French certification modules should be changed to use this transaction which they will now receive in the hook.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0038676 closed ranjith_qualiantech_com Ticket completion should be executed fully inside the same database transaction, and currently that's not the case 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-15 14:44marvintmTypedefect => backport
2018-06-15 14:44marvintmTarget Version => RR18Q2.1
2018-06-25 08:43hgbotCheckin
2018-06-25 08:43hgbotNote Added: 0105352
2018-06-25 08:43hgbotStatusscheduled => resolved
2018-06-25 08:43hgbotResolutionopen => fixed
2018-06-25 08:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/47ec4987197c0f3172353016e42ddc7406e260f4 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/84c554056865557ae175d071b72674ad6be257ef [^]
2018-06-25 09:01marvintmReview Assigned To => marvintm
2018-06-25 09:01marvintmStatusresolved => closed
2018-06-25 09:01marvintmFixed in Version => RR18Q3
2018-06-25 09:01marvintmFixed in VersionRR18Q3 => RR18Q2.1

Notes
(0105352)
hgbot   
2018-06-25 08:43   
Repository: retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal
Changeset: 84c554056865557ae175d071b72674ad6be257ef
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 25 12:13:03 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/84c554056865557ae175d071b72674ad6be257ef [^]

Fixed issue 38770 : Removed Additional Transaction before syncing receipt to backoffice

* Previously for PreSyncReceipt hook, Additional Transaction has been added before syncing receipt to backoffice.
  Now Additional Transaction is removed and transaction is passed as param in PreSyncReceipt hook

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---