Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0038678

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2018-06-01 11:01

2018-06-22 13:55

Reporter

gorkaion

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

urgent

Resolution

fixed

Fixed in Version

RR18Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

OBPS

Support ticket

2276

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0038678: Wrong Tax Calculation with group taxes where base is Line Net Amount + Tax Amount

Description

In an environment using a Price List that DO NOT include taxes.

Having a Tax Category with 2 rates where the second's tax base amount includes the tax amount of the 1st one. For example the Mexican IEPS + IVA that is configured in livebuilds in the published MPs machines. In this tax the IVA taxable amount is the net amount plus the IEPS tax amount.

When adding 2 lines to a ticket using products with that TAX the calculated Taxable amount for the IVA is wrong. Note that when there is only one line the amounts are correct.

Once the ticket is closed and synchronized the tax amounts by line are correct. But total receipt taxes are not correct.

Steps To Reproduce

On livebuilds for PR18Q1.3

Go to Product window and add a price using price list version "The White Valley Group Sale Price list (Opening Store)" to products:
PD4 Product Dependant 4 (for example 200)
PD5 Product Dependant 5 (for example 175)

Go to Assortment window and add those products to "Posets Products List (Opening Store)"

Open a POS using pos terminal "PS-1" (Possets)

Add PD4 product and check that taxes are correct.
-- IVA Taxable is 306 = 200+106
Add PD5 product and check that taxes are not correct.
-- IVA Taxable is 481 != 375 + 198.75

Pay and close the ticket. Open it in the backend.
- Check that Tax at header are wrong.
- Check taht Taxes at lines (Line Tax tab) are correct.
- Total Gross Amount of the Order is also wrong as it is based on the Header based Taxes.

Tags

No tags attached.

issue38678.diff [^] (855 bytes) 2018-06-05 19:47 [Show Content] [Hide Content]

diff -r f8f3c37bb9d0 web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js	Wed May 30 13:41:07 2018 +0200
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js	Tue Jun 05 19:47:43 2018 +0200
@@ -834,7 +834,7 @@
               taxesline[taxId].net = net;
               taxesline[taxId].amount = amount;
               if (taxes[taxId]) {
-                taxes[taxId].net = OB.DEC.add(taxes[taxId].net, OB.DEC.mul(discountedprice, line.get('qty')));
+                taxes[taxId].net = OB.DEC.add(taxes[taxId].net, net);
                 if (discountedNet !== linenet) {
                   roundingLoses = discountedprice.subtract(discountedprice).multiply(new BigDecimal('2'));
                   if (roundingLoses.compareTo(BigDecimal.prototype.ZERO) !== 0) {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0104971) hgbot (developer) 2018-06-06 12:30	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ea83ef4fde6d33884d23aa61b1b59154dc047fd7 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Jun 06 16:00:20 2018 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea83ef4fde6d33884d23aa61b1b59154dc047fd7 [^] Fixed issue 38678 : Modified Tax Calculation in Product excluding Price * Total tax should be calculated based on each lines net amount --- M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js ---

(0104972) hgbot (developer) 2018-06-06 12:30	Repository: tools/automation/pi-mobile Changeset: bc0c4336d22634475a9d28dd89cc820142f834b8 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Jun 06 16:00:31 2018 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bc0c4336d22634475a9d28dd89cc820142f834b8 [^] Verifies issue 38678 : Added automated test 'I38678_VerifyReceiptTax' --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I38678_VerifyReceiptTax.java ---

Issue History
Date Modified	Username	Field	Change
2018-06-01 11:01	gorkaion	New Issue
2018-06-01 11:01	gorkaion	Assigned To	=> Retail
2018-06-01 11:01	gorkaion	OBNetwork customer	=> Yes
2018-06-01 11:01	gorkaion	Support ticket	=> 2276
2018-06-01 11:01	gorkaion	Resolution time	=> 1529618400
2018-06-01 11:01	gorkaion	Triggers an Emergency Pack	=> No
2018-06-01 12:43	jfrances	Issue Monitored: jfrances
2018-06-01 13:02	gsuarez	Issue Monitored: gsuarez
2018-06-01 13:12	juabaez	Issue Monitored: juabaez
2018-06-05 19:47	marvintm	File Added: issue38678.diff
2018-06-06 08:01	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2018-06-06 08:20	ranjith_qualiantech_com	Status	new => scheduled
2018-06-06 12:30	hgbot	Checkin
2018-06-06 12:30	hgbot	Note Added: 0104971
2018-06-06 12:30	hgbot	Status	scheduled => resolved
2018-06-06 12:30	hgbot	Resolution	open => fixed
2018-06-06 12:30	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea83ef4fde6d33884d23aa61b1b59154dc047fd7 [^]
2018-06-06 12:30	hgbot	Checkin
2018-06-06 12:30	hgbot	Note Added: 0104972
2018-06-22 13:55	guilleaer	Review Assigned To	=> guilleaer
2018-06-22 13:55	guilleaer	Status	resolved => closed
2018-06-22 13:55	guilleaer	Fixed in Version	=> RR18Q3

Copyright © 2000 - 2009 MantisBT Group