Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0038405 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Cash up | major | always | 2018-04-18 16:34 | 2018-08-09 17:20 | |||
Reporter | montesm | View Status | public | |||||
Assigned To | rqueralta | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 6e094450ff5f | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | migueldejuana | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0038405: Error in the WebPos cash up report when a Gift Card is refunded | |||||||
Description | Error in the WebPos cash up report when a Gift Card is refunded Otherwise, the same cash-up report released in Backend is correct. | |||||||
Steps To Reproduce | -login cashier terminal -menu option: Create Gift Certificate -create one with € 55 -create one with € 33 -menu option: Cash Management -button: REIMBURSE -select Gift Card (33 €) -button Apply + Done -menu option Cash up -REALIZE the differences of the reports generated in webpos and in Backend | |||||||
Tags | No tags attached. | |||||||
Attached Files | CASHUPERROR3941.pdf [^] (169,955 bytes) 2018-04-18 16:34 | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0104855) hgbot (developer) 2018-05-31 21:58 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: 6e094450ff5f049cf15fe6553d1137b60cd97cf5 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Thu May 31 15:56:48 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/6e094450ff5f049cf15fe6553d1137b60cd97cf5 [^] Fixed issue 38405: 38405: Error in the WebPos cash up report when a Gift Card is refunded --- M web/org.openbravo.retail.giftcards/js/hooks/preSaveCashManagementsHook.js --- |
(0104886) hgbot (developer) 2018-06-01 18:04 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: 391fd9a11ea27736f3371cf6660d2866856f83f6 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Fri Jun 01 12:04:12 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/391fd9a11ea27736f3371cf6660d2866856f83f6 [^] Related to issue 38405: 38405: Error in the WebPos cash up report when a Gift Card is refunded - Backed out changeset: df5dd9e9dee5 --- M web/org.openbravo.retail.giftcards/js/hooks/preSaveCashManagementsHook.js --- |
(0104887) hgbot (developer) 2018-06-01 18:05 |
Repository: tools/automation/pi-mobile Changeset: f940b8ae0027fed1988c984ed1053ad0c5322eb8 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Fri Jun 01 11:56:25 2018 -0400 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f940b8ae0027fed1988c984ed1053ad0c5322eb8 [^] Related to issue 38405: Modified CreditNoteReimburse.java automated test --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/CreditNoteReimburse.java --- |
(0104918) marvintm (manager) 2018-06-04 14:34 |
There are three main problems with the current fix: - The change is not properly done. Instead of removing the line, we need to add an "if" which controls if the payment method is counted in the cashup. The full current logic should be executed if it is, none of this should be executed: var deps = payMthd.get('totalDeposits') + OB.DEC.div(dropsdeps.at(index).get('origAmount'), payMthd.get('rate')); payMthd.set('totalDeposits', deps); OB.UI.GiftCardUtils.updatePaymentMethodCashUp(payMthd, dropsdeps.at(index).get('giftcard').searchKey, "GiftCardCertificate.reimbursed", function() { processDropsDeposits(dropsdeps, index + 1); }); (but the callback to processDropsDeposits should be always executed) - The duplicated logic in the errorCallback should also be modified. - Currently, when creating the Gift Certificate we are also counting the amount as a withdrawal, and this is also not always correct. It should only be done in case the payment method is marked as counted in the cashup. |
(0104929) hgbot (developer) 2018-06-05 05:26 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: d5dcc5eb23cda73a07465de62489c77618217176 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Jun 04 22:46:21 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/d5dcc5eb23cda73a07465de62489c77618217176 [^] Related to issue 38405: Error in the WebPos cash up report when a Gift Card is refunded --- M web/org.openbravo.retail.giftcards/js/components/GiftCardCertificate.js M web/org.openbravo.retail.giftcards/js/hooks/preSaveCashManagementsHook.js --- |
(0104966) hgbot (developer) 2018-06-05 19:29 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: c0047df2f998147776054bfbb256d15b5b327535 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Tue Jun 05 13:28:21 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c0047df2f998147776054bfbb256d15b5b327535 [^] Related to issue 38405: Error in the WebPos cash up report when a Gift Card is refunded --- M web/org.openbravo.retail.giftcards/js/components/GiftCardCertificate.js --- |
(0104985) hgbot (developer) 2018-06-06 18:17 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: 31a35ae546b7a9d99864051a3d3d5f1a89cd79b0 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Wed Jun 06 12:15:43 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/31a35ae546b7a9d99864051a3d3d5f1a89cd79b0 [^] Related to issue 38405. Fix beautifier --- M web/org.openbravo.retail.giftcards/js/hooks/preSaveCashManagementsHook.js --- |
(0105072) hgbot (developer) 2018-06-11 19:20 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: fe6593e50fe301aab1e098da7be962f41c268171 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Jun 11 11:03:52 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/fe6593e50fe301aab1e098da7be962f41c268171 [^] Related to issue 38405: Error in the WebPos cash up report when a Gift Card is refunded - Avoid count Gift Certificate payment method in withdrawal if this payment method is not cunted in cashup. --- M web/org.openbravo.retail.giftcards/js/components/GiftCardCertificate.js --- |
(0105074) hgbot (developer) 2018-06-11 22:54 |
Repository: tools/automation/pi-mobile Changeset: 6aba6b758b3a552ce094d69c9ca5b6b97d107367 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Jun 11 16:53:27 2018 -0400 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6aba6b758b3a552ce094d69c9ca5b6b97d107367 [^] Related to issue 38405: Error in the WebPos cash up report when a Gift Card is refunded - Modified test PayWithGiftCardOneTimeUse --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/PayWithGiftCardOneTimeUse.java --- |
(0105089) migueldejuana (developer) 2018-06-12 12:11 |
Tested and reviewed |
(0106266) alekosmp86 (reporter) 2018-08-09 17:20 |
Added automated test https://code.openbravo.com/tools/automation/pi-mobile/rev/567cd0439d42 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2018-04-18 16:34 | montesm | New Issue | |
2018-04-18 16:34 | montesm | Assigned To | => Retail |
2018-04-18 16:34 | montesm | File Added: CASHUPERROR3941.pdf | |
2018-04-18 16:34 | montesm | Resolution time | => 1525125600 |
2018-04-18 16:34 | montesm | Triggers an Emergency Pack | => No |
2018-04-18 17:04 | jorge-garcia | Resolution time | 1525125600 => 1525212000 |
2018-04-27 13:41 | marvintm | Resolution time | 1525212000 => 1527717600 |
2018-05-08 22:40 | rqueralta | Assigned To | Retail => rqueralta |
2018-05-30 15:44 | rqueralta | Status | new => scheduled |
2018-05-31 21:58 | hgbot | Checkin | |
2018-05-31 21:58 | hgbot | Note Added: 0104855 | |
2018-05-31 21:58 | hgbot | Status | scheduled => resolved |
2018-05-31 21:58 | hgbot | Resolution | open => fixed |
2018-05-31 21:58 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/6e094450ff5f049cf15fe6553d1137b60cd97cf5 [^] |
2018-06-01 14:14 | migueldejuana | Status | resolved => new |
2018-06-01 14:14 | migueldejuana | Resolution | fixed => open |
2018-06-01 18:04 | hgbot | Checkin | |
2018-06-01 18:04 | hgbot | Note Added: 0104886 | |
2018-06-01 18:05 | hgbot | Checkin | |
2018-06-01 18:05 | hgbot | Note Added: 0104887 | |
2018-06-01 23:14 | rqueralta | Status | new => scheduled |
2018-06-01 23:14 | rqueralta | Status | scheduled => resolved |
2018-06-01 23:14 | rqueralta | Resolution | open => fixed |
2018-06-04 14:34 | marvintm | Note Added: 0104918 | |
2018-06-04 14:34 | marvintm | Status | resolved => new |
2018-06-04 14:34 | marvintm | Resolution | fixed => open |
2018-06-05 05:26 | hgbot | Checkin | |
2018-06-05 05:27 | hgbot | Note Added: 0104929 | |
2018-06-05 19:29 | hgbot | Checkin | |
2018-06-05 19:29 | hgbot | Note Added: 0104966 | |
2018-06-06 18:17 | hgbot | Checkin | |
2018-06-06 18:17 | hgbot | Note Added: 0104985 | |
2018-06-11 19:20 | hgbot | Checkin | |
2018-06-11 19:20 | hgbot | Note Added: 0105072 | |
2018-06-11 22:54 | hgbot | Checkin | |
2018-06-11 22:54 | hgbot | Note Added: 0105074 | |
2018-06-11 22:56 | rqueralta | Status | new => scheduled |
2018-06-11 22:57 | rqueralta | Status | scheduled => resolved |
2018-06-11 22:57 | rqueralta | Resolution | open => fixed |
2018-06-12 12:11 | migueldejuana | Review Assigned To | => migueldejuana |
2018-06-12 12:11 | migueldejuana | Note Added: 0105089 | |
2018-06-12 12:11 | migueldejuana | Status | resolved => closed |
2018-08-09 17:20 | alekosmp86 | Note Added: 0106266 |
Copyright © 2000 - 2009 MantisBT Group |