0038398: Abandoned connection in SetupSymmetricListener

Description

When starting tomcat I see the stack trace below in the console (is only shown when checking for abandoned connections).

[1]
WARNING: Connection has been marked suspect, possibly abandoned PooledConnection[org.postgresql.jdbc.PgConnection@5e03794e][66157 ms.]:java.lang.Exception
    at org.apache.tomcat.jdbc.pool.ConnectionPool.getThreadDump(ConnectionPool.java:1096)
    at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:799)
    at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:648)
    at org.apache.tomcat.jdbc.pool.ConnectionPool.getConnection(ConnectionPool.java:200)
    at org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnection(DataSourceProxy.java:128)
    at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnectionFromDS(JdbcExternalConnectionPool.java:130)
    at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnection(JdbcExternalConnectionPool.java:110)
    at org.openbravo.dal.core.SessionHandler.getNewConnection(SessionHandler.java:300)
    at org.openbravo.dal.core.SessionHandler.createSession(SessionHandler.java:235)
    at org.openbravo.dal.core.SessionHandler.begin(SessionHandler.java:561)
    at org.openbravo.dal.core.SessionHandler.getSession(SessionHandler.java:183)
    at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:534)
    at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:500)
    at org.openbravo.dal.service.OBDal.get(OBDal.java:353)
    at org.openbravo.mobile.core.servercontroller.MobileServerController.getThisServerDefinition(MobileServerController.java:402)
    at org.openbravo.mobile.core.servercontroller.MobileServerController.setMobileServerState(MobileServerController.java:388)
    at org.openbravo.replication.symmetricds.SetupSymmetricListener.startTransitionToOnline(SetupSymmetricListener.java:166)
    at org.openbravo.replication.symmetricds.SetupSymmetricListener.access$2(SetupSymmetricListener.java:165)
    at org.openbravo.replication.symmetricds.SetupSymmetricListener$CheckReloadStatus.run(SetupSymmetricListener.java:498)
    at java.lang.Thread.run(Thread.java:745)

Steps To Reproduce

Set abandoned connection property, use multi-server, start both central and store, it is shown in the store server console

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

has duplicate	defect	0039724		closed	mtaal	Starting tomcat in a store server leaves an open connection
has duplicate	defect	0038022		closed	AugustoMauch	Possible Connection leak in SetupSymmetricListener

Notes
(0103950) hgbot (developer) 2018-04-18 07:54	Repository: erp/pmods/org.openbravo.replication.symmetricds Changeset: ae5c19dfafb9252cde1053238dc3a4c6e7f3624b Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Apr 18 07:54:15 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/ae5c19dfafb9252cde1053238dc3a4c6e7f3624b [^] Fixes issue 38398: Abandoned connection in SetupSymmetricListener Close the connection in finally block --- M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java ---

(0104022) AugustoMauch (manager) 2018-04-23 09:30	Code reviewed and verified

Issue History
Date Modified	Username	Field	Change
2018-04-18 07:34	mtaal	New Issue
2018-04-18 07:34	mtaal	Assigned To	=> mtaal
2018-04-18 07:34	mtaal	Triggers an Emergency Pack	=> No
2018-04-18 07:49	mtaal	Review Assigned To	=> AugustoMauch
2018-04-18 07:54	hgbot	Checkin
2018-04-18 07:54	hgbot	Note Added: 0103950
2018-04-18 07:54	hgbot	Status	new => resolved
2018-04-18 07:54	hgbot	Resolution	open => fixed
2018-04-18 07:54	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/ae5c19dfafb9252cde1053238dc3a4c6e7f3624b [^]
2018-04-23 09:30	AugustoMauch	Note Added: 0104022
2018-04-23 09:30	AugustoMauch	Status	resolved => closed
2018-04-23 09:30	AugustoMauch	Fixed in Version	=> RR18Q3
2018-12-01 18:49	mtaal	Relationship added	has duplicate 0039724
2018-12-02 21:41	mtaal	Relationship added	has duplicate 0038022