Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038389
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2018-04-17 12:482018-05-17 17:44
ReporteralostaleView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRR18Q3
StatusclosedFix in branchFixed in SCM revision829412672299
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038389: DB connection unnecessarily retained while reading request contents

DescriptionA database connection is unnecessarily retained while reading POS JSON request contents. In situations of slow network or big requests, this can cause an overhead on the number of open DB connections.
Steps To Reproduce1. Enable pool jmx monitoring: in Openbravo.properties set db.pool.jmxEnabled=true and monitor active pool connections
2. Log in WebPOS
3. Simulate slow network by setting browser's network throttilng
4. Generate big log client to be sent, ie. execute:
  for (var i =0;i<500;i++) {
    var s = i + '-'
    for (var j=0; j<4096; j++) s += 'c'
    OB.warn(s)
  }
5. Wait till log client is sent to backend:
  -> Check during the time the request is being read, an active connection is always kept
Proposed SolutionAs DB connection is not needed while reading request contents, it could be released while reading to be obtained afterwards if required.
TagsPerformance
Attached Files? file icon 38389.export [^] (1,142 bytes) 2018-04-17 12:52

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0038390 closedmarvintm request timeout is checked only after reading the whole request content 

-  Notes
(0103933)
alostale (viewer)
2018-04-17 12:52

 Attached proposed solution to be tested
(0104280)
hgbot (developer)
2018-05-04 13:10

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8294126722991ded08a597a49c4382e986b188ce
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Apr 17 12:49:56 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8294126722991ded08a597a49c4382e986b188ce [^]

fixes 38389: DB connection unnecessarily retained while reading request content

  DB connection can be released while reading request content as it is not necessary
  and reading it is potentially slow.

---
M src/org/openbravo/mobile/core/process/WebServiceAuthenticatedServlet.java
---

- Issue History
Date Modified Username Field Change
2018-04-17 12:48 alostale New Issue
2018-04-17 12:48 alostale Assigned To => Retail
2018-04-17 12:48 alostale OBNetwork customer => No
2018-04-17 12:48 alostale Triggers an Emergency Pack => No
2018-04-17 12:48 alostale Tag Attached: Performance
2018-04-17 12:52 alostale File Added: 38389.export
2018-04-17 12:52 alostale Note Added: 0103933
2018-04-17 13:03 alostale Relationship added related to 0038390
2018-05-04 13:10 hgbot Checkin
2018-05-04 13:10 hgbot Note Added: 0104280
2018-05-04 13:10 hgbot Status new => resolved
2018-05-04 13:10 hgbot Resolution open => fixed
2018-05-04 13:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8294126722991ded08a597a49c4382e986b188ce [^]
2018-05-04 15:25 marvintm Assigned To Retail => marvintm
2018-05-17 17:44 guilleaer Review Assigned To => guilleaer
2018-05-17 17:44 guilleaer Status resolved => closed
2018-05-17 17:44 guilleaer Fixed in Version => RR18Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker