0038253: MobileServerController should not write offline log of TransitionToOnlineHandlers that return a success response

Description

In the BUT environment, we have seen that when a MobileServerTransitionToOnlineHandler determines that the server cannot go online, the offline log shows also the name of the other MobileServerTransitionToOnlineHandlers, for instance:

2018-03-28 13:29:26,439 [TransitionToOnlineThread] WARN org.openbravo.retail.storeserver.synchronization.SyncStatusOnlineTransitionHandler - Not going online because: SyncStatusOnlineTransitionHandler this server has 1 waiting importentries/synchronization-batches
2018-03-28 13:29:26,440 [TransitionToOnlineThread] WARN org.openbravo.mobile.core.servercontroller.MobileServerController - Transition try 0 failed caused by: >Transition to online failed because of handlers:
IntegrationsTransitionToOnlineHandler
SyncStatusOnlineTransitionHandler this server has 1 waiting importentries/synchronization-batches

Only SyncStatusOnlineTransitionHandler failed, but the class name of IntegrationsTransitionToOnlineHandler is also shown because that's the default behaviour of implementation of the getOfflineLog method

Steps To Reproduce

See description, and check here [1] that the log of all SyncStatusOnlineTransitionHandlers is appended without checking if their isReadyToGoOnline method returns false

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/6670827571b5/src/org/openbravo/mobile/core/servercontroller/MobileServerController.java#l678 [^]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

has duplicate

defect

0038476

closed

mtaal

Mobile Server Offline Log shows classname/log also of transitionhandlers which are okay for online

Notes
(0103689) hgbot (developer) 2018-04-05 12:22	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 4b902830f76082469911bcf0fe375ae2a3d76a82 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Apr 05 12:18:17 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4b902830f76082469911bcf0fe375ae2a3d76a82 [^] Fixes issue 38253: Only show offline log of handlers that failed --- M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java ---

(0103752) mtaal (manager) 2018-04-09 13:23	reviewed

Issue History
Date Modified	Username	Field	Change
2018-03-28 17:27	AugustoMauch	New Issue
2018-03-28 17:27	AugustoMauch	Assigned To	=> AugustoMauch
2018-03-28 17:27	AugustoMauch	Triggers an Emergency Pack	=> No
2018-04-05 12:21	AugustoMauch	Review Assigned To	=> mtaal
2018-04-05 12:22	hgbot	Checkin
2018-04-05 12:22	hgbot	Note Added: 0103689
2018-04-05 12:22	hgbot	Status	new => resolved
2018-04-05 12:22	hgbot	Resolution	open => fixed
2018-04-05 12:22	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4b902830f76082469911bcf0fe375ae2a3d76a82 [^]
2018-04-09 13:23	mtaal	Note Added: 0103752
2018-04-09 13:23	mtaal	Status	resolved => closed
2018-05-02 17:37	ioritzCia	Relationship added	has duplicate 0038476