Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0038139 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2018-03-14 13:35 | 2018-03-27 17:48 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Sandrahuguet | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR18Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e871e5c49205 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0038139: POSLoginHandler.getDefaults is not using bind-parameters | |||||||
| Description | This code should use bind-params: OBQuery<OBPOSApplications> appQry = OBDal.getInstance().createQuery( OBPOSApplications.class, "where searchKey = '" + terminalSearchKey + "'" + " and ((ad_isorgincluded(" + "(select organization from ADUser where id='" + userId + "')" + ", organization, client.id) <> -1) or " + "(ad_isorgincluded(organization, " + "(select organization from ADUser where id='" + userId + "')" + ", client.id) <> -1)) "); // Terminal access will be checked to ensure that the user has access to the terminal OBQuery<TerminalAccess> accessCrit = OBDal.getInstance().createQuery(TerminalAccess.class, "where userContact.id='" + userId + "'"); | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0103296) hgbot (developer) 2018-03-16 08:19 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e871e5c492054e766327db523d3b1ec3181e4ab1 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Mar 14 17:36:35 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e871e5c492054e766327db523d3b1ec3181e4ab1 [^] Fixed issue 38139 use bind-parameters in POSLoginHandler.getDefaults --- M src/org/openbravo/retail/posterminal/POSLoginHandler.java --- |
|
(0103377) Sandrahuguet (developer) 2018-03-20 17:48 |
missing second query |
|
(0103382) hgbot (developer) 2018-03-21 09:29 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 57ee333eaf8552771805a82d0d7c28b3c3a1e1bb Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Tue Mar 20 18:11:22 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/57ee333eaf8552771805a82d0d7c28b3c3a1e1bb [^] related to issue 38139 use bind-parameters in POSLoginHandler.getDefaults --- M src/org/openbravo/retail/posterminal/POSLoginHandler.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-03-14 13:35 | shuehner | New Issue | |
| 2018-03-14 13:35 | shuehner | Assigned To | => Retail |
| 2018-03-14 13:35 | shuehner | Triggers an Emergency Pack | => No |
| 2018-03-14 13:36 | shuehner | Relationship added | blocks 0038136 |
| 2018-03-14 14:33 | shuehner | Description Updated | View Revisions |
| 2018-03-14 16:34 | shuehner | Assigned To | Retail => Sandrahuguet |
| 2018-03-14 17:36 | Sandrahuguet | Status | new => scheduled |
| 2018-03-16 08:19 | hgbot | Checkin | |
| 2018-03-16 08:19 | hgbot | Note Added: 0103296 | |
| 2018-03-16 08:19 | hgbot | Status | scheduled => resolved |
| 2018-03-16 08:19 | hgbot | Resolution | open => fixed |
| 2018-03-16 08:19 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e871e5c492054e766327db523d3b1ec3181e4ab1 [^] |
| 2018-03-16 08:29 | Sandrahuguet | Review Assigned To | => marvintm |
| 2018-03-19 09:32 | marvintm | Status | resolved => closed |
| 2018-03-19 09:32 | marvintm | Fixed in Version | => RR18Q2 |
| 2018-03-20 17:48 | Sandrahuguet | Note Added: 0103377 | |
| 2018-03-20 17:48 | Sandrahuguet | Status | closed => new |
| 2018-03-20 17:48 | Sandrahuguet | Resolution | fixed => open |
| 2018-03-20 17:48 | Sandrahuguet | Fixed in Version | RR18Q2 => |
| 2018-03-21 09:29 | hgbot | Checkin | |
| 2018-03-21 09:29 | hgbot | Note Added: 0103382 | |
| 2018-03-21 09:30 | Sandrahuguet | Status | new => scheduled |
| 2018-03-21 09:30 | Sandrahuguet | Status | scheduled => resolved |
| 2018-03-21 09:30 | Sandrahuguet | Fixed in Version | => RR18Q2 |
| 2018-03-21 09:30 | Sandrahuguet | Resolution | open => fixed |
| 2018-03-27 17:48 | marvintm | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |