Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038024
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServerminorhave not tried2018-03-01 15:052018-03-09 07:25
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision6b3145f5c4bb
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038024: Fail gracefully when validating a store that has no organizations assigned

DescriptionRight now, if a store with no organizations assigned is validated, the validation fails because of malformed queries:

[SynchronizationStoreDataValidationTask] 18785 [pool-3-thread-1] ERROR org.hibernate.util.JDBCExceptionReporter - ERROR: syntax error at or near ")"
[SynchronizationStoreDataValidationTask] Position: 219
[SynchronizationStoreDataValidationTask] TableName = AD_User_Roles
[SynchronizationStoreDataValidationTask] Creating materialized view for table AD_User_Roles
[SynchronizationStoreDataValidationTask] 18808 [pool-3-thread-1] ERROR org.hibernate.util.JDBCExceptionReporter - ERROR: current transaction is aborted, commands ignored until end of transaction block

It would be better to detect the lack of organizations in advance and to return with a checked exception
Steps To ReproduceIn a multiserver environment:
- Create a store server in the Mobile Server window. Don't assign it any organizations in the Organizations by Server tab.
- Validate that store:
ant -f modules/org.openbravo.replication.symmetricds/build.xml validate.store.data -DmobileServerKey=<mobileServerKey>

Check that the log is not very clear.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0037908 closedmtaal Background Store Validator should not execute validation for mobiles servers without defined organization 

-  Notes
(0102903)
hgbot (developer)
2018-03-01 16:03

 Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 6b3145f5c4bbc0bd2492b327da6c59da29b8a394
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Mar 01 16:02:33 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/6b3145f5c4bbc0bd2492b327da6c59da29b8a394 [^]

Fixes issue 38024: Fail gracefully validating a store with no organizations

It is better to fail gracefully and show a proper error message than to fail because of a malformed query.

---
M src/org/openbravo/replication/symmetricds/validation/SynchronizationStoreDataValidator.java
---
(0103111)
mtaal (manager)
2018-03-09 07:25

 Reviewed

- Issue History
Date Modified Username Field Change
2018-03-01 15:05 AugustoMauch New Issue
2018-03-01 15:05 AugustoMauch Assigned To => AugustoMauch
2018-03-01 15:05 AugustoMauch Triggers an Emergency Pack => No
2018-03-01 16:03 hgbot Checkin
2018-03-01 16:03 hgbot Note Added: 0102903
2018-03-01 16:03 hgbot Status new => resolved
2018-03-01 16:03 hgbot Resolution open => fixed
2018-03-01 16:03 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/6b3145f5c4bbc0bd2492b327da6c59da29b8a394 [^]
2018-03-01 16:03 AugustoMauch Review Assigned To => mtaal
2018-03-09 07:25 mtaal Note Added: 0103111
2018-03-09 07:25 mtaal Status resolved => closed
2018-03-14 09:58 mtaal Relationship added has duplicate 0037908

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker