Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037898 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] 09. Financial management | minor | N/A | 2018-02-13 11:12 | 2018-06-26 11:44 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | AtulOpenbravo | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 46b18190755e | ||||
| Projection | none | ETA | none | Target Version | 3.0PR18Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | dmiguelez | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037898: Funds Transfer user experience improvements | |||||||
| Description | Funds Transfer is a feature available in Financial Account window: http://wiki.openbravo.com/wiki/Financial_Account#Funds_transfer [^] List of 3 improvements: 1. In the Funds Transfer popup add a new optional parameter "Description" which by default sets the same description as the funds transfer process currently sets to the transactions [OBMessageUtils.messageBD("FundsTransfer")]. The user can overwrite the description if needed. 2. In Organization window create a new nullable column "Default G/L Item for Funds Transfer" [C_GLITEM_ID FK to C_GLITEM]. In the Funds Transfer popup, set by default that GL Item for the Financial Account Organization. The user can overwrite that parameter if needed. If not defined a default GL Item for this organization, try to inherit from the parent org tree. If not found, then the selector won't show a default value. 3. Add a new mandatory column in Financial Account window, called "Funds Transfer Enabled". By default (existing and new records) is set to Y. The Funds Transfer button display logic is affected by this value. The Deposit To parameter will show only Financial Accounts with this new flag = Y | |||||||
| Steps To Reproduce | NA | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0102482) AtulOpenbravo (developer) 2018-02-18 19:26 |
** Login as QA Testing Role, Spain Organization. ** Navigate to Organization - Spain, set Default G/L Item for Funds Transfer as "GL Item 1". ** Navigate to Financial Account - Spain Bank, Realize that Funds Transfer Enabled Flag is checked and Funds Transfer button is shown. ** Set Funds Transfer Enabled flag = No, realize that Funds Transfer button is not shown. ** Set Funds Transfer Enabled flag = Yes, realize that Funds Transfer button is shown. ** Click on Funds Transfer button. ** Realize that G/L Item is set with default value as "GL Item 1". ** Realize that Description is set with default value as "Funds Transfer Transaction" ** Navigate to Organization - Spain, set Default G/L Item for Funds Transfer as blank value. ** Navigate to Financial Account - Spain Bank, Realize that Funds Transfer Enabled Flag is checked and Funds Transfer button is shown. ** Click on Funds Transfer button. ** Realize that G/L Item is set with default value as blank. ** Navigate to Organization - Main, set Default G/L Item for Funds Transfer as "GL Item 2". ** Navigate to Financial Account - Spain Bank, Realize that Funds Transfer Enabled Flag is checked and Funds Transfer button is shown. ** Click on Funds Transfer button. ** Realize that G/L Item is set with default value as "GL Item 2". |
|
(0102536) AtulOpenbravo (developer) 2018-02-20 19:53 |
Added test case in the test link as below:- https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10835 [^] |
|
(0102575) hgbot (developer) 2018-02-22 09:22 |
Repository: erp/devel/pi Changeset: 46b18190755e0556e90214237fb08360357aba61 Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Mon Feb 19 16:43:27 2018 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/46b18190755e0556e90214237fb08360357aba61 [^] Fixes Issue 0037898:Funds Transfer user experience improvements ** Added description field in funds transfer popup with a default value as "Funds Transfer Transaction". User can overwrite this description. ** Added Default G/L Item for Funds Transfer field in Organization. It is used to show default value in G/L Item field of Funds Transfer pop up. Gets G/L Item from Financial Account's Organization or its Parent Organization. If no default g/l item is defined for financial account's organization or its parent organization then set it as blank. ** Added a flag "Funds Transfer Enabled" in financial account. Used in display logic to show/hide Funds Transfer button process. --- M modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/FIN_FINANCIAL_ACCOUNT.xml M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml A modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/AD_ORG.xml A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferDefaultValuesExpression.java --- |
|
(0102576) hgbot (developer) 2018-02-22 09:22 |
Repository: erp/devel/pi Changeset: e2242452ecea5e60dec0d7042bee77d1605482dd Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Tue Feb 20 12:59:12 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/e2242452ecea5e60dec0d7042bee77d1605482dd [^] Related to Issue 37898. Code Review changes Added check constraint for boolean column in databasRelated to Issue 37898. Code Review changes Added check constraint for boolean column in databasee --- M modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/FIN_FINANCIAL_ACCOUNT.xml --- |
|
(0102577) hgbot (developer) 2018-02-22 09:22 |
Repository: erp/devel/pi Changeset: 77f399514112a0faba6bfea09eeabc9b236d4295 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Tue Feb 20 13:31:18 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/77f399514112a0faba6bfea09eeabc9b236d4295 [^] Related to Issue 37898. Code Review changes. Moved Parameter to the same module as the Process Definition --- M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml --- |
|
(0102578) hgbot (developer) 2018-02-22 09:22 |
Repository: erp/devel/pi Changeset: 25c6ef9f00f0a0273083a5c98573047e2afacb3c Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Tue Feb 20 13:32:03 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/25c6ef9f00f0a0273083a5c98573047e2afacb3c [^] Related to issue 37898. Code Review changes Added clause in validation to show only financial accounts with the flag Funds Transfer enabled in the Deposit To selector --- M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_VAL_RULE.xml --- |
|
(0102579) hgbot (developer) 2018-02-22 09:22 |
Repository: erp/devel/pi Changeset: 79b64a2837e16b7ec3a4913c4817892555aaa392 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Tue Feb 20 13:32:36 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/79b64a2837e16b7ec3a4913c4817892555aaa392 [^] Related to Issue 37898. Code Review changes Updated elements and synchronized terminology --- M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml --- |
|
(0102580) hgbot (developer) 2018-02-22 09:22 |
Repository: erp/devel/pi Changeset: 3a86e381b8469a23d44e5037173425d4ede92e69 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Feb 21 09:28:15 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/3a86e381b8469a23d44e5037173425d4ede92e69 [^] Related to Issue 37898. Code Review changes * Use JavaScript code instead of Java to retrieve default value for description field * Set message as used in client * Removed call to Java for Default value in Parameter * Added logic for OnLoad method in JavaScript * Changed Java to retrieve default value only for GL Item * Refactor Code * Remove unnecessary code * To retrieve default GL Item for Organization Tree use a query instead of a recursive method. The AD_Tree_Org table can be used to retrieve this value since only Ready Organizations should be taken into account. --- M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PROCESS.xml M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-fundsTransfer.js M src-db/database/sourcedata/AD_MESSAGE.xml A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferGLItemDefaultValueExpression.java R modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferDefaultValuesExpression.java --- |
|
(0102581) hgbot (developer) 2018-02-22 09:22 |
Repository: erp/devel/pi Changeset: 07ecbaf907345f3273e653228b61c2a388a0b4f3 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Feb 21 09:31:04 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/07ecbaf907345f3273e653228b61c2a388a0b4f3 [^] Related to Issue 37898. Code Review changes Added Doc to the class and final modifiers to final variables --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferGLItemDefaultValueExpression.java --- |
|
(0102582) hgbot (developer) 2018-02-22 09:22 |
Repository: erp/devel/pi Changeset: 620e7de654ce2fa76d008e9ccb18836fed761298 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Feb 21 10:10:51 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/620e7de654ce2fa76d008e9ccb18836fed761298 [^] Related to Issue 37898. Code Review changes. * Use description set by the user when creating the transaction. * Use getResponseBuilder util to build the response * Remove unnecessary methods --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/FundsTransferActionHandler.java --- |
|
(0102583) hgbot (developer) 2018-02-22 09:23 |
Repository: erp/devel/pi Changeset: 2863ed7b271cebc417d915594135e9ab09b23944 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Feb 21 10:30:37 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/2863ed7b271cebc417d915594135e9ab09b23944 [^] Related to Issue 37898. Code Review changes. Change ordering of fields in Organization Window to avoid conflicts with other modules like WebPOS --- M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_FIELD.xml --- |
|
(0102584) dmiguelez (developer) 2018-02-22 09:26 |
Code Review + Testing Ok |
|
(0102588) hgbot (developer) 2018-02-22 11:23 |
Repository: erp/pmods/org.openbravo.retail.sampledata Changeset: 2b653f55cf34ef56c478a17cfc52d6b36caab60f Author: Gorka Gil <gorka.gil <at> openbravo.com> Date: Thu Feb 22 11:17:42 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/2b653f55cf34ef56c478a17cfc52d6b36caab60f [^] Related to issue 37898: Fix retail pack sampledata dbconsistency --- M referencedata/sampledata/The_White_Valley_Group/FIN_FINANCIAL_ACCOUNT.xml --- |
|
(0102590) gorka_gil (administrator) 2018-02-22 11:29 |
Repository: erp/pmods/org.openbravo.retail.sampledata Changeset: 0fae72f9e36e Author: Gorka Gil <gorka.gil <at> openbravo.com> Date: Thu Feb 22 11:22:33 2018 +0100 URL: http://code.openbravo.com/erp/pmods-branches/org.openbravo.test.mobile.sampledata/rev/0fae72f9e36e [^] [^] Related to issue 37898: Fix retail modules sampledata-A dbconsistency --- M referencedata/sampledata/The_White_Valley_Group/FIN_FINANCIAL_ACCOUNT.xml --- |
|
(0102591) hgbot (developer) 2018-02-22 11:31 |
Repository: erp/pmods/org.openbravo.retail.testsampledata Changeset: 36871d8a0fce8959a80d18121a47c58b4ed09313 Author: Gorka Gil <gorka.gil <at> openbravo.com> Date: Thu Feb 22 11:16:27 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/36871d8a0fce8959a80d18121a47c58b4ed09313 [^] Related to issue 37898: Fix retail modules sampledata-B dbconsistency --- M referencedata/sampledata/Retail_Test/FIN_FINANCIAL_ACCOUNT.xml --- |
|
(0102793) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102794) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102795) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102796) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102797) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102798) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102799) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102800) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102801) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102802) hudsonbot (developer) 2018-02-22 18:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-02-13 11:12 | vmromanos | New Issue | |
| 2018-02-13 11:12 | vmromanos | Assigned To | => Triage Finance |
| 2018-02-13 11:12 | vmromanos | Modules | => Core |
| 2018-02-13 11:12 | vmromanos | Triggers an Emergency Pack | => No |
| 2018-02-14 10:20 | vmromanos | Status | new => scheduled |
| 2018-02-14 10:20 | vmromanos | Assigned To | Triage Finance => AtulOpenbravo |
| 2018-02-18 19:26 | AtulOpenbravo | Note Added: 0102482 | |
| 2018-02-20 19:53 | AtulOpenbravo | Note Added: 0102536 | |
| 2018-02-22 09:22 | hgbot | Checkin | |
| 2018-02-22 09:22 | hgbot | Note Added: 0102575 | |
| 2018-02-22 09:22 | hgbot | Status | scheduled => resolved |
| 2018-02-22 09:22 | hgbot | Resolution | open => fixed |
| 2018-02-22 09:22 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/46b18190755e0556e90214237fb08360357aba61 [^] |
| 2018-02-22 09:22 | hgbot | Checkin | |
| 2018-02-22 09:22 | hgbot | Note Added: 0102576 | |
| 2018-02-22 09:22 | hgbot | Checkin | |
| 2018-02-22 09:22 | hgbot | Note Added: 0102577 | |
| 2018-02-22 09:22 | hgbot | Checkin | |
| 2018-02-22 09:22 | hgbot | Note Added: 0102578 | |
| 2018-02-22 09:22 | hgbot | Checkin | |
| 2018-02-22 09:22 | hgbot | Note Added: 0102579 | |
| 2018-02-22 09:22 | hgbot | Checkin | |
| 2018-02-22 09:22 | hgbot | Note Added: 0102580 | |
| 2018-02-22 09:22 | hgbot | Checkin | |
| 2018-02-22 09:22 | hgbot | Note Added: 0102581 | |
| 2018-02-22 09:22 | hgbot | Checkin | |
| 2018-02-22 09:22 | hgbot | Note Added: 0102582 | |
| 2018-02-22 09:23 | hgbot | Checkin | |
| 2018-02-22 09:23 | hgbot | Note Added: 0102583 | |
| 2018-02-22 09:26 | dmiguelez | Review Assigned To | => dmiguelez |
| 2018-02-22 09:26 | dmiguelez | Note Added: 0102584 | |
| 2018-02-22 09:26 | dmiguelez | Status | resolved => closed |
| 2018-02-22 09:26 | dmiguelez | Fixed in Version | => 3.0PR18Q2 |
| 2018-02-22 11:23 | hgbot | Checkin | |
| 2018-02-22 11:23 | hgbot | Note Added: 0102588 | |
| 2018-02-22 11:29 | gorka_gil | Note Added: 0102590 | |
| 2018-02-22 11:31 | hgbot | Checkin | |
| 2018-02-22 11:31 | hgbot | Note Added: 0102591 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102793 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102794 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102795 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102796 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102797 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102798 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102799 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102800 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102801 | |
| 2018-02-22 18:19 | hudsonbot | Checkin | |
| 2018-02-22 18:19 | hudsonbot | Note Added: 0102802 | |
| 2018-06-26 11:31 | hgbot | Checkin | |
| 2018-06-26 11:31 | hgbot | Note Added: 0105393 | |
| 2018-06-26 11:44 | hgbot | Checkin | |
| 2018-06-26 11:44 | hgbot | Note Added: 0105441 | |
| 2018-06-26 13:44 | gorka_gil | Note Deleted: 0105393 | |
| 2018-06-26 13:44 | gorka_gil | Note Deleted: 0105441 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |