Notes |
|
|
** Login as QA Testing Role, Spain Organization.
** Navigate to Organization - Spain, set Default G/L Item for Funds Transfer as "GL Item 1".
** Navigate to Financial Account - Spain Bank, Realize that Funds Transfer Enabled Flag is checked and Funds Transfer button is shown.
** Set Funds Transfer Enabled flag = No, realize that Funds Transfer button is not shown.
** Set Funds Transfer Enabled flag = Yes, realize that Funds Transfer button is shown.
** Click on Funds Transfer button.
** Realize that G/L Item is set with default value as "GL Item 1".
** Realize that Description is set with default value as "Funds Transfer Transaction"
** Navigate to Organization - Spain, set Default G/L Item for Funds Transfer as blank value.
** Navigate to Financial Account - Spain Bank, Realize that Funds Transfer Enabled Flag is checked and Funds Transfer button is shown.
** Click on Funds Transfer button.
** Realize that G/L Item is set with default value as blank.
** Navigate to Organization - Main, set Default G/L Item for Funds Transfer as "GL Item 2".
** Navigate to Financial Account - Spain Bank, Realize that Funds Transfer Enabled Flag is checked and Funds Transfer button is shown.
** Click on Funds Transfer button.
** Realize that G/L Item is set with default value as "GL Item 2". |
|
|
|
|
|
(0102575)
|
hgbot
|
2018-02-22 09:22
|
|
Repository: erp/devel/pi
Changeset: 46b18190755e0556e90214237fb08360357aba61
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Feb 19 16:43:27 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/46b18190755e0556e90214237fb08360357aba61 [^]
Fixes Issue 0037898:Funds Transfer user experience improvements
** Added description field in funds transfer popup with a default
value as "Funds Transfer Transaction". User can overwrite this
description.
** Added Default G/L Item for Funds Transfer field in Organization.
It is used to show default value in G/L Item field of Funds Transfer
pop up. Gets G/L Item from Financial Account's Organization or its
Parent Organization. If no default g/l item is defined for financial
account's organization or its parent organization then set it as
blank.
** Added a flag "Funds Transfer Enabled" in financial account. Used
in display logic to show/hide Funds Transfer button process.
---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/FIN_FINANCIAL_ACCOUNT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
A modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/AD_ORG.xml
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferDefaultValuesExpression.java
---
|
|
|
(0102576)
|
hgbot
|
2018-02-22 09:22
|
|
Repository: erp/devel/pi
Changeset: e2242452ecea5e60dec0d7042bee77d1605482dd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Feb 20 12:59:12 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e2242452ecea5e60dec0d7042bee77d1605482dd [^]
Related to Issue 37898. Code Review changes
Added check constraint for boolean column in databasRelated to Issue 37898. Code Review changes
Added check constraint for boolean column in databasee
---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/modifiedTables/FIN_FINANCIAL_ACCOUNT.xml
---
|
|
|
(0102577)
|
hgbot
|
2018-02-22 09:22
|
|
Repository: erp/devel/pi
Changeset: 77f399514112a0faba6bfea09eeabc9b236d4295
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Feb 20 13:31:18 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/77f399514112a0faba6bfea09eeabc9b236d4295 [^]
Related to Issue 37898. Code Review changes.
Moved Parameter to the same module as the Process Definition
---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
---
|
|
|
(0102578)
|
hgbot
|
2018-02-22 09:22
|
|
Repository: erp/devel/pi
Changeset: 25c6ef9f00f0a0273083a5c98573047e2afacb3c
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Feb 20 13:32:03 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/25c6ef9f00f0a0273083a5c98573047e2afacb3c [^]
Related to issue 37898. Code Review changes
Added clause in validation to show only financial accounts
with the flag Funds Transfer enabled in the Deposit To selector
---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_VAL_RULE.xml
---
|
|
|
(0102579)
|
hgbot
|
2018-02-22 09:22
|
|
Repository: erp/devel/pi
Changeset: 79b64a2837e16b7ec3a4913c4817892555aaa392
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Feb 20 13:32:36 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/79b64a2837e16b7ec3a4913c4817892555aaa392 [^]
Related to Issue 37898. Code Review changes
Updated elements and synchronized terminology
---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
---
|
|
|
(0102580)
|
hgbot
|
2018-02-22 09:22
|
|
Repository: erp/devel/pi
Changeset: 3a86e381b8469a23d44e5037173425d4ede92e69
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Feb 21 09:28:15 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3a86e381b8469a23d44e5037173425d4ede92e69 [^]
Related to Issue 37898. Code Review changes
* Use JavaScript code instead of Java to retrieve default value for
description field
* Set message as used in client
* Removed call to Java for Default value in Parameter
* Added logic for OnLoad method in JavaScript
* Changed Java to retrieve default value only for GL Item
* Refactor Code
* Remove unnecessary code
* To retrieve default GL Item for Organization Tree use a query
instead of a recursive method. The AD_Tree_Org table can be used
to retrieve this value since only Ready Organizations should be
taken into account.
---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-fundsTransfer.js
M src-db/database/sourcedata/AD_MESSAGE.xml
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferGLItemDefaultValueExpression.java
R modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferDefaultValuesExpression.java
---
|
|
|
(0102581)
|
hgbot
|
2018-02-22 09:22
|
|
Repository: erp/devel/pi
Changeset: 07ecbaf907345f3273e653228b61c2a388a0b4f3
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Feb 21 09:31:04 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/07ecbaf907345f3273e653228b61c2a388a0b4f3 [^]
Related to Issue 37898. Code Review changes
Added Doc to the class and final modifiers to final variables
---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/FundsTransferGLItemDefaultValueExpression.java
---
|
|
|
(0102582)
|
hgbot
|
2018-02-22 09:22
|
|
Repository: erp/devel/pi
Changeset: 620e7de654ce2fa76d008e9ccb18836fed761298
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Feb 21 10:10:51 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/620e7de654ce2fa76d008e9ccb18836fed761298 [^]
Related to Issue 37898. Code Review changes.
* Use description set by the user when creating the transaction.
* Use getResponseBuilder util to build the response
* Remove unnecessary methods
---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/FundsTransferActionHandler.java
---
|
|
|
(0102583)
|
hgbot
|
2018-02-22 09:23
|
|
Repository: erp/devel/pi
Changeset: 2863ed7b271cebc417d915594135e9ab09b23944
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Feb 21 10:30:37 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2863ed7b271cebc417d915594135e9ab09b23944 [^]
Related to Issue 37898. Code Review changes.
Change ordering of fields in Organization Window to avoid conflicts
with other modules like WebPOS
---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
|
|
|
|
|
|
(0102588)
|
hgbot
|
2018-02-22 11:23
|
|
|
|
|
|
|
(0102591)
|
hgbot
|
2018-02-22 11:31
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|