0037891: Allow to save Sales with 1 or more negative lines as Returns

# HG changeset patch
# User Unai Martirena <unai.martirena@openbravo.com>
# Date 1518451590 -3600
#      Mon Feb 12 17:06:30 2018 +0100
# Node ID e38833815d6e7f99f2f694e754e6c94754aad318
# Parent  87a296244d7e85f85af780891a4ce00d86823d14
Fixed issue 37891: Allow to save Sales with 1 or more negative lines as Returns

diff --git a/web/org.openbravo.retail.posterminal/js/components/order.js b/web/org.openbravo.retail.posterminal/js/components/order.js
--- a/web/org.openbravo.retail.posterminal/js/components/order.js
+++ b/web/org.openbravo.retail.posterminal/js/components/order.js
@@ -772,7 +772,7 @@
         var negativeLinesLength = _.filter(this.order.get('lines').models, function (line) {
           return line.get('qty') < 0;
         }).length;
-        if (negativeLinesLength > 0 && negativeLinesLength === this.order.get('lines').models.length) {
+        if (negativeLinesLength > 0 && negativeLinesLength === this.order.get('lines').models.length || (negativeLinesLength > 0 && OB.MobileApp.model.get('permissions').OBPOS_SalesWithOneLineNegativeAsReturns)) {
           //isReturn
           OB.MobileApp.model.receipt.setDocumentNo(true, false);
         } else {
diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js b/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
@@ -421,7 +421,7 @@
           var negativeLines = _.filter(receipt.get('lines').models, function (line) {
             return line.get('qty') < 0;
           }).length;
-          if (negativeLines === receipt.get('lines').models.length) {
+          if (negativeLines === receipt.get('lines').models.length || (negativeLines > 0 && OB.MobileApp.model.get('permissions').OBPOS_SalesWithOneLineNegativeAsReturns)) {
             receipt.setOrderType('OBPOS_receipt.return', OB.DEC.One, {
               applyPromotions: false,
               saveOrder: false
@@ -593,7 +593,7 @@
           var negativeLines = _.filter(order.get('lines').models, function (line) {
             return line.get('qty') < 0;
           }).length;
-          if (negativeLines === order.get('lines').models.length) {
+          if (negativeLines === order.get('lines').models.length || (negativeLines > 0 && OB.MobileApp.model.get('permissions').OBPOS_SalesWithOneLineNegativeAsReturns)) {
             order.setOrderType('OBPOS_receipt.return', OB.DEC.One, {
               applyPromotions: false,
               saveOrder: false
diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js b/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
@@ -272,7 +272,9 @@
 
       var hasNegativeLines = _.filter(receipt.get('lines').models, function (line) {
         return line.get('qty') < 0;
-      }).length === receipt.get('lines').size() ? true : false;
+      }).length;
+
+      hasNegativeLines = (hasNegativeLines === receipt.get('lines').size() || (hasNegativeLines > 0 && OB.MobileApp.model.get('permissions').OBPOS_SalesWithOneLineNegativeAsReturns)) ? true : false;
 
       var linesToRemove = [];
       receipt.get('lines').forEach(function (line) {

# HG changeset patch
# User Unai Martirena <unai.martirena@openbravo.com>
# Date 1518455557 -3600
#      Mon Feb 12 18:12:37 2018 +0100
# Node ID 1c48e73d606979a511906d270fef571b0483aa1d
# Parent  7476f73c129fc05c507cd5dcff0b6851ee6ce184
Related to issue 37891: Add missing preferences properties

diff --git a/src-db/database/sourcedata/AD_PREFERENCE.xml b/src-db/database/sourcedata/AD_PREFERENCE.xml
--- a/src-db/database/sourcedata/AD_PREFERENCE.xml
+++ b/src-db/database/sourcedata/AD_PREFERENCE.xml
@@ -561,6 +561,17 @@
 <!--706018D4F0274E8499B2793A2C89F191-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
 <!--706018D4F0274E8499B2793A2C89F191--></AD_PREFERENCE>
 
+<!--77A693CEAD0841B98CACEA397AA8C326--><AD_PREFERENCE>
+<!--77A693CEAD0841B98CACEA397AA8C326-->  <AD_PREFERENCE_ID><![CDATA[77A693CEAD0841B98CACEA397AA8C326]]></AD_PREFERENCE_ID>
+<!--77A693CEAD0841B98CACEA397AA8C326-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--77A693CEAD0841B98CACEA397AA8C326-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--77A693CEAD0841B98CACEA397AA8C326-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--77A693CEAD0841B98CACEA397AA8C326-->  <VALUE><![CDATA[N]]></VALUE>
+<!--77A693CEAD0841B98CACEA397AA8C326-->  <PROPERTY><![CDATA[OBPOS_SalesWithOneLineNegativeAsReturns]]></PROPERTY>
+<!--77A693CEAD0841B98CACEA397AA8C326-->  <ISPROPERTYLIST><![CDATA[Y]]></ISPROPERTYLIST>
+<!--77A693CEAD0841B98CACEA397AA8C326-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
+<!--77A693CEAD0841B98CACEA397AA8C326--></AD_PREFERENCE>
+
 <!--79863EBEE77B48B48B507832E32D8A90--><AD_PREFERENCE>
 <!--79863EBEE77B48B48B507832E32D8A90-->  <AD_PREFERENCE_ID><![CDATA[79863EBEE77B48B48B507832E32D8A90]]></AD_PREFERENCE_ID>
 <!--79863EBEE77B48B48B507832E32D8A90-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
diff --git a/src-db/database/sourcedata/AD_REF_LIST.xml b/src-db/database/sourcedata/AD_REF_LIST.xml
--- a/src-db/database/sourcedata/AD_REF_LIST.xml
+++ b/src-db/database/sourcedata/AD_REF_LIST.xml
@@ -1055,6 +1055,18 @@
 <!--8A9DDD8D41B94395A1D68E6B3E31595E-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
 <!--8A9DDD8D41B94395A1D68E6B3E31595E--></AD_REF_LIST>
 
+<!--8B8F28BE721E47F0ADD0517E14B26882--><AD_REF_LIST>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <AD_REF_LIST_ID><![CDATA[8B8F28BE721E47F0ADD0517E14B26882]]></AD_REF_LIST_ID>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <VALUE><![CDATA[OBPOS_SalesWithOneLineNegativeAsReturns]]></VALUE>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <NAME><![CDATA[Save as return sale with 1 or more negative lines]]></NAME>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <DESCRIPTION><![CDATA[Save as return sale with 1 or more negative lines]]></DESCRIPTION>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <AD_REFERENCE_ID><![CDATA[A26BA480E2014707B47257024C3CBFF7]]></AD_REFERENCE_ID>
+<!--8B8F28BE721E47F0ADD0517E14B26882-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
+<!--8B8F28BE721E47F0ADD0517E14B26882--></AD_REF_LIST>
+
 <!--8CA80355EF064A0EAD578CB8AB07C9FC--><AD_REF_LIST>
 <!--8CA80355EF064A0EAD578CB8AB07C9FC-->  <AD_REF_LIST_ID><![CDATA[8CA80355EF064A0EAD578CB8AB07C9FC]]></AD_REF_LIST_ID>
 <!--8CA80355EF064A0EAD578CB8AB07C9FC-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>