0037786: Overly huge request size in AddPaymentDisplayLogicActionHandler

Description

Looking in net panel i see several request to that display action handler

and last one of those seem to have in its request json

context -> sales_order_invoice -> _allRows
and then array with all the values of all the rows.
+ then on top in _selected
copy of all data again for the selected rows.

and that is up to 20-30k already just for 4 lines i saw in grid.

So will get much bigger in case you have more lines in your view.

Steps To Reproduce

new sales invoice + 1 line + complete

then just add payment
and in the popup it did show me apparently 4 other invoices.
Look at the net panel

Proposed Solution

The request to that action handler is apparently only done from the OB.APRM.AddPayment.recalcDisplayLogicOrReadOnlyLogic function.

In the parameter windows, when the value of the grid is requested (i.e. when invoking the getContextInfo, which is done in the recalcDisplayLogicOrReadOnlyLogic function), the returned value contains the list of selected records plus the list of all grid records if the grid contents are completely cached. If you don't need any of those values, you could just get rid of them before including them in the request.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0030643

closed

collazoandy4

Overly huge request size in AddPaymentDisplayLogicActionHandler

Notes
(0102081) hgbot (developer) 2018-01-31 09:58	Repository: erp/backports/3.0PR17Q4.1 Changeset: f3e9a7dc364d9e15c81700199c1d35f0925a4265 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Fri Jan 19 09:25:37 2018 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/f3e9a7dc364d9e15c81700199c1d35f0925a4265 [^] Fixes Issue 37786:Overly huge request size in AddPaymentDisplayLogicActionHandle Before sending the context, the grids with the information about orders and invoices, gl items and credit used are removed from it. This data is not used for calculating the display or read only logic of the rest of the parameters and sending the grid can have an impact in the performance of this process. --- M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js ---

(0102083) dmiguelez (viewer) 2018-01-31 10:01	Code Review + Testing Ok

Issue History
Date Modified	Username	Field	Change
2018-01-31 09:42	dmiguelez	Type	defect => backport
2018-01-31 09:42	dmiguelez	Target Version	=> 3.0PR17Q4.1
2018-01-31 09:58	hgbot	Checkin
2018-01-31 09:58	hgbot	Note Added: 0102081
2018-01-31 09:58	hgbot	Status	scheduled => resolved
2018-01-31 09:58	hgbot	Resolution	open => fixed
2018-01-31 09:58	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/devel/pi/rev/436eb0fb4c04367a4ff2502421f53db6381318be [^] => http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/f3e9a7dc364d9e15c81700199c1d35f0925a4265 [^]
2018-01-31 10:01	dmiguelez	Note Added: 0102083
2018-01-31 10:01	dmiguelez	Status	resolved => closed
2018-01-31 10:01	dmiguelez	Fixed in Version	=> 3.0PR17Q4.1