Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037746
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POS Hardware Managermajoralways2018-01-26 11:542018-01-30 11:53
ReporteradrianromeroView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in VersionRR17Q4.1
StatusclosedFix in branchFixed in SCM revision1ac60dad4e0b
ProjectionnoneETAnoneTarget VersionRR17Q4.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - Confirmed Stable
Regression date2017-09-21
Regression introduced in releaseRR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/d4f8ae4bb164 [^]
Triggers an Emergency PackNo
Summary

0037746: Special characters like ' in product names is printed in the receipt as &

DescriptionIf a product name contains an special character like ' and included in an order from Web POS, when closing the receipt and printed. The receipt prints & instead of '
Steps To ReproduceIn description
Proposed Solution1.- Revert the commit in *Regression introduced by commit*.

2.-To fix properly the issue of the commit it has to be modified the template and print promotion names using function OB.UTIL.encodeXMLComponent() . This way:

          <line>
            <text align="left" length="2">--</text>
            <text align="left" length="32"><%=OB.UTIL.encodeXMLComponent(p.name)%></text>
            <text align="right" length="8"><%= OB.I18N.formatCurrency(-p.amt) %></text>
          </line>
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0037737 closedjorge-garcia Special characters like ' in product names is printed in the receipt as & 

-  Notes
(0102029)
hgbot (developer)
2018-01-29 16:28

Repository: retail/backports/3.0RR17Q4.1/org.openbravo.retail.posterminal
Changeset: 1ac60dad4e0b2c10429a32f7b97a1183e22b63e9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 15:54:40 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q4.1/org.openbravo.retail.posterminal/rev/1ac60dad4e0b2c10429a32f7b97a1183e22b63e9 [^]

Fixed issue 37746: Special characters like ' in product names is printed
in the receipt as &

Implemented xml encode in all references of promotions name in templates.

---
M web/org.openbravo.retail.posterminal/res/printcanceledreceipt.xml
M web/org.openbravo.retail.posterminal/res/printclosedinvoice.xml
M web/org.openbravo.retail.posterminal/res/printclosedreceipt.xml
M web/org.openbravo.retail.posterminal/res/printinvoice.xml
M web/org.openbravo.retail.posterminal/res/printlayaway.xml
M web/org.openbravo.retail.posterminal/res/printquotation.xml
M web/org.openbravo.retail.posterminal/res/printreceipt.xml
M web/org.openbravo.retail.posterminal/res/printreturn.xml
M web/org.openbravo.retail.posterminal/res/printreturninvoice.xml
---
(0102030)
hgbot (developer)
2018-01-29 16:28

Repository: retail/backports/3.0RR17Q4.1/org.openbravo.retail.poshwmanager.sources
Changeset: 697529e1f4c795521a58e75005a846b455810b0b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 15:55:14 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q4.1/org.openbravo.retail.poshwmanager.sources/rev/697529e1f4c795521a58e75005a846b455810b0b [^]

Related to issue 37746: Special characters like ' in product names is printed
in the receipt as &

Reverted code introduced by regression.

---
M project/src/com/openbravo/pos/printer/TicketParser.java
---
(0102031)
hgbot (developer)
2018-01-29 16:28

Repository: retail/backports/3.0RR17Q4.1/org.openbravo.retail.poshwmanager
Changeset: fcf2bc75972da5062201e00f148fa1c25c151b4e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 15:56:22 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q4.1/org.openbravo.retail.poshwmanager/rev/fcf2bc75972da5062201e00f148fa1c25c151b4e [^]

Related to issue 37746: Special characters like ' in product names is printed
in the receipt as &

Compiled new version of hardware manager.

---
M bin/poshw.jar
M bin/rev.id
---

- Issue History
Date Modified Username Field Change
2018-01-29 10:09 marvintm Type defect => backport
2018-01-29 10:09 marvintm Target Version => RR17Q4.1
2018-01-29 16:28 hgbot Checkin
2018-01-29 16:28 hgbot Note Added: 0102029
2018-01-29 16:28 hgbot Status scheduled => resolved
2018-01-29 16:28 hgbot Resolution open => fixed
2018-01-29 16:28 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR17Q4.1/org.openbravo.retail.posterminal/rev/1ac60dad4e0b2c10429a32f7b97a1183e22b63e9 [^]
2018-01-29 16:28 hgbot Checkin
2018-01-29 16:28 hgbot Note Added: 0102030
2018-01-29 16:28 hgbot Checkin
2018-01-29 16:28 hgbot Note Added: 0102031
2018-01-30 11:53 marvintm Review Assigned To adrianromero => marvintm
2018-01-30 11:53 marvintm Status resolved => closed
2018-01-30 11:53 marvintm Fixed in Version => RR17Q4.1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker