Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037611 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] StoreServer | major | always | 2018-01-10 17:39 | 2018-01-29 11:32 | |||
| Reporter | ioritzCia | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 16cf100d79d6 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | mtaal | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037611: Store data validator background process leaves open connections | |||||||
| Description | Store data validator background process leaves open connections in createMaterializedView method | |||||||
| Steps To Reproduce | Configure the Openbravo.properties to log abandoned suspects Execute the background process Check the log for the error like in the attached file | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  connectionLeakValidateBackground.log [^] (2,402 bytes) 2018-01-10 17:40 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0101713) hgbot (developer) 2018-01-16 11:37 |
Repository: erp/pmods/org.openbravo.replication.symmetricds Changeset: 16cf100d79d6b4086fd292fc0baa7d887d73dae3 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Tue Jan 16 11:29:24 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/16cf100d79d6b4086fd292fc0baa7d887d73dae3 [^] Fixes issue 37611: Store data validator process no longer leaks connections The problem was that the connection used to create the materialized views was not being rollbacked and closed. Now this is done by the RollbackMaterializedViews runnable, which is invoked on the ExecutorServer where the materialized views are created. The existing connection rollback has been removed because is no longer needed. --- M src/org/openbravo/replication/symmetricds/validation/SynchronizationStoreDataValidator.java --- |
|
(0101735) mtaal (manager) 2018-01-16 23:04 |
Codereview comments: Maybe add comment where the executorservice is created that singlethreadexecutor is important to ensure that the connection close at the end works on the same thread. The standardExecutorService is not created as singlethreadexecutor. Is that on purpose, could there be a connection leak there to? |
|
(0101854) AugustoMauch (manager) 2018-01-22 16:32 |
Right now it is not possible to leak connections, but if the number of threads to be used to execute the background validator process were increased, there would be leaks. A new issue has been reported to cover this case [1]. As the fix is not easy, and it is currently not reproducible, I prefere to handle it in that separate design defect. [1] https://issues.openbravo.com/view.php?id=37699 [^] |
|
(0102009) mtaal (manager) 2018-01-29 11:32 |
reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-01-10 17:39 | ioritzCia | New Issue | |
| 2018-01-10 17:39 | ioritzCia | Assigned To | => StoreServer |
| 2018-01-10 17:39 | ioritzCia | Triggers an Emergency Pack | => No |
| 2018-01-10 17:40 | ioritzCia | File Added: connectionLeakValidateBackground.log | |
| 2018-01-15 10:23 | mtaal | Assigned To | StoreServer => AugustoMauch |
| 2018-01-15 13:25 | ioritzCia | Resolution time | => 1517353200 |
| 2018-01-16 11:37 | hgbot | Checkin | |
| 2018-01-16 11:37 | hgbot | Note Added: 0101713 | |
| 2018-01-16 11:37 | hgbot | Status | new => resolved |
| 2018-01-16 11:37 | hgbot | Resolution | open => fixed |
| 2018-01-16 11:37 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/16cf100d79d6b4086fd292fc0baa7d887d73dae3 [^] |
| 2018-01-16 12:26 | AugustoMauch | Review Assigned To | => mtaal |
| 2018-01-16 23:04 | mtaal | Note Added: 0101735 | |
| 2018-01-22 16:25 | AugustoMauch | Relationship added | related to 0037699 |
| 2018-01-22 16:32 | AugustoMauch | Note Added: 0101854 | |
| 2018-01-29 11:32 | mtaal | Note Added: 0102009 | |
| 2018-01-29 11:32 | mtaal | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |