Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037593
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSmajoralways2018-01-08 11:512018-03-08 13:11
ReporterasiermartirenaView Statuspublic 
Assigned Toasiermartirena 
PriorityhighResolutionfixedFixed in VersionRR18Q2
StatusclosedFix in branchFixed in SCM revision6aab63d06348
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037593: Services checks are affecting the Web POS even if there are no services in a ticket

DescriptionAny change in a ticket is launching some checks for services (quantity rules, services removal, services returns, etc.) that are occurring even if there are no services added to a ticket. This checks are affecting in performance to the Web POS, especially in big tickets, because each line, it's quantities, it's related lines and it's related lines quantities must be reviewed for every check.

It would be a good practice to know when a ticket contains a service, and only in that situation execute the checks (that are mandatory to maintain the services consistency).
Steps To ReproduceOpen the Web POS.

Add an avalanche transceiver.

The services checks are executed (WRONG).
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0101742)
hgbot (developer)
2018-01-17 09:57

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6aab63d063481081ca91ff225dec332e9f446a3c
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Tue Jan 09 10:55:13 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6aab63d063481081ca91ff225dec332e9f446a3c [^]

Fixed issue 37593: Avoid unnecessary services checks.

A new property 'hasServices' has been created in the order, which tells if an order contains any service that is related to a product. Each time a quantity rule or any check that affects to services should be executed, this property is checked and the check is done only for those tickets that contain a service.

This property is set when creating services lines, and is removed when deleting the services lines from the ticket.

Additionally, the duplicated code executed to check if services can be returned has been improved to be better in performance and more readable and also has been moved to the order.js, creating a function to avoid the duplicated code and having the business logic in the correct file.

---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0102158)
dmitry_mezentsev (developer)
2018-02-02 17:20

 Ping.
Not closed for 16 days!

- Issue History
Date Modified Username Field Change
2018-01-08 11:51 asiermartirena New Issue
2018-01-08 11:51 asiermartirena Assigned To => asiermartirena
2018-01-08 11:51 asiermartirena Triggers an Emergency Pack => No
2018-01-17 09:57 hgbot Checkin
2018-01-17 09:57 hgbot Note Added: 0101742
2018-01-17 09:57 hgbot Status new => resolved
2018-01-17 09:57 hgbot Resolution open => fixed
2018-01-17 09:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6aab63d063481081ca91ff225dec332e9f446a3c [^]
2018-02-02 17:20 dmitry_mezentsev Note Added: 0102158
2018-03-08 13:11 marvintm Review Assigned To => marvintm
2018-03-08 13:11 marvintm Status resolved => closed
2018-03-08 13:11 marvintm Fixed in Version => RR18Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker