Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0037567

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2017-12-29 11:18

2018-02-05 13:40

Reporter

guillermogil

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR18Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0037567: OBPOS_preAddPayment Hook is not using callback function

Description

OBPOS_preAddPayment Hook is not using callback function.
it is using callback instead of args.callback

Steps To Reproduce

Add the following code:

OB.UTIL.HookManager.registerHook('OBPOS_preAddPayment', function (args, c) {

      args.callback = function () {
        alert('Callback Working');
      };

  OB.UTIL.HookManager.callbackExecutor(args, c);
});

Add a payment.
Alert should rise

Proposed Solution

See attached diff

Tags

No tags attached.

issue.diff [^] (896 bytes) 2017-12-29 11:33 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -3361,8 +3361,8 @@
               order.save();
               order.trigger('saveCurrent');
             }
-            if (callback instanceof Function) {
-              callback(order);
+            if (args.callback instanceof Function) {
+              args.callback(order);
             }
             };
 
@@ -5425,8 +5425,8 @@
         callback: callback
       }, function (args) {
         var executeFinalCallback = function () {
-            if (callback instanceof Function) {
-              callback(order);
+            if (args.callback instanceof Function) {
+              args.callback(order);
             }
             };

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0101591) hgbot (developer) 2018-01-05 12:49	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3567ef3a07ee80da1e165bdfcbc5c98a8f11fb56 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Jan 05 17:19:18 2018 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3567ef3a07ee80da1e165bdfcbc5c98a8f11fb56 [^] Fixed issue 37567 : Hook argument callback should be called for PreAddPayment hook * Hook argument callback should be called instead of original one, because callback can eb overridden while implementing hook --- M web/org.openbravo.retail.posterminal/js/model/order.js ---

Issue History
Date Modified	Username	Field	Change
2017-12-29 11:18	guillermogil	New Issue
2017-12-29 11:18	guillermogil	Assigned To	=> Retail
2017-12-29 11:18	guillermogil	File Added: issue.diff
2017-12-29 11:18	guillermogil	OBNetwork customer	=> No
2017-12-29 11:18	guillermogil	Triggers an Emergency Pack	=> No
2017-12-29 11:33	guillermogil	File Deleted: issue.diff
2017-12-29 11:33	guillermogil	File Added: issue.diff
2018-01-02 11:04	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2018-01-05 12:49	ranjith_qualiantech_com	Status	new => scheduled
2018-01-05 12:49	hgbot	Checkin
2018-01-05 12:49	hgbot	Note Added: 0101591
2018-01-05 12:49	hgbot	Status	scheduled => resolved
2018-01-05 12:49	hgbot	Resolution	open => fixed
2018-01-05 12:49	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3567ef3a07ee80da1e165bdfcbc5c98a8f11fb56 [^]
2018-02-05 13:40	marvintm	Review Assigned To	=> marvintm
2018-02-05 13:40	marvintm	Status	resolved => closed
2018-02-05 13:40	marvintm	Fixed in Version	=> RR18Q2

Copyright © 2000 - 2009 MantisBT Group