Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037556
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Filter by stock in product searchmajorhave not tried2017-12-27 16:052018-01-29 12:03
ReporterSandrahuguetView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR18Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037556: Performance problem in remote mode filtering by stock criteria

DescriptionPerformance problem in remote mode filtering by stock criteria

Failing test:
https://ci.openbravo.com/view/retail/job/ret-higvol-modules-oracle/878/testReport/org.openbravo.test.mobile.retail.extmodules.selenium.tests.stockcriteria/I30410_CheckStockCriteria/test/ [^]
Steps To ReproduceIn a hgvol environment
-Enable all high volumes preference
-Log in the WebPOS
-Tap on Search
-Filter by stock > 100
Proposed SolutionIn remote mode not allow to filter by stock when no other filter is applied to the same search
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0101274)
hgbot (developer)
2017-12-28 08:54

 Repository: tools/automation/pi-mobile
Changeset: 3a9bdc371e1b9c9e4518af4be194cf7dd3438d4a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Dec 28 08:54:04 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3a9bdc371e1b9c9e4518af4be194cf7dd3438d4a [^]

related to issue 37556 Remove temporarily from hgvol jobs

activate again isHighVolumeCompatible tag when this issue will be fixed

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/highvolumes/I35383_EnsureNumericSearchsContinueWorking_StockCriteria.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I30410_CheckStockCriteria.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I32447_FilterByBrandAndStockCriteria.java
---
(0101749)
hgbot (developer)
2018-01-17 12:08

 Repository: erp/pmods/org.openbravo.retail.stockcriteria
Changeset: b4984e3ed0b38e0f73966ebcb28fb0e9abe5ceb3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 17 16:37:48 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockcriteria/rev/b4984e3ed0b38e0f73966ebcb28fb0e9abe5ceb3 [^]

Related to issue 37556 : Added notRelevantFilter for product filter

* In Remote mode, Stock filter should be executed when atleast one additional filters is applied

---
M web/org.openbravo.retail.stockcriteria/js/hookStockCriteria.js
---
(0101750)
hgbot (developer)
2018-01-17 12:08

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7e9ffa949d1d782a6ebac2ba4f0ce5cd38f3fc0b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 17 16:37:55 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7e9ffa949d1d782a6ebac2ba4f0ce5cd38f3fc0b [^]

Related to issue 37556 : Added relevant Filter for product filter

* Remote mode search will execute when atleast one filter should set "notRelevantFilter" as false

---
M src/org/openbravo/mobile/core/process/ProcessHQLQuery.java
---
(0101766)
hgbot (developer)
2018-01-18 07:13

 Repository: tools/automation/pi-mobile
Changeset: cb09edb5c52c994052485fe96ff99a136e114dd3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jan 18 11:43:07 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/cb09edb5c52c994052485fe96ff99a136e114dd3 [^]

Verifies issue 37556 : Enabled High volume for StockCriteria tests

* I35383_EnsureNumericSearchsContinueWorking_StockCriteria
* I30410_CheckStockCriteria
* I32447_FilterByBrandAndStockCriteria

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/highvolumes/I35383_EnsureNumericSearchsContinueWorking_StockCriteria.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/CheckStockCriteria.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I30410_CheckStockCriteria.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I32447_FilterByBrandAndStockCriteria.java
---
(0101919)
marvintm (manager)
2018-01-23 19:22

 The stock criteria filter is used in a remotely called request also when using "local" mode for the products, because the stock information is only available in the backend. However, in the current fix, the filter is considered non relevant only when the remote mode is enabled, although the query has the same performance problem in local mode because it is essentially the same. Therefore, now remote mode works well, but the problem can still be reproduced currently in local mode, when filtering by stock

The solution is to mark the property as true always, regardless of whether the remote mode is enabled or not.
(0101932)
hgbot (developer)
2018-01-25 07:43

 Repository: erp/pmods/org.openbravo.retail.stockcriteria
Changeset: f093928207951858ad934f81a05a18d9e762ff53
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jan 25 12:13:43 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockcriteria/rev/f093928207951858ad934f81a05a18d9e762ff53 [^]

Related to issue 37556 : Added notRelevantFilter for product filter

* Stock filter should be executed when atleast one additional filters is applied for both remote and non-remote mode

---
M web/org.openbravo.retail.stockcriteria/js/hookStockCriteria.js
---
(0101939)
hgbot (developer)
2018-01-25 12:28

 Repository: tools/automation/pi-mobile
Changeset: d2e72bc5f50b83012e6da929243da4eb5b9741a9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jan 25 16:58:43 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d2e72bc5f50b83012e6da929243da4eb5b9741a9 [^]

Verifies issue 37556 : Modified Test 'I34569_AvoidAddingZeroStockProductOnClickOutSideTheControl'

* Stock filter will not be applied if any other filters are not present

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockvalidation/I34569_AvoidAddingZeroStockProductOnClickOutSideTheControl.java
---

- Issue History
Date Modified Username Field Change
2017-12-27 16:05 Sandrahuguet New Issue
2017-12-27 16:05 Sandrahuguet Assigned To => Retail
2017-12-27 16:05 Sandrahuguet Triggers an Emergency Pack => No
2017-12-27 16:06 Sandrahuguet Tag Attached: Performance
2017-12-27 16:07 Sandrahuguet Proposed Solution updated
2017-12-27 16:12 Sandrahuguet Steps to Reproduce Updated View Revisions
2017-12-27 16:13 Sandrahuguet Steps to Reproduce Updated View Revisions
2017-12-28 08:54 hgbot Checkin
2017-12-28 08:54 hgbot Note Added: 0101274
2018-01-08 10:13 Sandrahuguet Resolution time => 1548716400
2018-01-11 08:30 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2018-01-17 08:31 ranjith_qualiantech_com Status new => scheduled
2018-01-17 12:08 hgbot Checkin
2018-01-17 12:08 hgbot Note Added: 0101749
2018-01-17 12:08 hgbot Checkin
2018-01-17 12:08 hgbot Note Added: 0101750
2018-01-17 18:10 marvintm Resolution time 1548716400 => 1517180400
2018-01-18 07:13 hgbot Checkin
2018-01-18 07:13 hgbot Note Added: 0101766
2018-01-18 07:13 ranjith_qualiantech_com Status scheduled => resolved
2018-01-18 07:13 ranjith_qualiantech_com Resolution open => fixed
2018-01-23 19:22 marvintm Note Added: 0101919
2018-01-23 19:22 marvintm Status resolved => new
2018-01-23 19:22 marvintm Resolution fixed => open
2018-01-25 07:43 hgbot Checkin
2018-01-25 07:43 hgbot Note Added: 0101932
2018-01-25 07:49 ranjith_qualiantech_com Status new => scheduled
2018-01-25 12:28 hgbot Checkin
2018-01-25 12:28 hgbot Note Added: 0101939
2018-01-29 09:11 ranjith_qualiantech_com Status scheduled => resolved
2018-01-29 09:11 ranjith_qualiantech_com Resolution open => fixed
2018-01-29 09:11 marvintm Fixed in Version => RR18Q2
2018-01-29 12:03 marvintm Review Assigned To => marvintm
2018-01-29 12:03 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker