Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0037475

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2017-12-14 11:14

2017-12-22 12:44

Reporter

guilleaer

View Status

public

Assigned To

guilleaer

Priority

normal

Resolution

fixed

Fixed in Version

RR18Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

RR18Q1

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

RR16Q3

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/diff/cec11c87a546/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js [^]

Triggers an Emergency Pack

No

Summary

0037475: The callback of request "InitActions" done by Mobile Core is not being executed

Description

initActions function located in ob-terminal-model.js is doing a request to the server to retrieve several data which is needed by mobile applications.

When request finishes data received form the server is stored in the client side to be used later on.

The problem is that the callback function of the request is not being executed.

Steps To Reproduce

Using a mobile App which doesn't overwrite the standard initActions function you will see that request callback is not executed. For example the available services are not set

OB.RR.RequestRouter.AvailableService -> null

Proposed Solution

Don't use Request Router to execute this request.

Tags

No tags attached.

37475.diff [^] (776 bytes) 2017-12-14 11:34 [Show Content] [Hide Content]

changeset:   3018:aae5f9c0bc88
tag:         tip
user:        Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com>
date:        Thu Dec 14 11:32:22 2017 +0100
summary:     Fixed issue 37475: Don't use request router for init actions request

diff -r 6eb4436882d0 -r aae5f9c0bc88 web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
--- a/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js	Mon Dec 11 13:28:39 2017 +0100
+++ b/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js	Thu Dec 14 11:32:22 2017 +0100
@@ -610,11 +610,7 @@
       if (callback) {
         callback();
       }
-    });
-    rr = new OB.RR.Request({
-      ajaxRequest: loginRequest
-    });
-    rr.exec(loginRequest.url);
+    }).go(params);
   },
 
   /**

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0037521	RR17Q4	closed	guilleaer	The callback of request "InitActions" done by Mobile Core is not being executed
depends on	backport	0037522	RR17Q3.2	closed	guilleaer	The callback of request "InitActions" done by Mobile Core is not being executed

Notes
(0101050) hgbot (developer) 2017-12-15 09:07	Repository: erp/pmods/org.openbravo.mobile.core Changeset: aae5f9c0bc886cbc56359607e0ad892fabb28d61 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu Dec 14 11:32:22 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aae5f9c0bc886cbc56359607e0ad892fabb28d61 [^] Fixed issue 37475: Don't use request router for init actions request --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js ---

Issue History
Date Modified	Username	Field	Change
2017-12-14 11:14	guilleaer	New Issue
2017-12-14 11:14	guilleaer	Assigned To	=> guilleaer
2017-12-14 11:14	guilleaer	OBNetwork customer	=> No
2017-12-14 11:14	guilleaer	Triggers an Emergency Pack	=> No
2017-12-14 11:34	guilleaer	File Added: 37475.diff
2017-12-14 11:34	guilleaer	Status	new => scheduled
2017-12-14 11:35	guilleaer	Review Assigned To	=> migueldejuana
2017-12-15 09:07	hgbot	Checkin
2017-12-15 09:07	hgbot	Note Added: 0101050
2017-12-15 09:07	hgbot	Status	scheduled => resolved
2017-12-15 09:07	hgbot	Resolution	open => fixed
2017-12-15 09:07	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aae5f9c0bc886cbc56359607e0ad892fabb28d61 [^]
2017-12-20 13:15	guilleaer	Status	resolved => new
2017-12-20 13:15	guilleaer	Resolution	fixed => open
2017-12-20 13:21	guilleaer	Regression introduced in release	=> RR16Q3
2017-12-20 13:21	guilleaer	Regression introduced by commit	=> https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/diff/cec11c87a546/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js [^]
2017-12-20 13:21	guilleaer	Status	new => scheduled
2017-12-20 13:21	guilleaer	Status	scheduled => resolved
2017-12-20 13:21	guilleaer	Fixed in Version	=> RR18Q1
2017-12-20 13:21	guilleaer	Resolution	open => fixed
2017-12-22 12:44	marvintm	Review Assigned To	migueldejuana => marvintm
2017-12-22 12:44	marvintm	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group