Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037448 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Cash up | major | always | 2017-12-11 15:17 | 2017-12-20 19:10 | |||
| Reporter | aaroncalero | View Status | public | |||||
| Assigned To | jorge-garcia | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR18Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 79e43cc4018c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037448: RebuildCashUpFromServer doesn't handle correctly network errors | |||||||
| Description | If the OB.UTIL.rebuildCashupFromServer function fails because the connection has been interrupted momentarily, it might happen that a new unprocessed cashup is generated in addition to the existing cashup. | |||||||
| Steps To Reproduce | Log in in backend, go to the preferences window and enable the Web POS Synchronized Mode preference. Verify in POS Terminal window that there is only one unprocessed cashup for the VBS-1 terminal. Log in in web pos (VBS-1 terminal). Create a new ticket and add some products. Click on the total amount button to go to the payment tab. Open developer tools and add the following breakpoints: One inside the OB.UTIL.rebuildCashupFromServer function. (cashUpReportUtils.js) One inside the serviceError function. (ob-datasource.js) Add a payment and click on Done. The code will stop on the OB.UTIL.rebuildCashupFromServer breakpoint. Disconnect the network. Continue the code flow. The code will stop on the serviceError breakpoint. Connect the network again and then continue the flow. The ticket will be correctly synchronized. Log in again in backend and verify on the POS Terminal window that there are now 2 unprocessed cashups for the VBS-1 terminal. | |||||||
| Proposed Solution | If the OB.UTIL.rebuildCashupFromServer function fails with an exception (which is different from returning 0 cashups) or with a connection error, it should show the error to the user and it should stop the workflow. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0101121) hgbot (developer) 2017-12-19 10:25 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 4411cad18c262adcd858941b4657a7ac59c4672e Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Thu Dec 14 16:52:43 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4411cad18c262adcd858941b4657a7ac59c4672e [^] Fixed issue 37448: RebuildCashUpFromServer doesn't handle correctly network errors The solution is to handle network errors as a transaction failure in synchronize mode. To do so, the synchErrorCallback implementation has been moved to a new global function and used in case a network error is raised. --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js --- |
|
(0101122) hgbot (developer) 2017-12-19 10:25 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 79e43cc4018cbb37d0f4d4765715e93628222bb6 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Dec 15 13:56:52 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79e43cc4018cbb37d0f4d4765715e93628222bb6 [^] Fixed issue 37448: RebuildCashUpFromServer doesn't handle correctly network errors The solution is to handle network errors as a transaction failure in synchronize mode. This commits implements only the part for network problem in multiorders. --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-12-11 15:17 | aaroncalero | New Issue | |
| 2017-12-11 15:17 | aaroncalero | Assigned To | => Retail |
| 2017-12-11 15:17 | aaroncalero | OBNetwork customer | => Yes |
| 2017-12-11 15:17 | aaroncalero | Resolution time | => 1514156400 |
| 2017-12-11 15:17 | aaroncalero | Triggers an Emergency Pack | => No |
| 2017-12-12 15:09 | jorge-garcia | Status | new => scheduled |
| 2017-12-12 15:09 | jorge-garcia | Assigned To | Retail => jorge-garcia |
| 2017-12-19 10:25 | hgbot | Checkin | |
| 2017-12-19 10:25 | hgbot | Note Added: 0101121 | |
| 2017-12-19 10:25 | hgbot | Status | scheduled => resolved |
| 2017-12-19 10:25 | hgbot | Resolution | open => fixed |
| 2017-12-19 10:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4411cad18c262adcd858941b4657a7ac59c4672e [^] |
| 2017-12-19 10:25 | hgbot | Checkin | |
| 2017-12-19 10:25 | hgbot | Note Added: 0101122 | |
| 2017-12-19 10:25 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4411cad18c262adcd858941b4657a7ac59c4672e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79e43cc4018cbb37d0f4d4765715e93628222bb6 [^] |
| 2017-12-20 19:10 | marvintm | Review Assigned To | => marvintm |
| 2017-12-20 19:10 | marvintm | Status | resolved => closed |
| 2017-12-20 19:10 | marvintm | Fixed in Version | => RR18Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |