Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037435
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-12-04 08:112018-01-03 12:39
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q1
StatusclosedFix in branchFixed in SCM revision3fed28edc827
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037435: unneeded traces logged when exception occurs on background DalBaseProcess

DescriptionWhen a background DalBaseProcess throws an exception two stack traces are logged in openbravo.log:

1. Stack trace for the actual exception, logged from DalBaseProcess
2. DalBaseProcess generates a new unrelated exception that is logged by DefaultJob
Steps To Reproduce1. Make any background DalBaseProcess fail (ie. apply attached patch for Acct Server Process)
2. Run that process (ie. execute immediate Acct Server Process)
  -> See openbravo.log:

595dbc4c 980205 [DefaultQuartzScheduler_Worker-6] ERROR org.openbravo.service.db.DalBaseProcess - The process org.openbravo.erpCommon.ad_process.AcctServerProcess has thrown an exception.
java.lang.ArithmeticException: / by zero
    at org.openbravo.erpCommon.ad_process.AcctServerProcess.doExecute(AcctServerProcess.java:60)
    at org.openbravo.service.db.DalBaseProcess.execute(DalBaseProcess.java:83)
    at org.openbravo.scheduling.DefaultJob.execute(DefaultJob.java:63)
    at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
    at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:525)
595dbc4c 980205 [DefaultQuartzScheduler_Worker-6] ERROR org.openbravo.scheduling.DefaultJob - Error executing process org.openbravo.scheduling.ProcessBundle@11ac59e2
java.lang.Exception: / by zero
    at org.openbravo.service.db.DalBaseProcess.execute(DalBaseProcess.java:89)
    at org.openbravo.scheduling.DefaultJob.execute(DefaultJob.java:63)
    at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
    at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:525)
TagsNo tags attached.
Attached Filesdiff file icon fail-process.diff [^] (467 bytes) 2017-12-04 08:19 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0036162 acknowledgedTriage Platform Base clean up openbravo.log 

-  Notes
(0100909)
hgbot (developer)
2017-12-04 08:25

 Repository: erp/devel/pi
Changeset: 3fed28edc82710cce1d80092ce304ef06e1964e7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Dec 04 08:24:04 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3fed28edc82710cce1d80092ce304ef06e1964e7 [^]

fixed bug 37435: unneeded log when exception thrown by DalBaseProcess

  When an exception was thrown by a background DalBaseProcess, 2 traces were logged.
  Once with the stack trace of the actual excpetion, another one with a the stack
  trace of a new unrelated generated exception.

  Now DalBaseProcess just rethrows original exception instead of logging it and
  creating a new one, DefaultJob logs it with its stack trace, it also prints a
  readable process name.

---
M src/org/openbravo/scheduling/DefaultJob.java
M src/org/openbravo/service/db/DalBaseProcess.java
---
(0101055)
caristu (developer)
2017-12-15 11:13

 Code reviewed + tested OK.
(0101513)
hudsonbot (developer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-12-04 08:11 alostale New Issue
2017-12-04 08:11 alostale Assigned To => platform
2017-12-04 08:11 alostale Modules => Core
2017-12-04 08:11 alostale Triggers an Emergency Pack => No
2017-12-04 08:11 alostale Assigned To platform => alostale
2017-12-04 08:11 alostale Review Assigned To => caristu
2017-12-04 08:12 alostale Relationship added blocks 0036162
2017-12-04 08:19 alostale File Added: fail-process.diff
2017-12-04 08:25 hgbot Checkin
2017-12-04 08:25 hgbot Note Added: 0100909
2017-12-04 08:25 hgbot Status new => resolved
2017-12-04 08:25 hgbot Resolution open => fixed
2017-12-04 08:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3fed28edc82710cce1d80092ce304ef06e1964e7 [^]
2017-12-15 11:13 caristu Note Added: 0101055
2017-12-15 11:13 caristu Status resolved => closed
2017-12-15 11:13 caristu Fixed in Version => 3.0PR18Q1
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101513

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker