0037362: The financial account configuration for a payment method is not taken into account to create reconciliations in the cashup

Description

When a cashup is closed, transactions created during that cashup are reconciled adn the money is moved to the financial account defined on the Close events for each payment method.
The "automatic deposit" flag of the payment method defines if these reconciliations should be created or not.
This flag can be found on the generic Payment Method configuration, and also on the Financial Account Payment method configuration (which should override the generic configuration).

The problem is that in order to decide if reconciliations should be created or not, the generic configuration is being taken into account, instead of the configuration on the financial account.

Steps To Reproduce

Using White Valley sampledata:
Log in in backend, go to the Payment Method window, locate the "Wire Transfer" record (this is the Card payment method in webpos) and verify that the Automatic Deposit flag is checked.
Go to the Financial account window, locate the "Credit Card - Vall Blanca Store" record and on the Payment Method tab, verify that the Wire Transfer record is also configured as Automatic Deposit.
Go to the Organization window, Vall Blanca Store record, and on the Cash Management Events tab locate the "Credit Card - Close - Vall Blanca Store" record.

Log in in webpos, terminal VBS-1 and do a cashup to clear all values
Create a new ticket, add a product and complete the ticket paying with Card
Do another cashup.
Go to backend, POS Terminal window; select the VBS-1 record, go to the Payment Type tab, select Card and open the Reconciliation subtab. Verify that a new reconciliation has been created. Navigate to the reconciliation and verify that on the Cleared Items subtab there are two transactions (the payment and the movement to the Close Financial Account).

Go back to the Payment Method window, Wire Transfer record and uncheck the Automatic Deposit flag.
Go back to webpos, create a new ticket, pay it with card, and do another cashup.
Verify that this time, there is no new reconciliation created for the Card payment method, even if the configuration on the Financial Account window still flags the payment method as Automatic Deposit.

Proposed Solution

The following line on the commit that causes the issue:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8#l1.14 [^]
reads the automatic deposit flag directly from the payment method, which is wrong.

At this point we have the information of the financial account and the payment method, so it should be easy to refactor that code to get the Automatic Deposit flag from the financial account configuration.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0036523

closed

ranjith_qualiantech_com

The financial account configuration for a payment method is not taken into account to create reconciliations in the cashup

Notes
(0100691) hgbot (developer) 2017-11-23 14:50	Repository: retail/backports/3.0RR17Q3.2/org.openbravo.retail.posterminal Changeset: dc63edc4b19a2ead1471e4e21e925044e0d5ab93 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu Nov 23 19:19:52 2017 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.2/org.openbravo.retail.posterminal/rev/dc63edc4b19a2ead1471e4e21e925044e0d5ab93 [^] Fixed issue 37362 : Validate Payment method Automatic deposit with Financial account Payment method --- M src/org/openbravo/retail/posterminal/CashCloseProcessor.java ---

Issue History
Date Modified	Username	Field	Change
2017-11-22 13:57	marvintm	Type	defect => backport
2017-11-22 13:57	marvintm	Target Version	=> RR17Q3.2
2017-11-23 14:50	hgbot	Checkin
2017-11-23 14:50	hgbot	Note Added: 0100691
2017-11-23 14:50	hgbot	Status	scheduled => resolved
2017-11-23 14:50	hgbot	Resolution	open => fixed
2017-11-23 14:50	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/11dde8dc94db70347d947817cb9b94b82abc67f9 [^] => http://code.openbravo.com/retail/backports/3.0RR17Q3.2/org.openbravo.retail.posterminal/rev/dc63edc4b19a2ead1471e4e21e925044e0d5ab93 [^]
2017-12-20 19:49	marvintm	Status	resolved => closed
2017-12-20 19:49	marvintm	Fixed in Version	=> RR17Q3.2