Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037346 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Advanced Warehouse Operations | major | always | 2017-11-21 14:52 | 2018-02-22 18:18 | |||
| Reporter | dmiguelez | View Status | public | |||||
| Assigned To | nonofrancisco | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | afcc11c86a51 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | dmiguelez | |||||||
| Regression introduced in release | ||||||||
| Summary | 0037346: When creating a Sales Order from a Sales Quotation, the Pending to Pick Lines field is not calculated correctly | |||||||
| Description | When creating a Sales Order from a Sales Quotation, the Pending to Pick Lines field is not calculated correctly | |||||||
| Steps To Reproduce | Log in as AWO-QA Admin Go to Sales Quotation Window and create a new record with: * Organization: US West Coast * Business Partner: Healthy Food Supermarkets * Warehouse: US West Coast Move to lines tab and create a new record with: * Product: Ale Beer * Operative Quantity: 5 Move to Basic Discounts Tab and remove the record created Click on Book button to complete the order Click on Create Order and generate a Sales Order from the Quotation Check that the new Sales Order has only one line, tub in the header it has Pending to Pick Lines: 2 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0100899) nonofrancisco (developer) 2017-12-01 16:00 |
Test Plan No. 1 Log in as AWO-QA Admin Go to Sales Quotation Window and create a new record with: * Organization: US West Coast * Business Partner: Healthy Food Supermarkets * Warehouse: US West Coast Move to lines tab and create a new record with: * Product: Ale Beer * Operative Quantity: 5 Move to Basic Discounts Tab and remove the record created Click on Book button to complete the order Click on Create Order and generate a Sales Order from the Quotation Check that the new Sales Order has only one line and in the header it has Pending to Pick Lines: 1 Test Plan No. 2 Log in as AWO-QA Admin Go to Sales Quotation Window and create a new record with: * Organization: US West Coast * Business Partner: Healthy Food Supermarkets * Warehouse: US West Coast Move to lines tab and create a new records with: * Product: Ale Beer * Operative Quantity: 5 * Product: Apple * Operative Quantity: 5 * Product: Apple Juice * Operative Quantity: 5 Move to Basic Discounts Tab and remove the record created Click on Book button to complete the order Click on Create Order and generate a Sales Order from the Quotation Check that the new Sales Order has three lines and in the header it has Pending to Pick Lines: 3 |
|
(0101643) hgbot (developer) 2018-01-10 08:44 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: afcc11c86a51ba377ed5b8dc483a5b4fae42c6f2 Author: Nono Carballo <nonofce <at> gmail.com> Date: Sat Dec 02 10:23:15 2017 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/afcc11c86a51ba377ed5b8dc483a5b4fae42c6f2 [^] Fixes issue 37346: When creating a Sales Order from a Sales Quotation, the Pending to Pick Lines field is not calculated correctly A new Event Observer was registered to Order entity to set pending picking lines to zero if order was created from quotation. --- A src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/OrderEventObserver.java --- |
|
(0101644) hgbot (developer) 2018-01-10 08:49 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: fcab56169663e4007451494a4ca17b51770e2ac4 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Jan 10 08:49:38 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/fcab56169663e4007451494a4ca17b51770e2ac4 [^] Related to Issue 37346. Code Review changes. OrderEventObserver sets the pendingPickingLines to 0 for all created Sales Orders, not just for Sales Quotations. This is done to prevent problems when cloning an existing Sales Order --- M src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/OrderEventObserver.java --- |
|
(0101658) hgbot (developer) 2018-01-10 16:12 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: fc5e232f8bca1badbb2fed7de08612ac2e6f7cc7 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Jan 10 10:26:07 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/fc5e232f8bca1badbb2fed7de08612ac2e6f7cc7 [^] Related to Issue 37346. Adds automated test for this issue --- M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOq_PendingPickingLines.java --- |
|
(0101667) hgbot (developer) 2018-01-11 16:25 |
Repository: erp/devel/pi Changeset: cec0dd19db4b1c1e57428600977f17fb6ab53400 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Fri Jan 05 13:09:45 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/cec0dd19db4b1c1e57428600977f17fb6ab53400 [^] Related to Issue 37346. Refactor to improve ConvertQuotationIntoOrder Process: * Extracted logic into a different public method, so it can be called from outside the process * Removed unused variables --- M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java --- |
|
(0101668) hgbot (developer) 2018-01-11 16:25 |
Repository: erp/devel/pi Changeset: 85098c97fe383620b6fdbb4e357737bcdfc90f06 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Fri Jan 05 13:28:29 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/85098c97fe383620b6fdbb4e357737bcdfc90f06 [^] Related to Issue 37346. Refactor in ConvertQuotationIntoOrder Process. Renamed variables to make the code more understandable --- M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java --- |
|
(0101669) hgbot (developer) 2018-01-11 16:25 |
Repository: erp/devel/pi Changeset: 55fa7151b1cf992ea0a6014d617f76085645153a Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Jan 10 09:35:44 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/55fa7151b1cf992ea0a6014d617f76085645153a [^] Related to Issue 37346. Changed the returned parameter from convertQuotationIntoSalesOrder * The method convertQuotationIntoSalesOrder returns an Order when created * When is not possible to create the Sales Order due to some restriction, it throws an OBException that is captured to print the error message --- M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java --- |
|
(0101670) hgbot (developer) 2018-01-11 16:30 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 29a171ae30ddf1ce86092456655e5b22bc74a511 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Jan 10 10:26:07 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/29a171ae30ddf1ce86092456655e5b22bc74a511 [^] Related to Issue 37346. Adds automated test for this issue --- M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOq_PendingPickingLines.java --- |
|
(0101671) dmiguelez (developer) 2018-01-11 16:32 |
Code Review + Testing Ok |
|
(0101706) hgbot (developer) 2018-01-15 17:28 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 53f5fa31f49a76d8fbb90333949e7e27ded443a2 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Jan 10 10:26:07 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/53f5fa31f49a76d8fbb90333949e7e27ded443a2 [^] Related to Issue 37346. Adds automated test for this issue --- M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOq_PendingPickingLines.java --- |
|
(0102652) hudsonbot (developer) 2018-02-22 18:18 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102653) hudsonbot (developer) 2018-02-22 18:18 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
(0102654) hudsonbot (developer) 2018-02-22 18:18 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-11-21 14:52 | dmiguelez | New Issue | |
| 2017-11-21 14:52 | dmiguelez | Assigned To | => dmiguelez |
| 2017-11-27 12:09 | dmiguelez | Severity | minor => major |
| 2017-11-30 16:03 | dmiguelez | Assigned To | dmiguelez => nonofrancisco |
| 2017-11-30 16:11 | nonofrancisco | Status | new => scheduled |
| 2017-12-01 16:00 | nonofrancisco | Note Added: 0100899 | |
| 2018-01-10 08:44 | hgbot | Checkin | |
| 2018-01-10 08:44 | hgbot | Note Added: 0101643 | |
| 2018-01-10 08:44 | hgbot | Status | scheduled => resolved |
| 2018-01-10 08:44 | hgbot | Resolution | open => fixed |
| 2018-01-10 08:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/afcc11c86a51ba377ed5b8dc483a5b4fae42c6f2 [^] |
| 2018-01-10 08:49 | hgbot | Checkin | |
| 2018-01-10 08:49 | hgbot | Note Added: 0101644 | |
| 2018-01-10 16:12 | hgbot | Checkin | |
| 2018-01-10 16:12 | hgbot | Note Added: 0101658 | |
| 2018-01-11 16:25 | hgbot | Checkin | |
| 2018-01-11 16:25 | hgbot | Note Added: 0101667 | |
| 2018-01-11 16:25 | hgbot | Checkin | |
| 2018-01-11 16:25 | hgbot | Note Added: 0101668 | |
| 2018-01-11 16:25 | hgbot | Checkin | |
| 2018-01-11 16:25 | hgbot | Note Added: 0101669 | |
| 2018-01-11 16:30 | hgbot | Checkin | |
| 2018-01-11 16:30 | hgbot | Note Added: 0101670 | |
| 2018-01-11 16:32 | dmiguelez | Review Assigned To | => dmiguelez |
| 2018-01-11 16:32 | dmiguelez | Note Added: 0101671 | |
| 2018-01-11 16:32 | dmiguelez | Status | resolved => closed |
| 2018-01-15 17:28 | hgbot | Checkin | |
| 2018-01-15 17:28 | hgbot | Note Added: 0101706 | |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102652 | |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102653 | |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102654 | |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |