Openbravo Issue Tracking System - Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0037346 | Modules | Advanced Warehouse Operations | public | 2017-11-21 14:52 | 2018-02-22 18:18 |
|
| Reporter | dmiguelez | |
| Assigned To | nonofrancisco | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | dmiguelez |
| Support ticket | |
| OBNetwork customer | |
| Regression introduced in release | |
|
| Summary | 0037346: When creating a Sales Order from a Sales Quotation, the Pending to Pick Lines field is not calculated correctly |
| Description | When creating a Sales Order from a Sales Quotation, the Pending to Pick Lines field is not calculated correctly |
| Steps To Reproduce | Log in as AWO-QA Admin
Go to Sales Quotation Window and create a new record with:
* Organization: US West Coast
* Business Partner: Healthy Food Supermarkets
* Warehouse: US West Coast
Move to lines tab and create a new record with:
* Product: Ale Beer
* Operative Quantity: 5
Move to Basic Discounts Tab and remove the record created
Click on Book button to complete the order
Click on Create Order and generate a Sales Order from the Quotation
Check that the new Sales Order has only one line, tub in the header it has Pending to Pick Lines: 2 |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-11-21 14:52 | dmiguelez | New Issue | |
| 2017-11-21 14:52 | dmiguelez | Assigned To | => dmiguelez |
| 2017-11-27 12:09 | dmiguelez | Severity | minor => major |
| 2017-11-30 16:03 | dmiguelez | Assigned To | dmiguelez => nonofrancisco |
| 2017-11-30 16:11 | nonofrancisco | Status | new => scheduled |
| 2017-12-01 16:00 | nonofrancisco | Note Added: 0100899 | |
| 2018-01-10 08:44 | hgbot | Checkin | |
| 2018-01-10 08:44 | hgbot | Note Added: 0101643 | |
| 2018-01-10 08:44 | hgbot | Status | scheduled => resolved |
| 2018-01-10 08:44 | hgbot | Resolution | open => fixed |
| 2018-01-10 08:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/afcc11c86a51ba377ed5b8dc483a5b4fae42c6f2 [^] |
| 2018-01-10 08:49 | hgbot | Checkin | |
| 2018-01-10 08:49 | hgbot | Note Added: 0101644 | |
| 2018-01-10 16:12 | hgbot | Checkin | |
| 2018-01-10 16:12 | hgbot | Note Added: 0101658 | |
| 2018-01-11 16:25 | hgbot | Checkin | |
| 2018-01-11 16:25 | hgbot | Note Added: 0101667 | |
| 2018-01-11 16:25 | hgbot | Checkin | |
| 2018-01-11 16:25 | hgbot | Note Added: 0101668 | |
| 2018-01-11 16:25 | hgbot | Checkin | |
| 2018-01-11 16:25 | hgbot | Note Added: 0101669 | |
| 2018-01-11 16:30 | hgbot | Checkin | |
| 2018-01-11 16:30 | hgbot | Note Added: 0101670 | |
| 2018-01-11 16:32 | dmiguelez | Review Assigned To | => dmiguelez |
| 2018-01-11 16:32 | dmiguelez | Note Added: 0101671 | |
| 2018-01-11 16:32 | dmiguelez | Status | resolved => closed |
| 2018-01-15 17:28 | hgbot | Checkin | |
| 2018-01-15 17:28 | hgbot | Note Added: 0101706 | |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102652 | |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102653 | |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102654 | |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Notes |
|
|
|
Test Plan No. 1
Log in as AWO-QA Admin
Go to Sales Quotation Window and create a new record with:
* Organization: US West Coast
* Business Partner: Healthy Food Supermarkets
* Warehouse: US West Coast
Move to lines tab and create a new record with:
* Product: Ale Beer
* Operative Quantity: 5
Move to Basic Discounts Tab and remove the record created
Click on Book button to complete the order
Click on Create Order and generate a Sales Order from the Quotation
Check that the new Sales Order has only one line and in the header it has Pending to Pick Lines: 1
Test Plan No. 2
Log in as AWO-QA Admin
Go to Sales Quotation Window and create a new record with:
* Organization: US West Coast
* Business Partner: Healthy Food Supermarkets
* Warehouse: US West Coast
Move to lines tab and create a new records with:
* Product: Ale Beer
* Operative Quantity: 5
* Product: Apple
* Operative Quantity: 5
* Product: Apple Juice
* Operative Quantity: 5
Move to Basic Discounts Tab and remove the record created
Click on Book button to complete the order
Click on Create Order and generate a Sales Order from the Quotation
Check that the new Sales Order has three lines and in the header it has Pending to Pick Lines: 3 |
|
|
|
(0101643)
|
|
hgbot
|
|
2018-01-10 08:44
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: afcc11c86a51ba377ed5b8dc483a5b4fae42c6f2
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Sat Dec 02 10:23:15 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/afcc11c86a51ba377ed5b8dc483a5b4fae42c6f2 [^]
Fixes issue 37346: When creating a Sales Order from a Sales Quotation,
the Pending to Pick Lines field is not calculated correctly
A new Event Observer was registered to Order entity to set pending picking lines
to zero if order was created from quotation.
---
A src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/OrderEventObserver.java
---
|
|
|
|
(0101644)
|
|
hgbot
|
|
2018-01-10 08:49
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: fcab56169663e4007451494a4ca17b51770e2ac4
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jan 10 08:49:38 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/fcab56169663e4007451494a4ca17b51770e2ac4 [^]
Related to Issue 37346. Code Review changes.
OrderEventObserver sets the pendingPickingLines to 0 for all created Sales Orders,
not just for Sales Quotations. This is done to prevent problems
when cloning an existing Sales Order
---
M src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/OrderEventObserver.java
---
|
|
|
|
(0101658)
|
|
hgbot
|
|
2018-01-10 16:12
|
|
|
|
|
(0101667)
|
|
hgbot
|
|
2018-01-11 16:25
|
|
Repository: erp/devel/pi
Changeset: cec0dd19db4b1c1e57428600977f17fb6ab53400
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 05 13:09:45 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cec0dd19db4b1c1e57428600977f17fb6ab53400 [^]
Related to Issue 37346. Refactor to improve ConvertQuotationIntoOrder Process:
* Extracted logic into a different public method, so it can be called from
outside the process
* Removed unused variables
---
M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
---
|
|
|
|
(0101668)
|
|
hgbot
|
|
2018-01-11 16:25
|
|
Repository: erp/devel/pi
Changeset: 85098c97fe383620b6fdbb4e357737bcdfc90f06
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 05 13:28:29 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/85098c97fe383620b6fdbb4e357737bcdfc90f06 [^]
Related to Issue 37346. Refactor in ConvertQuotationIntoOrder Process.
Renamed variables to make the code more understandable
---
M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
---
|
|
|
|
(0101669)
|
|
hgbot
|
|
2018-01-11 16:25
|
|
Repository: erp/devel/pi
Changeset: 55fa7151b1cf992ea0a6014d617f76085645153a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jan 10 09:35:44 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/55fa7151b1cf992ea0a6014d617f76085645153a [^]
Related to Issue 37346. Changed the returned parameter from convertQuotationIntoSalesOrder
* The method convertQuotationIntoSalesOrder returns an Order when created
* When is not possible to create the Sales Order due to some restriction,
it throws an OBException that is captured to print the error message
---
M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
---
|
|
|
|
(0101670)
|
|
hgbot
|
|
2018-01-11 16:30
|
|
|
|
|
|
|
|
|
(0101706)
|
|
hgbot
|
|
2018-01-15 17:28
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|