Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037332
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts Combomajoralways2017-11-20 17:392018-06-26 11:43
ReportermalsasuaView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revision45cacd2fa589
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket49156
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037332: combo discount is not applied but it is displayed in some lines

Descriptionwhen a combo discount is not applied because the amount of combo is higher than the lines without combo discount, the discount is displayed in the lines of ticket except in the last line
Steps To Reproducebackoffice:
. configure one combo discount:
  . total combo 10
  . three families:
   . F1 -> type: fixed price- price 4
     . prod tab: prod1 (price 4)
   . F2 -> type: fixed price- price 4
     . prod tab: prod2 (price 4)
   . F3 -> type: fixed price- price 2
     . prod tab: prod3 (price 1)
POS Terminal
 apply the combo discount
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0037178 closedmalsasua When combo is added and total button is clicked, the lines of ticket are removed and total amount is set to 0 

-  Notes
(0100743)
hgbot (developer)
2017-11-27 17:27

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 45cacd2fa5894fb1b37f3616274422f28ffd963a
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Fri Nov 24 15:25:52 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/45cacd2fa5894fb1b37f3616274422f28ffd963a [^]

Fixed issue 37332: combo discount is not applied but it is displayed in some
lines

- A new field EM_Obcombo_Allowhighdiscprice was added to allow Combo
Discount price greater than the lines price

---
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0100801)
hgbot (developer)
2017-11-28 20:23

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: bb920b544a0a960830be02b7abbda73086688ba6
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Nov 28 14:21:41 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/bb920b544a0a960830be02b7abbda73086688ba6 [^]

Related to issue 37332: combo discount is not applied but it is displayed in some
lines

---
M src-db/database/model/modifiedTables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0100802)
hgbot (developer)
2017-11-28 20:31

 Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: c5c2bd262cdd6a8bd6d28ce515dce59c2da942df
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Nov 28 14:30:01 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/c5c2bd262cdd6a8bd6d28ce515dce59c2da942df [^]

Related to issue 37332: combo discount is not applied but it is displayed in
some lines

---
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0100937)
marvintm (viewer)
2017-12-07 13:21

 The fix is not complete. Now it works correctly for the Combo discount, but it still doesn't work correctly for the Combo Fixed Price discount. The current change is correct, but an additional change needs to be added for this case.

In combo-rule-impl.js file, in line 365, the promotion amount is checked to be positive. This check needs to be modified to take into account the discountRule.get('obcomboAllowinclineprice') property.
(0100948)
hgbot (developer)
2017-12-08 18:55

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 97e927b46e1b378e90d6bbe679dc99f3b21ecdb5
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Fri Dec 08 12:41:28 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/97e927b46e1b378e90d6bbe679dc99f3b21ecdb5 [^]

Related to issue 37332: combo discount is not applied but it is displayed in some
lines

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0100950)
hgbot (developer)
2017-12-08 21:26

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: d21018681c65663510e85944ce5bab116ca027a0
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Fri Dec 08 15:26:07 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/d21018681c65663510e85944ce5bab116ca027a0 [^]

Related to issue 37332: combo discount is not applied but it is displayed in
some lines

Backed out changeset: 97e927b46e1b

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0101008)
hgbot (developer)
2017-12-12 21:39

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 4ec537f7cccf16cd0383a2b69d38fe8ba517aa66
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Dec 12 09:29:01 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/4ec537f7cccf16cd0383a2b69d38fe8ba517aa66 [^]

Related to issue 37332: combo discount is not applied but it is displayed in
some lines

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0101013)
hgbot (developer)
2017-12-13 14:56

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 7d69c64fa936cbccfd7a46ea81b4ed100d6647c0
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Dec 13 08:49:26 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/7d69c64fa936cbccfd7a46ea81b4ed100d6647c0 [^]

Related to issue 37332: combo discount is not applied but it is displayed in
some lines

- Backed out changeset: 4ec537f7cccf

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0101046)
hgbot (developer)
2017-12-14 18:22

 Repository: tools/automation/pi-mobile
Changeset: f682dbbc3be2d663a3b2ea64ae0faa05564eb23e
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Thu Dec 14 12:20:31 2017 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f682dbbc3be2d663a3b2ea64ae0faa05564eb23e [^]

Related to issue 37332: combo discount is not applied but it is displayed in
some lines

- Added support for new check "Allow Increase Line Price"

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I35583_VerifyComboFixPriceII.java
---
(0101066)
hgbot (developer)
2017-12-15 16:21

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: b960d28b42bf0ef909e7d1cfb954053a26645f92
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Thu Dec 14 12:25:03 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/b960d28b42bf0ef909e7d1cfb954053a26645f92 [^]

Related to issue 37332: combo discount is not applied but it is displayed in
some lines

- Test I35583_VerifyComboFixPriceII related was fixed

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---

- Issue History
Date Modified Username Field Change
2017-11-20 17:39 malsasua New Issue
2017-11-20 17:39 malsasua Assigned To => Retail
2017-11-20 17:39 malsasua OBNetwork customer => Yes
2017-11-20 17:39 malsasua Support ticket => 49156
2017-11-20 17:39 malsasua Resolution time => 1512860400
2017-11-20 17:39 malsasua Triggers an Emergency Pack => No
2017-11-20 17:48 malsasua Relationship added related to 0037178
2017-11-22 21:57 rqueralta Assigned To Retail => rqueralta
2017-11-22 21:57 rqueralta Status new => scheduled
2017-11-27 17:27 hgbot Checkin
2017-11-27 17:27 hgbot Note Added: 0100743
2017-11-27 17:27 hgbot Status scheduled => resolved
2017-11-27 17:27 hgbot Resolution open => fixed
2017-11-27 17:27 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/45cacd2fa5894fb1b37f3616274422f28ffd963a [^]
2017-11-28 20:23 hgbot Checkin
2017-11-28 20:23 hgbot Note Added: 0100801
2017-11-28 20:31 hgbot Checkin
2017-11-28 20:31 hgbot Note Added: 0100802
2017-12-07 13:21 marvintm Note Added: 0100937
2017-12-07 13:21 marvintm Status resolved => new
2017-12-07 13:21 marvintm Resolution fixed => open
2017-12-08 18:55 hgbot Checkin
2017-12-08 18:55 hgbot Note Added: 0100948
2017-12-08 21:26 hgbot Checkin
2017-12-08 21:26 hgbot Note Added: 0100950
2017-12-11 11:28 marvintm Status new => scheduled
2017-12-11 11:28 marvintm Status scheduled => resolved
2017-12-11 11:28 marvintm Fixed in Version => RR18Q1
2017-12-11 11:28 marvintm Resolution open => fixed
2017-12-11 12:42 marvintm Status resolved => new
2017-12-11 12:42 marvintm Resolution fixed => open
2017-12-11 12:42 marvintm Fixed in Version RR18Q1 =>
2017-12-12 21:39 hgbot Checkin
2017-12-12 21:39 hgbot Note Added: 0101008
2017-12-13 14:56 hgbot Checkin
2017-12-13 14:56 hgbot Note Added: 0101013
2017-12-14 18:22 hgbot Checkin
2017-12-14 18:22 hgbot Note Added: 0101046
2017-12-15 16:21 hgbot Checkin
2017-12-15 16:21 hgbot Note Added: 0101066
2017-12-17 18:33 marvintm Status new => scheduled
2017-12-17 18:33 marvintm Status scheduled => resolved
2017-12-17 18:33 marvintm Fixed in Version => RR18Q1
2017-12-17 18:33 marvintm Resolution open => fixed
2017-12-18 09:34 marvintm Review Assigned To => marvintm
2017-12-18 09:34 marvintm Status resolved => closed
2018-06-26 11:30 hgbot Checkin
2018-06-26 11:30 hgbot Note Added: 0105391
2018-06-26 11:43 hgbot Checkin
2018-06-26 11:43 hgbot Note Added: 0105434
2018-06-26 13:46 gorka_gil Note Deleted: 0105391
2018-06-26 13:46 gorka_gil Note Deleted: 0105434

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker