Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037331
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-11-20 16:342018-08-09 17:16
ReporterasiermartirenaView Statuspublic 
Assigned Torqueralta 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision3edd617ad84f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037331: The totalAmount button can be disabled for draft ticket

DescriptionIt is possible to have the total amount button disabled for a ticket in draft, when should be enabled.

This occurs when having a ticket with some lines and a total amount of 0, and a new ticket created in background. After moving from the new ticket to the one with amount 0, the total amount button maintains disable.
Steps To ReproduceCreate a ticket with some lines and a total amount of 0 (can be done setting the amount of each line to 0 or having positive and negative lines).

Click on the '*' button to have a new draft ticket.

Move to the other ticket.

Realize that the total amount button is still disable.
TagsNo tags attached.
Attached Filesdiff file icon clearWithProcess.diff [^] (3,267 bytes) 2018-06-08 11:09 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0100668)
hgbot (developer)
2017-11-22 15:41

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2c61812255231dbb9823511d34a1ebf19157d554
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Mon Nov 20 16:36:30 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2c61812255231dbb9823511d34a1ebf19157d554 [^]

Fixed issue 37331: The totalAmount button can be disabled for draft ticket

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0100892)
migueldejuana (developer)
2017-12-01 12:36

The function disabledChanged has this:

    function requirementsAreMet(model) {
      // This function is in charge of managing all the requirements of the pay button to be enabled and disabled
      // Any attribute or parameter used to change the state of the button MUST be managed here
(0104990)
hgbot (developer)
2018-06-07 03:48

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3edd617ad84f0475cb3f517a624678e499af2081
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Jun 06 11:46:34 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3edd617ad84f0475cb3f517a624678e499af2081 [^]

Fixed issue 37331: The totalAmount button can be disabled for draft ticket

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0105000)
migueldejuana (developer)
2018-06-07 11:56
edited on: 2018-06-07 16:21

Please, fix following topics:

- When pushing a commit, write a detailed explanation of what was done in the changeset.

- Perhaps we could replace this:
requirements.isReceiptLinesLengthGreaterThanZero = (model.get('orderList').current.get('lines').length > 0) ? model.get('orderList').current.get('lines').length > 0 : receipt.get('lines').length > 0;

with this(check if this would work in all cases):
requirements.isReceiptLinesLengthGreaterThanZero = model.get('orderList').current.get('lines').length > 0

- The following case is not covered yet:
1.- Login Webpos
2.- Add a product
3.- Set the price of the line to 0
4.- The total button is 0.00 and it is enabled
5.- Press F5
6.- ERROR! It is 0.00 but is disabled and it should be enabled

(0105065)
hgbot (developer)
2018-06-11 15:37

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 36215ed446756625d45a43bd1eb83b57818bf06c
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sat Jun 09 23:47:34 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/36215ed446756625d45a43bd1eb83b57818bf06c [^]

Related to issue 37331: The totalAmount button can be disabled for draft ticket

- Creates a Mobile Process for clearWith. clearWith is the function which sets
the order attributes

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0105068)
migueldejuana (developer)
2018-06-11 17:09

Tested and reviewed
(0106263)
alekosmp86 (reporter)
2018-08-09 17:16

Added automated test

https://code.openbravo.com/tools/automation/pi-mobile/rev/7c3ec1908496 [^]

- Issue History
Date Modified Username Field Change
2017-11-20 16:34 asiermartirena New Issue
2017-11-20 16:34 asiermartirena Assigned To => asiermartirena
2017-11-20 16:34 asiermartirena Triggers an Emergency Pack => No
2017-11-22 15:41 hgbot Checkin
2017-11-22 15:41 hgbot Note Added: 0100668
2017-11-22 15:41 hgbot Status new => resolved
2017-11-22 15:41 hgbot Resolution open => fixed
2017-11-22 15:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2c61812255231dbb9823511d34a1ebf19157d554 [^]
2017-12-01 12:36 migueldejuana Note Added: 0100892
2017-12-01 12:36 migueldejuana Status resolved => new
2017-12-01 12:36 migueldejuana Resolution fixed => open
2018-05-28 03:54 rqueralta Assigned To asiermartirena => rqueralta
2018-06-07 03:48 hgbot Checkin
2018-06-07 03:48 hgbot Note Added: 0104990
2018-06-07 03:48 hgbot Status new => resolved
2018-06-07 03:48 hgbot Resolution open => fixed
2018-06-07 03:48 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2c61812255231dbb9823511d34a1ebf19157d554 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3edd617ad84f0475cb3f517a624678e499af2081 [^]
2018-06-07 11:56 migueldejuana Note Added: 0105000
2018-06-07 11:56 migueldejuana Status resolved => new
2018-06-07 11:56 migueldejuana Resolution fixed => open
2018-06-07 16:21 migueldejuana Note Edited: 0105000 View Revisions
2018-06-07 16:21 migueldejuana Note Edited: 0105000 View Revisions
2018-06-07 16:21 migueldejuana Note Edited: 0105000 View Revisions
2018-06-08 11:09 migueldejuana File Added: clearWithProcess.diff
2018-06-11 15:37 hgbot Checkin
2018-06-11 15:37 hgbot Note Added: 0105065
2018-06-11 16:02 rqueralta Status new => scheduled
2018-06-11 16:02 rqueralta Status scheduled => resolved
2018-06-11 16:02 rqueralta Resolution open => fixed
2018-06-11 17:09 migueldejuana Review Assigned To => migueldejuana
2018-06-11 17:09 migueldejuana Note Added: 0105068
2018-06-11 17:09 migueldejuana Status resolved => closed
2018-08-09 17:16 alekosmp86 Note Added: 0106263


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker