Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037307 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | always | 2017-11-16 11:02 | 2018-06-25 08:31 | |||
| Reporter | JONHM | View Status | public | |||||
| Assigned To | gorka_gil | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR18Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | c77ba5d50245 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | 49446 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037307: Images are overlapped if property "Web POS Product Images from server instead of cache" is set | |||||||
| Description | When setting a product with a png image having an alpha background channel, the image is overlapped with the default "box" image, if the property "Web POS Product Images from server instead of cache" is set | |||||||
| Steps To Reproduce | 1) Open "Product" window and pick 'Avalanche transceiver'. Set its image with the attached one (test7.png). 2) Run 'Generate Product Images' process: - Assortment: White Valley Group Product List - Overwrite Existing Images: YES 3) Open "Preference" window and create a new preference: - Client: The White Valley Group - Organization: * - Property: Web POS Product Images from server instead of cache - Value: Y - Visible at User: Empty 4) Then, open WebPOS and switch to 'Browse' tab. The images will be overlapped | |||||||
| Proposed Solution | On file: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/web/org.openbravo.retail.posterminal/js/components/renderproduct.js#l225 [^] the background-image uses both images | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Screenshot from 2017-11-16 10-49-27.png [^] (398,327 bytes) 2017-11-16 11:03 test7.png [^] (71,217 bytes) 2017-11-16 11:03
 proposal-fix-not-complete.hg [^] (7,750 bytes) 2018-06-12 13:08 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0102255) hgbot (developer) 2018-02-07 15:20 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f74cd732abca0bfff4d1176d6afe2f3ba2a694e8 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Fri Feb 02 15:10:10 2018 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f74cd732abca0bfff4d1176d6afe2f3ba2a694e8 [^] Fixes issue 37307: Images are overlapped if property "Web POS Product Images from server instead of cache" is set. --- M web/org.openbravo.retail.posterminal/js/components/renderproduct.js --- |
|
(0102260) hgbot (developer) 2018-02-07 16:54 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: bc565218b8dc9b0a90350201f8cca5707c502783 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Wed Feb 07 10:54:07 2018 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bc565218b8dc9b0a90350201f8cca5707c502783 [^] Related to issue 37307: Images are overlapped if property "Web POS Product Images from server instead of cache" is set Backed out changeset: f74cd732abca --- M web/org.openbravo.retail.posterminal/js/components/renderproduct.js --- |
|
(0102274) hgbot (developer) 2018-02-08 16:12 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: c5bd79531fd637afbedee9c500229fa1420dc6b1 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Fri Feb 02 15:10:10 2018 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c5bd79531fd637afbedee9c500229fa1420dc6b1 [^] Fixes issue 37307: Images are overlapped if property "Web POS Product Images from server instead of cache" is set. --- M web/org.openbravo.retail.posterminal/js/components/renderproduct.js --- |
|
(0102448) marvintm (viewer) 2018-02-15 17:49 |
The fix is not correct. The reason we also put the "box" image after the main product image is that in some cases, the product image may be missing because the user forgot to run the "Generate Product Images" process. In this case, the "box" image should appear, and after the fix, an empty square is shown instead. |
|
(0102494) hgbot (developer) 2018-02-19 16:26 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 88db201add1ad14ebfcbe60da108df0788f5f9e2 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Thu Feb 15 15:32:15 2018 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88db201add1ad14ebfcbe60da108df0788f5f9e2 [^] Related to issue 37307: Thumbnail images are now properly loaded --- M web/org.openbravo.retail.posterminal/js/components/renderproduct.js --- |
|
(0102857) marvintm (viewer) 2018-02-27 18:17 |
The last change doesn't seem to work correctly. If I set the preference and then run the process, and then access the WebPOS, the products which do not have specific image are shown as an empty, white square, instead of the usual "brown" generic box. This is not correct, the empty brown box should be shown if the product doesn't have specific image. Additionally, failed requests are done for those products. This should also be avoided, otherwise in customers with a heavy load of requests to the images files it would result in a very significant increase in useless consumed bandwidth. |
|
(0103503) hgbot (developer) 2018-03-26 14:07 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ae7ebcb5ca9ed6002c7cd4ff29a395b9a4d1b857 Author: Gorka Gil <gorka.gil <at> openbravo.com> Date: Fri Mar 16 17:53:32 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae7ebcb5ca9ed6002c7cd4ff29a395b9a4d1b857 [^] Related to issue 37307: Backed out changeset 88db201add1a --- M web/org.openbravo.retail.posterminal/js/components/renderproduct.js --- |
|
(0103504) hgbot (developer) 2018-03-26 14:07 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e9374a7e6f904ea73c8c71f48af100e1b419811f Author: Gorka Gil <gorka.gil <at> openbravo.com> Date: Mon Mar 19 18:59:42 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e9374a7e6f904ea73c8c71f48af100e1b419811f [^] Related to issue 37307: Backed out changeset c5bd79531fd6 --- M web/org.openbravo.retail.posterminal/js/components/renderproduct.js --- |
|
(0105093) gorka_gil (administrator) 2018-06-12 13:14 |
Added attachment proposal-fix-not-complete.hg , that try to fix the image in the browse list, in the edit window and in the window that opens when adding for example the product "Multi-tool". The solution still is not totally finish or tested. Needs to be reviewed. Adding here the attachment to not lost the changes. |
|
(0105124) javierRodriguez (viewer) 2018-06-13 12:47 |
Looks like proposal-fix-not-complete.hg fix the problem. |
|
(0105142) hgbot (developer) 2018-06-14 13:44 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: c77ba5d5024542782c4b0721788a2a0fc26d28c9 Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com> Date: Thu Jun 14 13:44:01 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c77ba5d5024542782c4b0721788a2a0fc26d28c9 [^] Fixes issue 37307: will try to load the product image and if fail will load the box image --- M web/org.openbravo.retail.posterminal/css/obpos-main.css M web/org.openbravo.retail.posterminal/js/components/renderproduct.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/ps-productdetailsview.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-11-16 11:02 | JONHM | New Issue | |
| 2017-11-16 11:02 | JONHM | Assigned To | => Retail |
| 2017-11-16 11:02 | JONHM | File Added: Screenshot from 2017-11-16 10-49-27.png | |
| 2017-11-16 11:02 | JONHM | OBNetwork customer | => Yes |
| 2017-11-16 11:02 | JONHM | Support ticket | => 49446 |
| 2017-11-16 11:02 | JONHM | Triggers an Emergency Pack | => No |
| 2017-11-16 11:02 | JONHM | File Deleted: Screenshot from 2017-11-16 10-49-27.png | |
| 2017-11-16 11:02 | JONHM | File Added: Screenshot from 2017-11-16 10-49-27.png | |
| 2017-11-16 11:02 | JONHM | File Added: test7.png | |
| 2017-11-16 11:02 | JONHM | File Deleted: test7.png | |
| 2017-11-16 11:02 | JONHM | File Deleted: Screenshot from 2017-11-16 10-49-27.png | |
| 2017-11-16 11:03 | JONHM | File Added: test7.png | |
| 2017-11-16 11:03 | JONHM | File Deleted: test7.png | |
| 2017-11-16 11:03 | JONHM | File Added: Screenshot from 2017-11-16 10-49-27.png | |
| 2017-11-16 11:03 | JONHM | File Added: test7.png | |
| 2017-11-16 11:04 | JONHM | Steps to Reproduce Updated | View Revisions |
| 2017-11-16 11:30 | Practics | Issue Monitored: Practics | |
| 2018-02-07 15:20 | hgbot | Checkin | |
| 2018-02-07 15:20 | hgbot | Note Added: 0102255 | |
| 2018-02-07 15:20 | hgbot | Status | new => resolved |
| 2018-02-07 15:20 | hgbot | Resolution | open => fixed |
| 2018-02-07 15:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f74cd732abca0bfff4d1176d6afe2f3ba2a694e8 [^] |
| 2018-02-07 16:54 | hgbot | Checkin | |
| 2018-02-07 16:54 | hgbot | Note Added: 0102260 | |
| 2018-02-07 17:31 | marvintm | Assigned To | Retail => alekosmp86 |
| 2018-02-08 16:12 | hgbot | Checkin | |
| 2018-02-08 16:12 | hgbot | Note Added: 0102274 | |
| 2018-02-08 16:12 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f74cd732abca0bfff4d1176d6afe2f3ba2a694e8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c5bd79531fd637afbedee9c500229fa1420dc6b1 [^] |
| 2018-02-15 17:49 | marvintm | Note Added: 0102448 | |
| 2018-02-15 17:49 | marvintm | Status | resolved => new |
| 2018-02-15 17:49 | marvintm | Resolution | fixed => open |
| 2018-02-19 16:26 | hgbot | Checkin | |
| 2018-02-19 16:26 | hgbot | Note Added: 0102494 | |
| 2018-02-20 09:23 | marvintm | Status | new => scheduled |
| 2018-02-20 09:23 | marvintm | Status | scheduled => resolved |
| 2018-02-20 09:23 | marvintm | Resolution | open => fixed |
| 2018-02-27 18:17 | marvintm | Note Added: 0102857 | |
| 2018-02-27 18:17 | marvintm | Status | resolved => new |
| 2018-02-27 18:17 | marvintm | Resolution | fixed => open |
| 2018-03-16 17:40 | gorka_gil | Assigned To | alekosmp86 => gorka_gil |
| 2018-03-26 14:07 | hgbot | Checkin | |
| 2018-03-26 14:07 | hgbot | Note Added: 0103503 | |
| 2018-03-26 14:07 | hgbot | Checkin | |
| 2018-03-26 14:07 | hgbot | Note Added: 0103504 | |
| 2018-06-12 13:08 | gorka_gil | File Added: proposal-fix-not-complete.hg | |
| 2018-06-12 13:14 | gorka_gil | Note Added: 0105093 | |
| 2018-06-13 12:47 | javierRodriguez | Note Added: 0105124 | |
| 2018-06-14 13:44 | hgbot | Checkin | |
| 2018-06-14 13:44 | hgbot | Note Added: 0105142 | |
| 2018-06-14 13:44 | hgbot | Status | new => resolved |
| 2018-06-14 13:44 | hgbot | Resolution | open => fixed |
| 2018-06-14 13:44 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c5bd79531fd637afbedee9c500229fa1420dc6b1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c77ba5d5024542782c4b0721788a2a0fc26d28c9 [^] |
| 2018-06-25 08:31 | marvintm | Review Assigned To | => marvintm |
| 2018-06-25 08:31 | marvintm | Status | resolved => closed |
| 2018-06-25 08:31 | marvintm | Fixed in Version | => RR18Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |