Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037187
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSminoralways2017-10-30 14:162018-03-27 17:49
ReporterdbazView Statuspublic 
Assigned Togorka_gil 
PriorityhighResolutionfixedFixed in VersionRR18Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR18Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037187: [UX] Low-res PNG files should be replaced by vectorial SVG images

DescriptionIn the last few years, so many devices have arised having Hi-DPi screens. For these screens icons with higher resolutions or vectorial ones are needed in order to avoid blurry graphics.
With our mobile platform, this topic is especially sensitive, since our interface size adapts to fill the whole browser area.

AWO and SCO already include svg vectorial icons to ensure they look nicely in devices having any size/dpi

WebPOS still have low-res png icons that should be replaced with proper svg ones.

Note: This only affects to icons. It do not affect to images displaying pictures.
Steps To Reproduce.
Proposed SolutionI attach diffs for org.openbravo.mobile.core and org.openbravo.retail.posterminal.
With them, it adds svg icons for most of the icons used in WebPOS. There are still some missing (complementary products, ...) but this are not needed at this time, because a new design is needed (it will be reported separetely).

Note: In the diffs new svg files are added, but the counterpart png files are not erased. They need to be erased too, but only after confirm that the file with the png extension is not used in any other module of the mobile ecosystem.
TagsNo tags attached.
Attached Filesdiff file icon org.openbravo.mobile.core.diff [^] (48,152 bytes) 2017-10-30 14:16 [Show Content]
diff file icon org.openbravo.retail.posterminal.diff [^] (11,576 bytes) 2017-10-30 14:16 [Show Content]
diff file icon pending.org.openbravo.mobile.core.diff [^] (12,436 bytes) 2018-01-29 13:36 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0037654 closedjorge-garcia Performance improvements in "login including update" 
related to defect 0038317 closedgorka_gil Issue 37187 change some png's to svg's but miss to delete some png's 
related to backport 0038318RR18Q2 closedgorka_gil Issue 37187 change some png's to svg's but miss to delete some png's 
related to defect 0038417 closedgorka_gil API Change: removed some png's files 

-  Notes
(0102003)
hgbot (developer)
2018-01-26 15:33

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9063b2204ad3cf89fe0fedf53c698dc4fb93e811
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Jan 22 15:33:08 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9063b2204ad3cf89fe0fedf53c698dc4fb93e811 [^]

Related to issue 37187: Low-res PNG files are replaced by vectorial SVG images

---
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/css/pos-login.css
M web/org.openbravo.retail.posterminal/js/components/modalselectopenreceipts.js
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/components/renderproduct.js
A web/org.openbravo.retail.posterminal/img/iconBestsellerSmall.svg
A web/org.openbravo.retail.posterminal/img/iconInvoicingAddress.svg
A web/org.openbravo.retail.posterminal/img/iconPinSelected.svg
A web/org.openbravo.retail.posterminal/img/iconPinUnselected.svg
A web/org.openbravo.retail.posterminal/img/iconShippingAddress.svg
---
(0102004)
hgbot (developer)
2018-01-26 15:34

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 963525955eaebe307bd11b12183668a00fbdc4ea
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Jan 22 15:32:49 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/963525955eaebe307bd11b12183668a00fbdc4ea [^]

Related to issue 37187: Low-res PNG files are replaced by vectorial SVG images

---
M web/org.openbravo.mobile.core/assets/css/ob-login.css
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
A web/org.openbravo.mobile.core/assets/img/BACKGROUND-InDevelopment.svg
A web/org.openbravo.mobile.core/assets/img/BACKGROUND.svg
A web/org.openbravo.mobile.core/assets/img/OBLogo-small.svg
A web/org.openbravo.mobile.core/assets/img/checkbox-alt-half-on.svg
A web/org.openbravo.mobile.core/assets/img/checkbox-alt-on.svg
A web/org.openbravo.mobile.core/assets/img/checkbox-half-on.svg
A web/org.openbravo.mobile.core/assets/img/checkbox-off.svg
A web/org.openbravo.mobile.core/assets/img/checkbox-on.svg
A web/org.openbravo.mobile.core/assets/img/iconAwayUser.svg
A web/org.openbravo.mobile.core/assets/img/iconBackspace.svg
A web/org.openbravo.mobile.core/assets/img/iconCheck.svg
A web/org.openbravo.mobile.core/assets/img/iconClear.svg
A web/org.openbravo.mobile.core/assets/img/iconClearPayment.svg
A web/org.openbravo.mobile.core/assets/img/iconCreateNew-alt.svg
A web/org.openbravo.mobile.core/assets/img/iconCreateNew.svg
A web/org.openbravo.mobile.core/assets/img/iconDelete.svg
A web/org.openbravo.mobile.core/assets/img/iconDropdownArrow.svg
A web/org.openbravo.mobile.core/assets/img/iconEdit.svg
A web/org.openbravo.mobile.core/assets/img/iconEnter.svg
A web/org.openbravo.mobile.core/assets/img/iconMenu.svg
A web/org.openbravo.mobile.core/assets/img/iconOffline.svg
A web/org.openbravo.mobile.core/assets/img/iconOfflineUser.svg
A web/org.openbravo.mobile.core/assets/img/iconOnline.svg
A web/org.openbravo.mobile.core/assets/img/iconSearch.svg
A web/org.openbravo.mobile.core/assets/img/iconSelectorRemove.svg
A web/org.openbravo.mobile.core/assets/img/iconSelectorSortAscending.svg
A web/org.openbravo.mobile.core/assets/img/iconSelectorSortDescending.svg
A web/org.openbravo.mobile.core/assets/img/iconSelectorSortDisabled.svg
A web/org.openbravo.mobile.core/assets/img/radio-off.svg
A web/org.openbravo.mobile.core/assets/img/radio-on.svg
R web/org.openbravo.mobile.core/assets/img/BACKGROUND-InDevelopment.png
R web/org.openbravo.mobile.core/assets/img/OBLogo-small.png
R web/org.openbravo.mobile.core/assets/img/checkbox-alt-half-on.png
R web/org.openbravo.mobile.core/assets/img/checkbox-alt-on.png
R web/org.openbravo.mobile.core/assets/img/checkbox-half-on.png
R web/org.openbravo.mobile.core/assets/img/checkbox-off.png
R web/org.openbravo.mobile.core/assets/img/checkbox-on.png
R web/org.openbravo.mobile.core/assets/img/iconBackspace.png
R web/org.openbravo.mobile.core/assets/img/iconCheck.png
R web/org.openbravo.mobile.core/assets/img/iconClear.png
R web/org.openbravo.mobile.core/assets/img/iconClearPayment.png
R web/org.openbravo.mobile.core/assets/img/iconCreateNew-alt.png
R web/org.openbravo.mobile.core/assets/img/iconCreateNew.png
R web/org.openbravo.mobile.core/assets/img/iconDelete.png
R web/org.openbravo.mobile.core/assets/img/iconDropdownArrow.png
R web/org.openbravo.mobile.core/assets/img/iconEdit.png
R web/org.openbravo.mobile.core/assets/img/iconEnter.png
R web/org.openbravo.mobile.core/assets/img/iconMenu.png
R web/org.openbravo.mobile.core/assets/img/iconOffline.png
R web/org.openbravo.mobile.core/assets/img/iconOnline.png
R web/org.openbravo.mobile.core/assets/img/iconSelectorRemove.png
R web/org.openbravo.mobile.core/assets/img/iconSelectorSortAscending.png
R web/org.openbravo.mobile.core/assets/img/iconSelectorSortDescending.png
R web/org.openbravo.mobile.core/assets/img/iconSelectorSortDisabled.png
R web/org.openbravo.mobile.core/assets/img/radio-off.png
R web/org.openbravo.mobile.core/assets/img/radio-on.png
---
(0102005)
hgbot (developer)
2018-01-26 15:37

Repository: erp/pmods/org.openbravo.mobile.warehouse.physicalinventory
Changeset: 6ec38fd4e538e96c0e3646f6ba8ca774bcf6b431
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Jan 25 15:06:59 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse.physicalinventory/rev/6ec38fd4e538e96c0e3646f6ba8ca774bcf6b431 [^]

Related to issue 37187: Low-res PNG files are replaced by vectorial SVG images

---
M web/org.openbravo.mobile.warehouse.physicalinventory/assets/pi-styles.css
---
(0102007)
marvintm (manager)
2018-01-29 09:26

It seems the encoding of the files is not correct, for example in BACKGROUND-InDevelopment.svg, when looking at the diff, I see "^M" characters, which normally happen if the file was edited in Windows and not saved using proper encoding with correct line breaks. Please review them.
(0102021)
dbaz (developer)
2018-01-29 13:37

I have just attached also to the issue the diff

pending.org.openbravo.mobile.core

which includes 6 new icons in svg format not present in the previous diff.
(0103324)
gorka_gil (administrator)
2018-03-16 16:54
edited on: 2018-03-19 18:52

Although the diff contains ^M , looks like patch process it correctly and resulting files don't contain the ^M.

-- Edit: Checked incorrectly, the files pushed to repos still contains the ^M. Fixed with dos2unix command.

(0103366)
hgbot (developer)
2018-03-20 10:34

Repository: tools/automation/pi-mobile
Changeset: 482f8426de04adf22d8533ba56c43107dfe982b4
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Mar 19 17:46:30 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/482f8426de04adf22d8533ba56c43107dfe982b4 [^]

Related to issue 37187: now body_image control is called modalsearchfilterbuilder_body_control2

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
---
(0103367)
hgbot (developer)
2018-03-20 10:35

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 41026125677a20ea6f2497e6129acb57468b7f4b
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Mar 19 13:21:03 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/41026125677a20ea6f2497e6129acb57468b7f4b [^]

Related to issue 37187: Low-res PNG files are replaced by vectorial SVG images

added the pending.org.openbravo.mobile.core.diff

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-filterbuilder.js
A web/org.openbravo.mobile.core/assets/img/iconAdd.svg
A web/org.openbravo.mobile.core/assets/img/iconRFIDOFF.svg
A web/org.openbravo.mobile.core/assets/img/iconRFIDON.svg
A web/org.openbravo.mobile.core/assets/img/iconRFIDOffline.svg
A web/org.openbravo.mobile.core/assets/img/iconSwitchOFF.svg
A web/org.openbravo.mobile.core/assets/img/iconSwitchON.svg
A web/org.openbravo.mobile.core/assets/img/iconSwitchOffline.svg
A web/org.openbravo.mobile.core/assets/img/inspectTree.svg
R web/org.openbravo.mobile.core/assets/img/iconAdd.png
R web/org.openbravo.mobile.core/assets/img/iconRFIDOFF.png
R web/org.openbravo.mobile.core/assets/img/iconRFIDON.png
R web/org.openbravo.mobile.core/assets/img/iconRFIDOffline.png
R web/org.openbravo.mobile.core/assets/img/iconSwitchOFF.png
R web/org.openbravo.mobile.core/assets/img/iconSwitchON.png
R web/org.openbravo.mobile.core/assets/img/iconSwitchOffline.png
R web/org.openbravo.mobile.core/assets/img/inspectTree.png
---
(0103368)
hgbot (developer)
2018-03-20 10:35

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0444e18bd726f84617ea593e6aacd31dc6822474
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Mar 19 13:32:21 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0444e18bd726f84617ea593e6aacd31dc6822474 [^]

Related to issue 37187: fix svg files line endings ^M

---
M web/org.openbravo.mobile.core/assets/img/BACKGROUND-InDevelopment.svg
M web/org.openbravo.mobile.core/assets/img/BACKGROUND.svg
M web/org.openbravo.mobile.core/assets/img/OBLogo-small.svg
M web/org.openbravo.mobile.core/assets/img/checkbox-alt-half-on.svg
M web/org.openbravo.mobile.core/assets/img/checkbox-alt-on.svg
M web/org.openbravo.mobile.core/assets/img/checkbox-half-on.svg
M web/org.openbravo.mobile.core/assets/img/checkbox-off.svg
M web/org.openbravo.mobile.core/assets/img/checkbox-on.svg
M web/org.openbravo.mobile.core/assets/img/iconAwayUser.svg
M web/org.openbravo.mobile.core/assets/img/iconBackspace.svg
M web/org.openbravo.mobile.core/assets/img/iconCheck.svg
M web/org.openbravo.mobile.core/assets/img/iconClear.svg
M web/org.openbravo.mobile.core/assets/img/iconClearPayment.svg
M web/org.openbravo.mobile.core/assets/img/iconCreateNew-alt.svg
M web/org.openbravo.mobile.core/assets/img/iconCreateNew.svg
M web/org.openbravo.mobile.core/assets/img/iconDelete.svg
M web/org.openbravo.mobile.core/assets/img/iconDropdownArrow.svg
M web/org.openbravo.mobile.core/assets/img/iconEdit.svg
M web/org.openbravo.mobile.core/assets/img/iconEnter.svg
M web/org.openbravo.mobile.core/assets/img/iconMenu.svg
M web/org.openbravo.mobile.core/assets/img/iconOffline.svg
M web/org.openbravo.mobile.core/assets/img/iconOfflineUser.svg
M web/org.openbravo.mobile.core/assets/img/iconOnline.svg
M web/org.openbravo.mobile.core/assets/img/iconSearch.svg
M web/org.openbravo.mobile.core/assets/img/iconSelectorRemove.svg
M web/org.openbravo.mobile.core/assets/img/iconSelectorSortAscending.svg
M web/org.openbravo.mobile.core/assets/img/iconSelectorSortDescending.svg
M web/org.openbravo.mobile.core/assets/img/iconSelectorSortDisabled.svg
M web/org.openbravo.mobile.core/assets/img/radio-off.svg
M web/org.openbravo.mobile.core/assets/img/radio-on.svg
---
(0103369)
hgbot (developer)
2018-03-20 10:35

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0f7354ee48c10f9439d90e48f70e79e4073e1e46
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Mar 19 13:30:04 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0f7354ee48c10f9439d90e48f70e79e4073e1e46 [^]

Related to issue 37187: fix svg files line endings ^M

---
M web/org.openbravo.retail.posterminal/img/iconBestsellerSmall.svg
M web/org.openbravo.retail.posterminal/img/iconInvoicingAddress.svg
M web/org.openbravo.retail.posterminal/img/iconPinSelected.svg
M web/org.openbravo.retail.posterminal/img/iconPinUnselected.svg
M web/org.openbravo.retail.posterminal/img/iconShippingAddress.svg
---
(0103434)
hgbot (developer)
2018-03-22 16:35

Repository: tools/automation/pi-mobile
Changeset: 804ce3e342fa0d57141ea0f691259767383faecf
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Mar 22 16:33:37 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/804ce3e342fa0d57141ea0f691259767383faecf [^]

Related to issue 37187: review: set name to enyo component of button add

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
---
(0103435)
hgbot (developer)
2018-03-22 16:35

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 543dd2f3405afd855b866933a8cca630c85ac328
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Mar 22 16:34:16 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/543dd2f3405afd855b866933a8cca630c85ac328 [^]

Related to issue 37187: review: set name to enyo component of button add

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-filterbuilder.js
---

- Issue History
Date Modified Username Field Change
2017-10-30 14:16 dbaz New Issue
2017-10-30 14:16 dbaz Assigned To => Retail
2017-10-30 14:16 dbaz Triggers an Emergency Pack => No
2017-10-30 14:16 dbaz File Added: org.openbravo.mobile.core.diff
2017-10-30 14:16 dbaz File Added: org.openbravo.retail.posterminal.diff
2018-01-26 15:33 hgbot Checkin
2018-01-26 15:33 hgbot Note Added: 0102003
2018-01-26 15:34 hgbot Checkin
2018-01-26 15:34 hgbot Note Added: 0102004
2018-01-26 15:37 hgbot Checkin
2018-01-26 15:37 hgbot Note Added: 0102005
2018-01-29 09:26 marvintm Note Added: 0102007
2018-01-29 13:36 dbaz File Added: pending.org.openbravo.mobile.core.diff
2018-01-29 13:37 dbaz Note Added: 0102021
2018-03-08 13:44 jorge-garcia Relationship added related to 0037654
2018-03-16 16:54 gorka_gil Note Added: 0103324
2018-03-16 16:54 gorka_gil Assigned To Retail => gorka_gil
2018-03-19 18:52 gorka_gil Note Edited: 0103324 View Revisions
2018-03-20 10:34 hgbot Checkin
2018-03-20 10:34 hgbot Note Added: 0103366
2018-03-20 10:35 hgbot Checkin
2018-03-20 10:35 hgbot Note Added: 0103367
2018-03-20 10:35 hgbot Checkin
2018-03-20 10:35 hgbot Note Added: 0103368
2018-03-20 10:35 hgbot Checkin
2018-03-20 10:35 hgbot Note Added: 0103369
2018-03-20 10:39 gorka_gil Status new => scheduled
2018-03-20 10:39 gorka_gil Status scheduled => resolved
2018-03-20 10:39 gorka_gil Resolution open => fixed
2018-03-20 10:41 gorka_gil Target Version => RR18Q2
2018-03-22 16:35 hgbot Checkin
2018-03-22 16:35 hgbot Note Added: 0103434
2018-03-22 16:35 hgbot Checkin
2018-03-22 16:35 hgbot Note Added: 0103435
2018-03-27 17:49 marvintm Review Assigned To => marvintm
2018-03-27 17:49 marvintm Status resolved => closed
2018-03-27 17:49 marvintm Fixed in Version => RR18Q2
2018-04-10 18:34 gorka_gil Relationship added related to 0038317
2018-04-10 18:35 gorka_gil Relationship added related to 0038318
2018-04-19 17:48 gorka_gil Relationship added related to 0038417


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker