Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037114
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorsometimes2017-10-19 12:382017-11-17 14:16
Reporterjorge-garciaView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revision7c00d0acd0cd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037114: By total discounts should ignore discount priority and be calculated at the end

DescriptionBy total discounts should ignore discount priority and be calculated at the end
Steps To Reproduce1) Login in the WebPOS.
2) Apply a combo to the ticket.
3) Go to discounts entry menu and apply a Variable Discount per Total Amount promotion to all lines without checking overwrite Promotion.
4) Depending on priorities of both discount, it could happen the combo promotion is overwrite (and it should not).
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0034674 closedguillermogil Implement Manual discounts by Total 
related to defect 0037017 closedjorge-garcia Manual discounts with priorities are generating an error 
related to defect 0037260 closedrqueralta Combos and Pack are not working properly in some cases 

-  Notes
(0099962)
hgbot (developer)
2017-10-19 12:44

 Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 8ab3d80bdbeca2bc9c576d04fe45bd83b8682bd1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Oct 19 12:26:57 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/8ab3d80bdbeca2bc9c576d04fe45bd83b8682bd1 [^]

Fixed issue 37114: By total discounts should ignore discount priority
and be calculated at the end

All discounts by total should be moved at the end of discount array
list to be calculated at the end of the process.

This is done using preApplyAutomaticDiscount hook.

---
M src/org/openbravo/retail/discounts/bytotal/DiscTComponentProvider.java
A web/org.openbravo.retail.discounts.bytotal/js/preApplyAutomaticDiscountHook.js
---
(0100051)
hgbot (developer)
2017-10-25 11:52

 Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: cacd593b7d7f15b2f4f98cade26eae7ff3d6fa1d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 25 11:37:10 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/cacd593b7d7f15b2f4f98cade26eae7ff3d6fa1d [^]

Related to issue 37114: By total discounts should ignore discount priority
and be calculated at the end

Manual by total discount should replace previous manual by total discounts.

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---
(0100062)
hgbot (developer)
2017-10-25 15:05

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8a17462fb22e24e969df8d776c46d0d6f79ae527
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 25 11:39:33 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8a17462fb22e24e969df8d776c46d0d6f79ae527 [^]

Fixed issue 37114: By total discounts should ignore discount priority
and be calculated at the end

Attribute idx indicates the priority in which the promotions should be
calculated. It’s necessary this order is calculated after
preApplyDiscountsHook.

The units consumed by other promotions should be smarter.

---
M web/org.openbravo.retail.posterminal/js/model/executor.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0100063)
hgbot (developer)
2017-10-25 15:06

 Repository: tools/automation/pi-mobile
Changeset: faf758ac09db320a85ec2ae295c568884bdf214f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 25 11:40:26 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/faf758ac09db320a85ec2ae295c568884bdf214f [^]

Related to issue 37114: By total discounts should ignore discount priority
and be calculated at the end

test should be changed to work properly.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoFreeProdScaledPriceAndManualPromo.java
---
(0100322)
hgbot (developer)
2017-11-08 08:34

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 8fd670d804e00ef27dcab28246ee77461de84b5e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 07 17:51:13 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/8fd670d804e00ef27dcab28246ee77461de84b5e [^]

Related to issue 37114: By total discounts should ignore discount priority and
be calculated at the end

Change combo implementation to check the number of units available to apply
the promotion using the new receipt API ccheckAvailableUnitsPerLine.

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0100323)
hgbot (developer)
2017-11-08 08:35

 Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: d1f9bea443f073b98c4afd2bafc9bb26281ab4aa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 07 17:52:31 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/d1f9bea443f073b98c4afd2bafc9bb26281ab4aa [^]

Related to issue 37114: By total discounts should ignore discount priority and
be calculated at the end

By total discounts are applied at the end, and even they are set to not apply in
cascade, they should not consume units.

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---
(0100353)
hgbot (developer)
2017-11-08 15:52

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7c00d0acd0cdc071346648f4af08cf64ed78985c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 07 17:56:07 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7c00d0acd0cdc071346648f4af08cf64ed78985c [^]

Fixed issue 37114: By total discounts should ignore discount priority and
be calculated at the end

The priority old code could cause some performance problems in the
webPOS, including a maximum callstack (infinite loop). This code has
been removed.

Added a new API to check the number of units available per line.

Improve addPromotion logic.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0100354)
hgbot (developer)
2017-11-08 15:53

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 72f2a61d39fbd84909681077b27c2b7f769a8376
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Nov 07 17:53:51 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/72f2a61d39fbd84909681077b27c2b7f769a8376 [^]

Related to issue 37114: By total discounts should ignore discount priority and
be calculated at the end

Change pack implementation to use the new API to check the available units
per line.

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0100355)
hgbot (developer)
2017-11-08 15:53

 Repository: tools/automation/pi-mobile
Changeset: 48fc3af3456455e51550ab5a35d0730f2641631c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Nov 08 11:55:30 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/48fc3af3456455e51550ab5a35d0730f2641631c [^]

Related to issue 37114: By total discounts should ignore discount priority and
be calculated at the end

Change tests to adapt to the new functionality.

Added new testIds for the tests.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I34809_WrongCalculationOfComboDependingSequence.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I33201_VerifyPackCombinedWithManualPromotions.java
---

- Issue History
Date Modified Username Field Change
2017-10-19 12:38 jorge-garcia New Issue
2017-10-19 12:38 jorge-garcia Assigned To => jorge-garcia
2017-10-19 12:38 jorge-garcia OBNetwork customer => No
2017-10-19 12:38 jorge-garcia Triggers an Emergency Pack => No
2017-10-19 12:38 jorge-garcia Relationship added related to 0034674
2017-10-19 12:38 jorge-garcia Status new => scheduled
2017-10-19 12:44 hgbot Checkin
2017-10-19 12:44 hgbot Note Added: 0099962
2017-10-19 12:44 hgbot Status scheduled => resolved
2017-10-19 12:44 hgbot Resolution open => fixed
2017-10-19 12:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/8ab3d80bdbeca2bc9c576d04fe45bd83b8682bd1 [^]
2017-10-24 16:26 jorge-garcia Relationship added related to 0037017
2017-10-25 11:52 hgbot Checkin
2017-10-25 11:52 hgbot Note Added: 0100051
2017-10-25 15:05 hgbot Checkin
2017-10-25 15:05 hgbot Note Added: 0100062
2017-10-25 15:05 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/8ab3d80bdbeca2bc9c576d04fe45bd83b8682bd1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8a17462fb22e24e969df8d776c46d0d6f79ae527 [^]
2017-10-25 15:06 hgbot Checkin
2017-10-25 15:06 hgbot Note Added: 0100063
2017-11-08 08:34 hgbot Checkin
2017-11-08 08:34 hgbot Note Added: 0100322
2017-11-08 08:35 hgbot Checkin
2017-11-08 08:35 hgbot Note Added: 0100323
2017-11-08 12:38 jorge-garcia Relationship added related to 0037260
2017-11-08 15:52 hgbot Checkin
2017-11-08 15:52 hgbot Note Added: 0100353
2017-11-08 15:52 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8a17462fb22e24e969df8d776c46d0d6f79ae527 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7c00d0acd0cdc071346648f4af08cf64ed78985c [^]
2017-11-08 15:53 hgbot Checkin
2017-11-08 15:53 hgbot Note Added: 0100354
2017-11-08 15:53 hgbot Checkin
2017-11-08 15:53 hgbot Note Added: 0100355
2017-11-13 18:24 Practics Issue Monitored: Practics
2017-11-17 14:16 marvintm Review Assigned To => marvintm
2017-11-17 14:16 marvintm Status resolved => closed
2017-11-17 14:16 marvintm Fixed in Version => RR18Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker