Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037080
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2017-10-16 18:172018-03-06 18:44
ReportermigueldejuanaView Statuspublic 
Assigned Tojorge-garcia 
PrioritynormalResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revision0722d188e2dc
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037080: addPaidReceipt function do not finish when ob.dal.save fails (remains locked)

DescriptionIf addPaidReceipt gives an error doing "OB.Dal.save(model" SynchronizationHelper remains busy because it is never finished in the SynchronizationHelper.

If we do not finish an action, the SynchronizationHelper gets locked(this.isLocked === true) and Done button is disabled forever.
Steps To Reproduce- Login Web POS
- Open Layaways modal and load one
- Make this save fail: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/88b97ce3fcd9/web/org.openbravo.retail.posterminal/js/model/order.js#l5180 [^]
- We do not Synchronization when failing: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/88b97ce3fcd9/web/org.openbravo.retail.posterminal/js/model/order.js#l5184 [^]
Proposed SolutionAdd these lines:

    enyo.$.scrim.hide();
    OB.UTIL.SynchronizationHelper.finished(synchId, 'addPaidReceipt');

before:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/88b97ce3fcd9/web/org.openbravo.retail.posterminal/js/model/order.js#l5184 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0099928)
hgbot (developer)
2017-10-17 16:04

 Repository: erp/pmods/org.openbravo.retail.scanreceipt
Changeset: 18b563ea421cb518bff43270e47d94f9473fd64a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 17 15:46:49 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.scanreceipt/rev/18b563ea421cb518bff43270e47d94f9473fd64a [^]

Fixed issue 37080: addPaidReceipt function do not finish when ob.dal.save
fails (remains locked)

The solution proposed is to sequentially load scanned receipts, waiting until
the receipt is fully loaded (shown in the UI and recalculated).

---
M web/org.openbravo.retail.scanreceipt/js/OBSRUtils.js
---
(0099932)
hgbot (developer)
2017-10-18 09:05

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 25fb161fe29739286e42041111c39f2e3eeaea1d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Oct 17 15:48:24 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/25fb161fe29739286e42041111c39f2e3eeaea1d [^]

Related to issue 37080: addPaidReceipt function do not finish when ob.dal.save
fails (remains locked)

The function addPaidReceipt need to execute a callback. This is needed to
avoid execution in parallel of the function.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0100034)
migueldejuana (viewer)
2017-10-24 16:03

 Tests following flows:

- Scan a layaway twice very fast
- Scan 2 layaways very fasta
- Scan 2 related layaways. When scanning first layaway, a modal will show "Do you want to load related receipts?" Do not select any option in the modal an scan another layaway.

Ensure that this 3 cases do not give a js error. You also can check if SynchronizationHelper has finished all requests.
(0102529)
hgbot (developer)
2018-02-20 15:00

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0722d188e2dc9681b832dcef85a8a3904df6937f
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Tue Oct 24 10:58:03 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0722d188e2dc9681b832dcef85a8a3904df6937f [^]

Fixed issue 37080: addPaidReceipt function do not finish when ob.dal.save
fails (remains locked)

The solution proposed is to sequentially load scanned receipts, waiting until
the receipt is fully loaded (shown in the UI and recalculated).

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/orderSelectorUtils.js
---

- Issue History
Date Modified Username Field Change
2017-10-16 18:17 migueldejuana New Issue
2017-10-16 18:17 migueldejuana Assigned To => Retail
2017-10-16 18:17 migueldejuana OBNetwork customer => No
2017-10-16 18:17 migueldejuana Triggers an Emergency Pack => No
2017-10-17 16:04 hgbot Checkin
2017-10-17 16:04 hgbot Note Added: 0099928
2017-10-17 16:04 hgbot Status new => resolved
2017-10-17 16:04 hgbot Resolution open => fixed
2017-10-17 16:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.scanreceipt/rev/18b563ea421cb518bff43270e47d94f9473fd64a [^]
2017-10-17 17:23 jorge-garcia Assigned To Retail => jorge-garcia
2017-10-18 09:05 hgbot Checkin
2017-10-18 09:05 hgbot Note Added: 0099932
2017-10-24 16:03 migueldejuana Note Added: 0100034
2017-10-26 12:49 marvintm OBNetwork customer No => Yes
2017-10-26 12:49 marvintm Resolution time => 1509490800
2017-10-26 12:55 marvintm Review Assigned To => marvintm
2017-10-26 12:55 marvintm Status resolved => closed
2017-10-26 12:55 marvintm Fixed in Version => RR18Q1
2018-02-20 15:00 hgbot Checkin
2018-02-20 15:00 hgbot Note Added: 0102529
2018-02-20 15:00 hgbot Status closed => resolved
2018-02-20 15:00 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.scanreceipt/rev/18b563ea421cb518bff43270e47d94f9473fd64a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0722d188e2dc9681b832dcef85a8a3904df6937f [^]
2018-02-26 08:51 marvintm Resolution time 1509490800 =>
2018-03-06 18:44 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker