0037056: It is possible to get the mandatory services screen without any product added to the ticket

Description

Under specific circumstances, it is possible to have the mandatory services search open in web pos, after the original service has been removed from the ticket.
This can happen because the HasServices process and the calculateReceipt function are executed in parallel, and the calculateReceipt function may remove a line from the ticket (i.e. when taxes are not correctly configured) before the HasServices process finishes.

Steps To Reproduce

Backend configuration:
Configure the 'Enable Remote for Product' preference.
Go to the Tax Rate window, find the "Exportaciones (%N=>0%)" record and disable it.
Go to the Business Partner window, find the VBS Customer record, go to the Location/Address tab and change the country of the location to something different to Spain (i.e. change it to Sri Lanka)

Web POS:
Login in web pos
Go to the search tab
Open the browser console/devtools; on the network tab, enable throttling to fake a slow network (on the top side of the window, the rightmost option; Regular 2G should be enough).
In web pos, search the Blue Trousers product and add it to the ticket.
The "Cannot calculate receipt taxes" popup will be shown, and after that the mandatory services search will be shown.

Proposed Solution

When the HasServices process has finished (or when the websql query has finished if remote is not configured), check if the product line still exists in the ticket, and only then open the services search.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0099991) hgbot (developer) 2017-10-23 12:59	Repository: erp/pmods/org.openbravo.mobile.core Changeset: bc2cea98cbeaf04865305119ea32ae93f53ed58a Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Oct 23 16:16:57 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/bc2cea98cbeaf04865305119ea32ae93f53ed58a [^] Fixed issue 37056 : Show Mandatory services for line if it is exists receipt lines * If product with mandatory services is added, after calculateReceipt if product is removed due to some error, Mandatory services window should not be shown. --- M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js ---

Issue History
Date Modified	Username	Field	Change
2017-10-11 14:52	aaroncalero	New Issue
2017-10-11 14:52	aaroncalero	Assigned To	=> Retail
2017-10-11 14:52	aaroncalero	Resolution time	=> 1508882400
2017-10-11 14:52	aaroncalero	Triggers an Emergency Pack	=> No
2017-10-11 15:14	aaroncalero	Proposed Solution updated
2017-10-19 11:55	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2017-10-19 11:55	ranjith_qualiantech_com	Status	new => scheduled
2017-10-23 12:59	hgbot	Checkin
2017-10-23 12:59	hgbot	Note Added: 0099991
2017-10-23 12:59	hgbot	Status	scheduled => resolved
2017-10-23 12:59	hgbot	Resolution	open => fixed
2017-10-23 12:59	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/bc2cea98cbeaf04865305119ea32ae93f53ed58a [^]
2017-10-27 12:50	marvintm	Review Assigned To	=> marvintm
2017-10-27 12:50	marvintm	Status	resolved => closed
2017-10-27 12:50	marvintm	Fixed in Version	=> RR18Q1