Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036893
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorsometimes2017-09-19 16:032018-01-19 12:15
ReporterguillermogilView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revisiond61149f258b8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036893: If WebPOS is on Payment Tab it should not be possible to add products

DescriptionIf WebPOS is on Payment Tab it should not be possible to add products because it can rely on calculate receipt errors: "calculateReceipt execution is forbidden right now;"

While payment although RFID is deactivated if the computer is slow the product can be added after the payment is completed.
Steps To Reproduce* Login on WebPOS
* Add products
* Click total button
* With RFID add some product (e.g.- OB.UTIL.RfidController.sendTestEpc('303C000000A4DDC000000001') )

It should not be possible to do that.
It can rely on Calculate Receipt Errors.
Proposed SolutionOn addProduct function check if we are on payment window and return with an error on logs.
If it comes with EPC Code (RFID) it is needed to remove it from the buffer.

Also it should be required to stop the execution if we get and WebSocket call from RFID Device while WebPOS is on payment tab.
Again, it is needed to remove it from the buffer too.

if (ecpCode) {
  OB.UTIL.RfidController.removeEpc(epcCode);
}
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0036717 closedranjith_qualiantech_com WebPOS can finish a ticket without calculating all the lines 
causes defect 0037023 closedranjith_qualiantech_com Clicking on a generic product in the product browser raises a Javascript error 

-  Notes
(0099600)
hgbot (developer)
2017-09-26 16:53

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 18ec430a469bc50e4f0f39582aca8769d6a48bb4
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 25 16:53:18 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/18ec430a469bc50e4f0f39582aca8769d6a48bb4 [^]

Related to issue 36893: If WebPOS is on Payment Tab it should not be possible to
add products

Change addProductToOrder call to set property blockAddProduct to options.

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-product-browser.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproducts.js
---
(0099601)
hgbot (developer)
2017-09-26 16:53

 Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 719df07016cc119fd85015f69976f9e4ab8d2816
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 26 11:39:51 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/719df07016cc119fd85015f69976f9e4ab8d2816 [^]

Related to issue 36893: If WebPOS is on Payment Tab it should not be possible to
add products

Change addProductToOrder call to set property blockAddProduct to options.

Verify Return functionality has change to navigate to scan tab when the popup to
select paid receipts is shown.

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
M web/org.openbravo.retail.returns/js/returnReceiptButton.js
---
(0099602)
hgbot (developer)
2017-09-26 16:54

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 2dc2e9a51ac7eee2b02486076cfbb1ce70a7cf6f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 25 16:51:49 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/2dc2e9a51ac7eee2b02486076cfbb1ce70a7cf6f [^]

Related to issue 36893: If WebPOS is on Payment Tab it should not be possible to
add products

Change addProductToOrder call to set property blockAddProduct to options.

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0099603)
hgbot (developer)
2017-09-26 16:54

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0cf3e5d549d0155d587a5b51c355dde42f58a05c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 26 11:37:50 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0cf3e5d549d0155d587a5b51c355dde42f58a05c [^]

Fixed issue 36893: If WebPOS is on Payment Tab it should not be possible to
add products

In add product, now there is a check to verify the product could be added. The
exception to add a product is in the payment tab, for the products added in the
webPOS.

A new variable has been set to indicate if the webPOS is in the payment tab.

---
M web/org.openbravo.retail.posterminal/js/components/modalselectopenreceipts.js
M web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ps-productdetailsview.js
M web/org.openbravo.retail.posterminal/js/utils/rfidWebsocket.js
---
(0100047)
hgbot (developer)
2017-10-25 09:14

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b4c794026a96a628abba80b32b67f80956492b83
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Oct 23 12:59:04 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b4c794026a96a628abba80b32b67f80956492b83 [^]

Related to issue 36893: Add addtional checks to avoid add lines when ticket is being closed

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---

- Issue History
Date Modified Username Field Change
2017-09-19 16:03 guillermogil New Issue
2017-09-19 16:03 guillermogil Assigned To => Retail
2017-09-19 16:03 guillermogil Resolution time => 1507586400
2017-09-19 16:03 guillermogil Triggers an Emergency Pack => No
2017-09-19 16:04 guillermogil Relationship added related to 0036717
2017-09-25 17:05 jorge-garcia Status new => scheduled
2017-09-25 17:05 jorge-garcia Assigned To Retail => jorge-garcia
2017-09-26 16:53 hgbot Checkin
2017-09-26 16:53 hgbot Note Added: 0099600
2017-09-26 16:53 hgbot Checkin
2017-09-26 16:53 hgbot Note Added: 0099601
2017-09-26 16:54 hgbot Checkin
2017-09-26 16:54 hgbot Note Added: 0099602
2017-09-26 16:54 hgbot Checkin
2017-09-26 16:54 hgbot Note Added: 0099603
2017-09-26 16:54 hgbot Status scheduled => resolved
2017-09-26 16:54 hgbot Resolution open => fixed
2017-09-26 16:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0cf3e5d549d0155d587a5b51c355dde42f58a05c [^]
2017-09-28 10:25 marvintm Review Assigned To => marvintm
2017-09-28 10:25 marvintm Status resolved => closed
2017-09-28 10:25 marvintm Fixed in Version => RR17Q4
2017-10-24 13:34 ranjith_qualiantech_com Relationship added causes 0037023
2017-10-25 09:14 hgbot Checkin
2017-10-25 09:14 hgbot Note Added: 0100047
2018-01-19 12:08 hgbot Checkin
2018-01-19 12:08 hgbot Note Added: 0101781
2018-01-19 12:08 hgbot Status closed => resolved
2018-01-19 12:08 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0cf3e5d549d0155d587a5b51c355dde42f58a05c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8687c3aebeb893002b171d0f696ae540358ca0ff [^]
2018-01-19 12:13 hgbot Checkin
2018-01-19 12:13 hgbot Note Added: 0101783
2018-01-19 12:13 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8687c3aebeb893002b171d0f696ae540358ca0ff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d61149f258b8f73a8abda9dd265720369aeefba7 [^]
2018-01-19 12:15 marvintm Note Deleted: 0101781
2018-01-19 12:15 marvintm Note Deleted: 0101783
2018-01-19 12:15 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker