Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036789
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementmajoralways2017-09-05 13:082017-09-21 16:50
ReporterdmiguelezView Statuspublic 
Assigned Todmiguelez 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q4
StatusclosedFix in branchFixed in SCM revision4fa54a2fb83d
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036789: Issue in Oracle when comparing empty Strings in some PL's

DescriptionIn Oracle, the empty String comparison does not work as it does in Postgresql.
There are several PL's that have empty String comparisons that must be fixed.
In this Issue:
- M_INOUT_POST
- MA_WORKEFFORT_VALIDATE
- M_PRODUCTION_RUN
Steps To ReproduceIn Oracle, the empty String comparison does not work as it does in Postgresql.
There are several PL's that have empty String comparisons that must be fixed.
In this Issue:
- M_INOUT_POST
- MA_WORKEFFORT_VALIDATE
- M_PRODUCTION_RUN
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0098836)
dmiguelez (viewer)
2017-09-05 16:16

 Fixed in commit: https://code.openbravo.com/erp/devel/pi/rev/4fa54a2fb83d [^]
(0098858)
aferraz (viewer)
2017-09-06 09:18
edited on: 2017-09-06 09:22

 String comparison differences between PG and Oracle:

select count(1)
from dual
where null = '';
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where '' = '';
-- PG: 1
-- Oracle: 0

select count(1)
from dual
where 'a' = '';
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where null != '';
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where '' != '';
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where 'a' != '';
-- PG: 1
-- Oracle: 0

select count(1)
from dual
where null IS NULL;
-- PG: 1
-- Oracle: 1

select count(1)
from dual
where '' IS NULL;
-- PG: 0
-- Oracle: 1

select count(1)
from dual
where 'a' IS NULL;
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where null IS NOT NULL;
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where '' IS NOT NULL;
-- PG: 1
-- Oracle: 0

select count(1)
from dual
where 'a' IS NOT NULL;
-- PG: 1
-- Oracle: 1

select count(1)
from dual
where length(NULL) = 0;
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where length('') = 0;
-- PG: 1
-- Oracle: 0

select count(1)
from dual
where length('a') = 0;
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where length(NULL) > 0;
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where length('') > 0;
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where length('a') > 0;
-- PG: 1
-- Oracle: 1

select count(1)
from dual
where length(NULL) IS NULL;
-- PG: 1
-- Oracle: 1

select count(1)
from dual
where length('') IS NULL;
-- PG: 0
-- Oracle: 1

select count(1)
from dual
where length('a') IS NULL;
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where length(NULL) IS NOT NULL;
-- PG: 0
-- Oracle: 0

select count(1)
from dual
where length('') IS NOT NULL;
-- PG: 1
-- Oracle: 0

select count(1)
from dual
where length('a') IS NOT NULL;
-- PG: 1
-- Oracle: 1
(0099017)
hgbot (developer)
2017-09-13 21:30

 Repository: erp/devel/pi
Changeset: 3398cf233133ad97d5246265114d8e7c2864d466
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Sep 06 13:23:35 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3398cf233133ad97d5246265114d8e7c2864d466 [^]

Related to issue 36789: Code review improvements

Initialize variables with null instead of an empty string and then check if variable is not null.
Thus, we avoid problems in Oracle if we check if length('') = 0.
See: https://issues.openbravo.com/view.php?id=36789#c98858 [^]

---
M src-db/database/model/functions/MA_STANDARD_COST.xml
M src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
M src-db/database/model/functions/M_GET_OFFERS_NAME.xml
M src-db/database/model/functions/M_INOUT_POST.xml
M src-db/database/model/functions/M_PRODUCTION_RUN.xml
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0099018)
hgbot (developer)
2017-09-13 21:30

 Repository: erp/pmods/org.openbravo.interco
Changeset: 15c334a35cf8d02a8ea7e3bba5701efd7c097b2f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Sep 06 13:27:26 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.interco/rev/15c334a35cf8d02a8ea7e3bba5701efd7c097b2f [^]

Related to issue 36789: Avoid comparisons with empty string

---
M src-db/database/model/functions/INTERCO_CREATE_INVOICE.xml
M src-db/database/model/functions/INTERCO_CREATE_ORDER.xml
---
(0099019)
aferraz (viewer)
2017-09-13 21:31

 Code review + Testing OK
(0099137)
hgbot (developer)
2017-09-19 10:29

 Repository: erp/devel/pi
Changeset: 27a01d1d9bee46b0721dd58a8c6b12d78536667c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 19 10:28:14 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/27a01d1d9bee46b0721dd58a8c6b12d78536667c [^]

Related to issue 36789: Revert changes in AD_AUXILIARINPUT

---
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
---
(0099383)
hudsonbot (viewer)
2017-09-21 16:49

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099390)
hudsonbot (viewer)
2017-09-21 16:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test
(0099415)
hudsonbot (viewer)
2017-09-21 16:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-09-05 13:08 dmiguelez New Issue
2017-09-05 13:08 dmiguelez Assigned To => Triage Finance
2017-09-05 13:08 dmiguelez OBNetwork customer => No
2017-09-05 13:08 dmiguelez Modules => Core
2017-09-05 13:08 dmiguelez Triggers an Emergency Pack => No
2017-09-05 16:14 dmiguelez Status new => scheduled
2017-09-05 16:14 dmiguelez Assigned To Triage Finance => dmiguelez
2017-09-05 16:14 dmiguelez Status scheduled => resolved
2017-09-05 16:14 dmiguelez Fixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/4fa54a2fb83d [^]
2017-09-05 16:14 dmiguelez Resolution open => fixed
2017-09-05 16:16 dmiguelez Note Added: 0098836
2017-09-06 09:18 aferraz Note Added: 0098858
2017-09-06 09:22 aferraz Note Edited: 0098858 View Revisions
2017-09-13 09:24 hgbot Checkin
2017-09-13 09:24 hgbot Note Added: 0099002
2017-09-13 09:27 aferraz Note Deleted: 0099002
2017-09-13 21:30 hgbot Checkin
2017-09-13 21:30 hgbot Note Added: 0099017
2017-09-13 21:30 hgbot Checkin
2017-09-13 21:30 hgbot Note Added: 0099018
2017-09-13 21:31 aferraz Review Assigned To => aferraz
2017-09-13 21:31 aferraz Note Added: 0099019
2017-09-13 21:31 aferraz Status resolved => closed
2017-09-13 21:31 aferraz Fixed in Version => 3.0PR17Q4
2017-09-19 10:29 hgbot Checkin
2017-09-19 10:29 hgbot Note Added: 0099137
2017-09-21 16:49 hudsonbot Checkin
2017-09-21 16:49 hudsonbot Note Added: 0099383
2017-09-21 16:50 hudsonbot Checkin
2017-09-21 16:50 hudsonbot Note Added: 0099390
2017-09-21 16:50 hudsonbot Checkin
2017-09-21 16:50 hudsonbot Note Added: 0099415

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker