0036762: Window personalization list can not be loaded properly due to an error during its sorting

5a579bbc 120129 [http-bio-9080-exec-6] ERROR org.openbravo.client.application.WindowSettingsActionHandler - Error for window ADWindow(140) (name: Product)
org.openbravo.base.exception.OBException: Exception when getting personalization settings for window ADWindow(140) (name: Product)
	at org.openbravo.client.application.personalization.PersonalizationHandler.getPersonalizationForWindow(PersonalizationHandler.java:126)
	at org.openbravo.client.application.personalization.PersonalizationHandler$Proxy$_$$_WeldClientProxy.getPersonalizationForWindow(PersonalizationHandler$Proxy$_$$_WeldClientProxy.java)
	at org.openbravo.client.application.WindowSettingsActionHandler.execute(WindowSettingsActionHandler.java:105)
	at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:73)
	at org.openbravo.client.application.WindowSettingsActionHandler$Proxy$_$$_WeldClientProxy.execute(WindowSettingsActionHandler$Proxy$_$$_WeldClientProxy.java)
	at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:314)
	at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:206)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:624)
	at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228)
	at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:444)
	at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
	at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:58)
	at org.openbravo.client.kernel.KernelServlet.service(KernelServlet.java:168)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:731)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
	at org.codehaus.enunciate.webapp.HTTPRequestContextFilter.doFilter(HTTPRequestContextFilter.java:36)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
	at org.openbravo.client.analytics.OBSpringSecurityContextRequestFilter$1.doAction(OBSpringSecurityContextRequestFilter.java:71)
	at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
	at org.openbravo.client.analytics.OBSpringSecurityContextRequestFilter.doFilter(OBSpringSecurityContextRequestFilter.java:79)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
	at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
	at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
	at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
	at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
	at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
	at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
	at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
	at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:218)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:110)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:506)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
	at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:962)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:445)
	at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1115)
	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:637)
	at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:318)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.lang.Thread.run(Thread.java:745)
Caused by: org.openbravo.base.exception.OBException: Exception when getting personalization settings for window ADWindow(140) (name: Product)
	at org.openbravo.client.application.personalization.PersonalizationHandler.getPersonalizationsForWindow(PersonalizationHandler.java:254)
	at org.openbravo.client.application.personalization.PersonalizationHandler.getPersonalizationForWindow(PersonalizationHandler.java:98)
	... 57 more
Caused by: java.lang.IllegalArgumentException: Comparison method violates its general contract!
	at java.util.TimSort.mergeHi(TimSort.java:895)
	at java.util.TimSort.mergeAt(TimSort.java:512)
	at java.util.TimSort.mergeCollapse(TimSort.java:437)
	at java.util.TimSort.sort(TimSort.java:241)
	at java.util.Arrays.sort(Arrays.java:1512)
	at java.util.ArrayList.sort(ArrayList.java:1454)
	at java.util.Collections.sort(Collections.java:175)
	at org.openbravo.client.application.personalization.PersonalizationHandler.sortPersonalizations(PersonalizationHandler.java:270)
	at org.openbravo.client.application.personalization.PersonalizationHandler.getPersonalizationsForWindow(PersonalizationHandler.java:251)
	... 58 more

diff --git a/modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java b/modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
@@ -270,11 +270,11 @@
     Collections.sort(personalizations, new PersonalizationComparator(parentTree));
   }
 
-  private static class PersonalizationComparator implements Comparator<UIPersonalization> {
+  public static class PersonalizationComparator implements Comparator<UIPersonalization> {
 
     private List<String> parentTree;
 
-    private PersonalizationComparator(List<String> parentTree) {
+    public PersonalizationComparator(List<String> parentTree) {
       this.parentTree = parentTree;
     }
 new file mode 100644
--- /dev/null
+++ b/src-test/src/org/openbravo/test/SortPersonalizations.java
@@ -0,0 +1,84 @@
+package org.openbravo.test;
+
+import static org.hamcrest.Matchers.greaterThan;
+import static org.hamcrest.Matchers.lessThan;
+import static org.junit.Assert.assertThat;
+
+import java.util.List;
+
+import org.junit.Test;
+import org.openbravo.base.provider.OBProvider;
+import org.openbravo.client.application.UIPersonalization;
+import org.openbravo.client.application.personalization.PersonalizationHandler.PersonalizationComparator;
+import org.openbravo.dal.core.OBContext;
+import org.openbravo.dal.service.OBDal;
+import org.openbravo.model.ad.access.Role;
+import org.openbravo.model.ad.access.User;
+import org.openbravo.model.ad.system.Client;
+import org.openbravo.test.base.OBBaseTest;
+
+public class SortPersonalizations extends OBBaseTest {
+
+  @Test
+  public void sortIsTransitive() {
+    try {
+      OBContext.setAdminMode(true);
+      UIPersonalization a = OBProvider.getInstance().get(UIPersonalization.class);
+      a.setId("A");
+      a.setVisibleAtClient(OBDal.getInstance().getProxy(Client.class, TEST_CLIENT_ID));
+
+      UIPersonalization b = OBProvider.getInstance().get(UIPersonalization.class);
+      b.setId("B");
+      b.setUser(OBDal.getInstance().getProxy(User.class, TEST_USER_ID));
+
+      UIPersonalization c = OBProvider.getInstance().get(UIPersonalization.class);
+      c.setId("C");
+      c.setVisibleAtClient(OBDal.getInstance().getProxy(Client.class, TEST_CLIENT_ID));
+      c.setVisibleAtRole(OBDal.getInstance().getProxy(Role.class, TEST_ROLE_ID));
+
+      PersonalizationComparator comparator = getComparator();
+
+      if (comparator.compare(a, b) > 0 && comparator.compare(b, c) > 0) {
+        assertThat("A > B and B > C then A > C", comparator.compare(a, c), greaterThan(0));
+      }
+
+    } finally {
+      OBDal.getInstance().rollbackAndClose();
+      OBContext.restorePreviousMode();
+    }
+  }
+
+  @Test
+  public void sortIsConmutative() {
+    try {
+      OBContext.setAdminMode(true);
+      UIPersonalization a = OBProvider.getInstance().get(UIPersonalization.class);
+      a.setId("A");
+      a.setVisibleAtClient(OBDal.getInstance().getProxy(Client.class,
+          "23C59575B9CF467C9620760EB255B389"));
+
+      UIPersonalization b = OBProvider.getInstance().get(UIPersonalization.class);
+      b.setId("B");
+
+      PersonalizationComparator comparator = getComparator();
+
+      int res = comparator.compare(a, b);
+      assertThat("A > B", res, greaterThan(0));
+
+      res = comparator.compare(b, a);
+      assertThat("B < A", res, lessThan(0));
+
+    } finally {
+      OBDal.getInstance().rollbackAndClose();
+      OBContext.restorePreviousMode();
+    }
+  }
+
+  private PersonalizationComparator getComparator() {
+    List<String> parentTree = OBContext.getOBContext()
+        .getOrganizationStructureProvider(OBContext.getOBContext().getCurrentClient().getId())
+        .getParentList("0", true);
+    return new PersonalizationComparator(parentTree);
+  }
+
+}