Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036601
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-08-04 10:042017-08-04 12:46
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q4
StatusclosedFix in branchFixed in SCM revisionb74ed74f842a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036601: unneeded flush with no entities on every fetch

DescriptionWhenever datasoruce data is fetched, a flush is performed just after clearing the session. This actually has no effect as it's guaranteed session to be empty, so there's nothing to flush.
Steps To Reproduce1. Open Product window
2. Set OBDal class debug level to DEBUG
3. Click on Product's Refresh grid toolbar button
  -> check openbravo.log:

1f923ef8 690457 [http-bio-8080-exec-1] DEBUG org.openbravo.dal.service.OBDal - Dumping all entities in session
1f923ef8 690458 [http-bio-8080-exec-1] DEBUG org.openbravo.dal.service.OBDal - Flush of 0 entities and 0 collections took: 0
java.lang.Throwable
    at org.openbravo.dal.service.OBDal.flush(OBDal.java:268)
    at org.openbravo.service.json.DefaultJsonDataService.doPostAction(DefaultJsonDataService.java:1138)
    at org.openbravo.service.json.DefaultJsonDataService.fetch(DefaultJsonDataService.java:311)
Proposed SolutionDespite the performance impact is small, being unneeded it should be prevented.
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00265483.0PR14Q3 closedguillermogil Slow flush after a fetch to a datasource. 
blocks design defect 0036606 newTriage Platform Base Clean up extra not requires flush() calls 

-  Notes
(0098388)
alostale (manager)
2017-08-04 10:34

 https://code.openbravo.com/erp/devel/pi/rev/b74ed74f842a [^]
changeset: 32535:b74ed74f842a
tag: tip
user: Asier Lostalé <asier.lostale@openbravo.com>
date: Fri Aug 04 10:11:28 2017 +0200
files: modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
description:
fixed 36601: unneeded flush with no entities on every fetch

  Fix includes:
   - Do not flush on fetch just after clearing session as it is noop
   - Being action an enum can be directly compared without need of getting its name
(0098392)
caristu (developer)
2017-08-04 12:46

 Code reviewed + tested OK.

- Issue History
Date Modified Username Field Change
2017-08-04 10:04 alostale New Issue
2017-08-04 10:04 alostale Assigned To => platform
2017-08-04 10:04 alostale Modules => Core
2017-08-04 10:04 alostale Triggers an Emergency Pack => No
2017-08-04 10:04 alostale Review Assigned To => caristu
2017-08-04 10:04 alostale Tag Attached: Performance
2017-08-04 10:05 alostale Relationship added related to 0026548
2017-08-04 10:08 alostale Assigned To platform => alostale
2017-08-04 10:30 alostale Status new => scheduled
2017-08-04 10:34 alostale Note Added: 0098388
2017-08-04 10:34 alostale Status scheduled => resolved
2017-08-04 10:34 alostale Fixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/b74ed74f842a [^]
2017-08-04 10:34 alostale Resolution open => fixed
2017-08-04 12:46 caristu Note Added: 0098392
2017-08-04 12:46 caristu Status resolved => closed
2017-08-04 12:46 caristu Fixed in Version => 3.0PR17Q4
2017-08-04 13:16 shuehner Relationship added blocks 0036606

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker