Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0036589

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2017-08-03 11:49

2017-08-08 13:17

Reporter

jonibc

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR17Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0036589: [SERQA 3180] Performance problem getting documentNo

Description

Having BUT Production Environment, if more than one order is created using Ecommerce (External Order Loader), the same documentNo is assigned to all the orders created at the same time.

To avoid this behavior the following line was added:

OBDal.getInstance().refresh(lockedTerminal);

But it takes around a second to refresh the entity.

Steps To Reproduce

*Install BUT Production environment
*Using Jmeter, configure to send 3 ecommerce orders at the same time
*Using Java Profiler, check the time needed by the refresh method.
*Check in the backend that the same documentNo is assigned for the 3 orders

Proposed Solution

Evict the lockedTerminal to clean it in cache.
Do get() to obtain the right object.

Attached diff with the solution.

Tags

No tags attached.

posTerminal.diff [^] (870 bytes) 2017-08-03 11:49 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java b/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
--- a/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
+++ b/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
@@ -1061,7 +1061,8 @@
         terminalQuery.setString(0, posTerminal.getId());
         terminalQuery.setLockOptions(LockOptions.UPGRADE);
         OBPOSApplications lockedTerminal = (OBPOSApplications) terminalQuery.uniqueResult();
-        OBDal.getInstance().refresh(lockedTerminal);
+        OBDal.getInstance().getSession().evict(lockedTerminal);
+        lockedTerminal = OBDal.getInstance().get(OBPOSApplications.class, lockedTerminal.getId());
         if (lockedTerminal.getLastassignednum() != null) {
           currentNo = lockedTerminal.getLastassignednum() + 1;
         } else {

Relationships [ Relation Graph ] [ Dependency Graph ]

caused by

defect

closed

ranjith_qualiantech_com

[SERQA 3088] Duplicated documentNo for orders created in the same moment using External Order Loader

Notes
(0098378) hgbot (developer) 2017-08-04 08:00	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e7e610b702c92365fd49d3a682822fde637ea25d Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Aug 04 11:29:55 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7e610b702c92365fd49d3a682822fde637ea25d [^] Fixed issue 36589 : Terminal should be loaded by cleaning cache in ExternalorderLoader * Clear Terminal from cache and load the temrimal inorder to avaoid cache --- M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2017-08-03 11:49	jonibc	New Issue
2017-08-03 11:49	jonibc	Assigned To	=> Retail
2017-08-03 11:49	jonibc	File Added: posTerminal.diff
2017-08-03 11:49	jonibc	Resolution time	=> 1503007200
2017-08-03 11:49	jonibc	Triggers an Emergency Pack	=> No
2017-08-03 11:50	jonibc	Relationship added	caused by 0036423
2017-08-03 11:50	jonibc	Issue Monitored: jonibc
2017-08-03 14:27	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2017-08-03 14:28	ranjith_qualiantech_com	Status	new => scheduled
2017-08-04 08:00	hgbot	Checkin
2017-08-04 08:00	hgbot	Note Added: 0098378
2017-08-04 08:00	hgbot	Status	scheduled => resolved
2017-08-04 08:00	hgbot	Resolution	open => fixed
2017-08-04 08:00	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7e610b702c92365fd49d3a682822fde637ea25d [^]
2017-08-08 13:17	marvintm	Review Assigned To	=> marvintm
2017-08-08 13:17	marvintm	Status	resolved => closed
2017-08-08 13:17	marvintm	Fixed in Version	=> RR17Q4

Copyright © 2000 - 2009 MantisBT Group