Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0036499
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminorhave not tried2017-07-15 13:512017-07-31 11:47
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisione1e795ad2749
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshuehner
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036499: API changes related to removal of 2.50 code

DescriptionIn the 2.50 removal project/issue: 36498 lots of old unused code related to 2.50 style windows has been remove resulting in the following API changes.

A search in all published modules in forge/centralrepository has been done and no module is using those so the risk to break modules is low.

Changes regarding java api:

The following classes have been removed:
1.) class org.openbravo.erpCommon.businessUtility.Buscador
2.) class org.openbravo.erpCommon.businessUtility.BuscadorData (generated from xsql file)
3.) class org.openbravo.erpCommon.utility.DataGrid
4.) class org.openbravo.erpCommon.utility.ExportGrid
5.) class org.openbravo.erpCommon.utility.KeyMap
6.) class.org.openbravo.erpCommon.utility.ModelSQLGeneration

Removal of public elements in the following classes:
1.) in class org.openbravo.erpCommon.utility.TableSQLData:
a.) Everything except the constant maxRowsPerGridPage and the function calcAndGetBackendPage has been removed
b.) Full list of removals:
- both constructors
- constant INACTIVE_DATA
- member index
- method addFromField
- method addFromParameter
- method addSelectField
- method getKeyColumn
- method getParameterValuesOnlyId
- method getPool
- method getTabID
- method getTableName
- method getVars
- method hasInternalFilter
- method setParameter

2.) in class org.openbravo.erpCommon.utility.ExecuteQuery
- method executeStatement
- method selectAndSearch
- enum SearchType

3.) in class org.openbravo.erpCommon.utility.ComboTableData
- method fillParametersFromSearch

4.) in class org.openbravo.erpCommon.utility.Utility
- method fillTableSQLParameters

5.) in class org.openbravo.erpCommon.WindowAccessData (xsql generated)
- method hasnotDeleteAccess

6.) in class org.openbravo.referenace.ui.UIReference (and all sub-classes)
a.) member:
- addSecondaryFilter
- conn
- strIsSOTrx
- strReplaceWith
b.) methods:
- generateFilterAcceptScript
- generateFilterHtml
- generateSQL
- getFilter
- getGridType
- hasSecondaryFilter
- identifier
- setReplaceWith
- setStrIsSOTrx

7.) in class org.openbravo.reference.ui.UIReferenceUtility
- method addFilter
- method addUniqueElement
- method checkTableTranslation
- method fieldtoProperties

Changes in classes:
1.) class org.openbravo.erpCommon.TableSQLData does no longer implement Serializable

Removals regarding model:
- row from table AD_MODEL_OBJECT - ID: 800662
- row from table AD_MODEL_OBJECT - ID: 801433
- row from table AD_MODEL_OBJECT - ID: 96ED899EC5704BA9961340A934B62133
- row from table AD_MODEL_OBJECT_MAPPING - ID: 800833
- row from table AD_MODEL_OBJECT_MAPPING - ID: 802179
- row from table AD_MODEL_OBJECT_MAPPING - ID: 802668
- row from table AD_MODEL_OBJECT_MAPPING - ID: 802669
- row from table AD_MODEL_OBJECT_MAPPING - ID: 802670
- row from table AD_MODEL_OBJECT_MAPPING - ID: 3CCD2540F0B2441484C256772EBBCC93
Steps To Reproducehttps://ci.openbravo.com/job/try-api/5119/consoleText [^]

TagsApproved
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0036498 closedshuehner Lots of code related to already removed 2.50 windows is still in pi and should be deleted 

-  Notes
(0098151)
hgbot (developer)
2017-07-20 13:51

Repository: erp/devel/api-checks
Changeset: e1e795ad274996030cd46b2b4a0aa561c9d2863e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jul 20 13:50:42 2017 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/e1e795ad274996030cd46b2b4a0aa561c9d2863e [^]

Fixed 36499. Accept api change: lots of removals of old unused 2.50 related code.

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---

- Issue History
Date Modified Username Field Change
2017-07-15 13:51 shuehner New Issue
2017-07-15 13:51 shuehner Assigned To => Triage Finance
2017-07-15 13:51 shuehner Modules => Core
2017-07-15 13:51 shuehner Triggers an Emergency Pack => No
2017-07-15 13:51 shuehner Relationship added related to 0036498
2017-07-15 13:51 shuehner Assigned To Triage Finance => dmitry_mezentsev
2017-07-17 09:55 dmitry_mezentsev Tag Attached: Approved
2017-07-17 09:55 dmitry_mezentsev Assigned To dmitry_mezentsev => shuehner
2017-07-20 13:51 hgbot Checkin
2017-07-20 13:51 hgbot Note Added: 0098151
2017-07-20 13:51 hgbot Status new => resolved
2017-07-20 13:51 hgbot Resolution open => fixed
2017-07-20 13:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/e1e795ad274996030cd46b2b4a0aa561c9d2863e [^]
2017-07-31 11:47 shuehner Review Assigned To => shuehner
2017-07-31 11:47 shuehner Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker