Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0036481 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
design defect | [Retail Modules] Web POS | major | always | 2017-07-12 18:51 | 2017-07-27 10:21 | |||
Reporter | kchoperena | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 5d2c77ae365c | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | migueldejuana | |||||||
OBNetwork customer | OBPS | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0036481: [STORE SERVER 3094]: A fully paid layaway has isLayaway = N | |||||||
Description | When we create an order using ExternalOrderLoader, if the layaway is fully paid it is never detected. If we pay fully when the execution achieve the orderLoader, the fullypaidLayaway variable is always false because never satisfy the next condition: fullypaidLayaway = (jsonorder.getBoolean("isLayaway") || jsonorder.optLong("orderType") == 2) && Math.abs(jsonorder.getDouble("payment")) >= Math.abs(jsonorder.getDouble("gross")); This happens because ExternalOrderLoader is setting property payment to value -1 | |||||||
Steps To Reproduce | 1.- Create a layaway using EcommerceCreateOrderWS 2.- Create a payment using EcommerceCreatePaymentWS EXPECTED RESULTS: The flag isLayaway will be N, because payment is not detected. | |||||||
Proposed Solution | It is needed to set the payment property from the received JSON. Order Loader should be able to avoid update delivered quantity when not generated shipment. It is needed that the ExternalOrderLoader class, add the previous paid quantity (should get it from DB) in order to detect that the layaway has been completely paid. Attached patch with suggested solution. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
||||||||
|
![]() |
|
(0098141) hgbot (developer) 2017-07-20 09:41 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 2cd793c0149767c5dc67d24741bc8fc2f10782f1 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Jul 20 09:41:27 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2cd793c0149767c5dc67d24741bc8fc2f10782f1 [^] Fixes issue 36481: [STORE SERVER 3094]: A fully paid layaway has isLayaway = N Compute the value of the payments property in the ExternalOrderLoader OrderLoader: set delivered and deliveredquantity in the createshipment logic --- M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
(0098153) hgbot (developer) 2017-07-20 14:59 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 4a38031eaf8572a56b41642df630681c4702c1b0 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Jul 20 14:59:13 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a38031eaf8572a56b41642df630681c4702c1b0 [^] Related to issue 0036481: [STORE SERVER 3094]: A fully paid layaway has isLayaway = N Backed out changeset 2cd793c01497 It is breaking: CancelAndRplcAmountIncreased, CancelAndRplcOfCancelAndRplc, I35955_CancelAndRplcFromCredit, CancelAndRplcOfCancelAndRplc, I35955_CancelAndRplcFromCredit --- M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
(0098154) migueldejuana (viewer) 2017-07-20 15:00 |
It is breaking: CancelAndRplcAmountIncreased, CancelAndRplcOfCancelAndRplc, I35955_CancelAndRplcFromCredit, CancelAndRplcOfCancelAndRplc, I35955_CancelAndRplcFromCredit |
(0098185) hgbot (developer) 2017-07-22 22:10 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 5d2c77ae365cec69ffdf39f657d0ccae2bb011ab Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat Jul 22 22:10:30 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5d2c77ae365cec69ffdf39f657d0ccae2bb011ab [^] Fixes issue 36481: [STORE SERVER 3094]: A fully paid layaway has isLayaway = N Compute the value of the payments property in the ExternalOrderLoader OrderLoader: set delivered and deliveredquantity in the createshipment logic --- M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
(0098186) hgbot (developer) 2017-07-22 22:12 |
Repository: tools/automation/pi-mobile Changeset: 05fce0fb56a709b716c4cc143bc2459ea928fcf0 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat Jul 22 22:12:13 2017 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/05fce0fb56a709b716c4cc143bc2459ea928fcf0 [^] Related to issue 36481: [STORE SERVER 3094]: A fully paid layaway has isLayaway = N Adapted testcase so that it has multiple lines, check delivered status --- M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/RetailOrderLoaderTest.java M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-create-1.json M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-paypartial1-1.json M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-paypartial2-1.json M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-ship-1.json --- |
(0098241) migueldejuana (viewer) 2017-07-27 10:21 |
Reviewed |
![]() |
|||
Date Modified | Username | Field | Change |
2017-07-12 18:51 | kchoperena | New Issue | |
2017-07-12 18:51 | kchoperena | Assigned To | => mtaal |
2017-07-12 18:51 | kchoperena | OBNetwork customer | => Yes |
2017-07-12 18:51 | kchoperena | Resolution time | => 1499983200 |
2017-07-12 18:51 | kchoperena | Triggers an Emergency Pack | => No |
2017-07-14 11:20 | jonibc | Assigned To | mtaal => |
2017-07-14 11:20 | jonibc | Category | StoreServer => Web POS |
2017-07-14 11:20 | jonibc | Description Updated | View Revisions |
2017-07-14 11:20 | jonibc | Steps to Reproduce Updated | View Revisions |
2017-07-14 11:20 | jonibc | Proposed Solution updated | |
2017-07-14 11:28 | jonibc | Proposed Solution updated | |
2017-07-14 12:08 | jonibc | File Added: patchPosTerminal.diff | |
2017-07-17 09:37 | jonibc | Issue Monitored: jonibc | |
2017-07-19 18:24 | mtaal | Assigned To | => mtaal |
2017-07-20 09:41 | hgbot | Checkin | |
2017-07-20 09:41 | hgbot | Note Added: 0098141 | |
2017-07-20 09:41 | hgbot | Status | new => resolved |
2017-07-20 09:41 | hgbot | Resolution | open => fixed |
2017-07-20 09:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2cd793c0149767c5dc67d24741bc8fc2f10782f1 [^] |
2017-07-20 09:42 | mtaal | Review Assigned To | => migueldejuana |
2017-07-20 14:59 | hgbot | Checkin | |
2017-07-20 14:59 | hgbot | Note Added: 0098153 | |
2017-07-20 15:00 | migueldejuana | Note Added: 0098154 | |
2017-07-20 15:00 | migueldejuana | Status | resolved => new |
2017-07-20 15:00 | migueldejuana | Resolution | fixed => open |
2017-07-22 22:10 | hgbot | Checkin | |
2017-07-22 22:10 | hgbot | Note Added: 0098185 | |
2017-07-22 22:10 | hgbot | Status | new => resolved |
2017-07-22 22:10 | hgbot | Resolution | open => fixed |
2017-07-22 22:10 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2cd793c0149767c5dc67d24741bc8fc2f10782f1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5d2c77ae365cec69ffdf39f657d0ccae2bb011ab [^] |
2017-07-22 22:12 | hgbot | Checkin | |
2017-07-22 22:12 | hgbot | Note Added: 0098186 | |
2017-07-27 10:21 | migueldejuana | Note Added: 0098241 | |
2017-07-27 10:21 | migueldejuana | Status | resolved => closed |
2017-07-31 11:58 | asiermartirena | Relationship added | related to 0036548 |
Copyright © 2000 - 2009 MantisBT Group |